From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.6397.1602368182419679724
 for <devel@edk2.groups.io>;
 Sat, 10 Oct 2020 15:16:23 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: fengyunhua@byosoft.com.cn)
Received: from LAPTOP2AECFQIA ([117.143.52.23])
	(envelope-sender <fengyunhua@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Sun, 11 Oct 2020 06:16:14 +0800
X-WM-Sender: fengyunhua@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: fengyunhua@byosoft.com.cn
From: "fengyunhua" <fengyunhua@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<michael.kubacki@outlook.com>
Cc: <gaoliming@byosoft.com.cn>,
	<bob.c.feng@intel.com>
References: <000001d69eb2$6f3eeb10$4dbcc130$@byosoft.com.cn>  <MWHPR07MB344061D0588CD5665A1E0FF7E9090@MWHPR07MB3440.namprd07.prod.outlook.com>
In-Reply-To: <MWHPR07MB344061D0588CD5665A1E0FF7E9090@MWHPR07MB3440.namprd07.prod.outlook.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBCYXNlVG9vbHM6IEFkZCBFREtJSV9EU0NfUExBVEZPUk1fR1VJRCBNQUNSTw==?=
Date: Sun, 11 Oct 2020 06:16:09 +0800
Message-ID: <000001d69f52$facc0e60$f0642b20$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQJ8U3up05xkQPWP7PAqpooEsHs7twKp2rU+qDCvJcA=
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

I will update it.

Thanks
Yunhua

-----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
=E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66109+5049190+8953120@groups.io =
<bounce+27952+66109+5049190+8953120@groups.io> =E4=BB=A3=E8=A1=A8 Michael K=
ubacki
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8811=E6=97=A5 =
5:22
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; fengyunhua@byosoft.com.=
cn
=E6=8A=84=E9=80=81: gaoliming@byosoft.com.cn; bob.c.feng@intel.com
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH] BaseTools: Add EDKII_DSC_PLAT=
FORM_GUID MACRO

Tested-by: Michael Kubacki <michael.kubacki@microsoft.com>

It looks like you're only putting one space of indentation before the GUID=
 is printed on the new line after EDKII_DSC_PLATFORM_GUID and there should =
be two.

#define EDKII_DSC_PLATFORM_GUID \\\n %s

Should be:

#define EDKII_DSC_PLATFORM_GUID \\\n  %s

Two spaces before GUID:
#define EFI_CALLER_ID_GUID \
   {0x1652B3C2, 0xA7A1, 0x46AC, {0xAF, 0x93, 0xDD, 0x6D, 0xEE, 0x44, 0x66,=
 0x69}}

One space before GUID:
#define EDKII_DSC_PLATFORM_GUID \
  {0xC29BB610, 0x84F9, 0x448D, {0xA7, 0xDD, 0x5A, 0x04, 0xC5, 0xA5, 0x4F, =
0x52}}

On 10/9/2020 8:07 PM, fengyunhua wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2969
>=20
> Add EDKII_DSC_PLATFORM_GUID MACRO
>=20
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
>   BaseTools/Source/Python/AutoGen/GenC.py | 3 +++
>   1 file changed, 3 insertions(+)
>=20
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py=20
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index 5e0d11e165..5b63d278be 100755
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -1980,12 +1980,14 @@ def CreateHeaderCode(Info, AutoGenC, AutoGenH):
>           AutoGenH.Append("#include <Library/PcdLib.h>\n")
>  =20
>       AutoGenH.Append('\nextern GUID  gEfiCallerIdGuid;')
> +    AutoGenH.Append('\nextern GUID  gEdkiiDscPlatformGuid;')
>       AutoGenH.Append('\nextern CHAR8 *gEfiCallerBaseName;\n\n')
>  =20
>       if Info.IsLibrary:
>           return
>  =20
>       AutoGenH.Append("#define EFI_CALLER_ID_GUID \\\n  %s\n" %=20
> GuidStringToGuidStructureString(Info.Guid))
> +    AutoGenH.Append("#define EDKII_DSC_PLATFORM_GUID \\\n %s\n" %=20
> + GuidStringToGuidStructureString(Info.PlatformInfo.Guid))
>  =20
>       if Info.IsLibrary:
>           return
> @@ -2002,6 +2004,7 @@ def CreateHeaderCode(Info, AutoGenC, AutoGenH):
>       # Publish the CallerId Guid
>       #
>       AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED GUID=20
> gEfiCallerIdGuid =3D %s;\n' %=20
> GuidStringToGuidStructureString(Info.Guid))
> +    AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED GUID=20
> + gEdkiiDscPlatformGuid =3D %s;\n' %=20
> + GuidStringToGuidStructureString(Info.PlatformInfo.Guid))
>       AutoGenC.Append('\nGLOBAL_REMOVE_IF_UNREFERENCED CHAR8=20
> *gEfiCallerBaseName =3D "%s";\n' % Info.Name)
>  =20
>   ## Create common code for header file
>=20