public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <michael.kubacki@outlook.com>
Cc: "'Guomin Jiang'" <guomin.jiang@intel.com>,
	"'Wei6 Xu'" <wei6.xu@intel.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Matthew Carlson'" <matthewfcarlson@gmail.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC
Date: Fri, 16 Oct 2020 08:56:12 +0800	[thread overview]
Message-ID: <000001d6a357$249560e0$6dc022a0$@byosoft.com.cn> (raw)
In-Reply-To: <MWHPR07MB3440B00553D390B272E7D869E9020@MWHPR07MB3440.namprd07.prod.outlook.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: bounce+27952+66286+4905953+8761045@groups.io
> <bounce+27952+66286+4905953+8761045@groups.io> 代表 Michael
> Kubacki
> 发送时间: 2020年10月16日 4:43
> 收件人: devel@edk2.groups.io
> 抄送: Guomin Jiang <guomin.jiang@intel.com>; Wei6 Xu
> <wei6.xu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael D
> Kinney <michael.d.kinney@intel.com>; Matthew Carlson
> <matthewfcarlson@gmail.com>
> 主题: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to
> DSC
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3010
> 
> Commit b5701a4 in CryptoPkg introduced a dependency on RngLib.
> 
> The FmpDevicePkg build currently fails since it does not specify
> a RngLib instance and OpensslLib links against RngLib.
> 
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Matthew Carlson <matthewfcarlson@gmail.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  FmpDevicePkg/FmpDevicePkg.dsc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc
> b/FmpDevicePkg/FmpDevicePkg.dsc
> index bdb73f28288f..cfeadd833038 100644
> --- a/FmpDevicePkg/FmpDevicePkg.dsc
> +++ b/FmpDevicePkg/FmpDevicePkg.dsc
> @@ -6,7 +6,7 @@
>  # Capsules.  The behavior of the Firmware Management Protocol instance
> is
>  # customized using libraries and PCDs.
>  #
> -# Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.<BR>
>  # Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.<BR>
>  # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All
rights
> reserved.<BR>
>  #
> @@ -57,6 +57,7 @@ [LibraryClasses]
>    IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
>    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> +  RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf
>  !endif
> 
> FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpA
> uthenticationLibPkcs7.inf
> 
> CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/
> CapsuleUpdatePolicyLibNull.inf
> --
> 2.28.0.windows.1
> 
> 
> 
> 
> 




  reply	other threads:[~2020-10-16  0:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 20:42 [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC Michael Kubacki
2020-10-16  0:56 ` gaoliming [this message]
2020-10-16 15:12 ` Michael D Kinney
2020-10-19  1:49   ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d6a357$249560e0$6dc022a0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox