public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "fengyunhua" <fengyunhua@byosoft.com.cn>
To: <devel@edk2.groups.io>, <mingyuex.liang@intel.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Liming Gao'" <gaoliming@byosoft.com.cn>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools: Catch the exception in build.py.
Date: Thu, 5 Nov 2020 09:15:56 +0800	[thread overview]
Message-ID: <000001d6b311$36970090$a3c501b0$@byosoft.com.cn> (raw)
In-Reply-To: <20201104075304.382-1-mingyuex.liang@intel.com>

I tried this patch, modified OvmfPkgIa32.fdf
INF  OvmfPkg/Sec/SecMain.inf
===>
INM  OvmfPkg/Sec/SecMain.inf

the error message as below:

build.py...
c:\work\edk2\OvmfPkg\OvmfPkgIa32.fdf(118): error 3000: Invalid syntax/format
        expected [FD.] near line 110, column 22: TRUE

on my opinion, "expected [FD.]" is not correct

-----邮件原件-----
发件人: bounce+27952+66996+5049190+8953120@groups.io
<bounce+27952+66996+5049190+8953120@groups.io> 代表 mliang2x
发送时间: 2020年11月4日 15:53
收件人: devel@edk2.groups.io
抄送: Mingyue Liang <mingyuex.liang@intel.com>; Bob Feng
<bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen
<yuwei.chen@intel.com>
主题: [edk2-devel] [PATCH] BaseTools: Catch the exception in build.py.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2988

In FDF file, if INF key word is wrongly written as INT,
build tool will report the execption. Build tool should
report the error message.

build.py In order to capture and handle the exception
of fdfparser, the user-defined exception class should
be imported.

Signed-off-by: Mingyue Liang <mingyuex.liang@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
---
 BaseTools/Source/Python/build/build.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/build/build.py
b/BaseTools/Source/Python/build/build.py
index 1ab1e60a64..49165ea355 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -62,6 +62,7 @@ from AutoGen.ModuleAutoGenHelper import WorkSpaceInfo,
PlatformInfo
 from GenFds.FdfParser import FdfParser
 from AutoGen.IncludesAutoGen import IncludesAutoGen
 from GenFds.GenFds import resetFdsGlobalVariable
+from GenFds.FdfParser import Warning
 
 ## standard targets of build command
 gSupportedTarget = ['all', 'genc', 'genmake', 'modules', 'libraries',
'fds', 'clean', 'cleanall', 'cleanlib', 'run']
-- 
2.28.0.windows.1









  reply	other threads:[~2020-11-05  1:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  7:53 [PATCH] BaseTools: Catch the exception in build.py mliang2x
2020-11-05  1:15 ` fengyunhua [this message]
2020-11-06  3:26   ` [edk2-devel] " Bob Feng
2022-02-15  6:01   ` [edk2-devel] 回复: " Mingyue Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d6b311$36970090$a3c501b0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox