From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.5362.1606353101522490571 for ; Wed, 25 Nov 2020 17:11:43 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 26 Nov 2020 09:11:40 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Wang, Jian J'" , "'Mistry, Nishant C'" References: <20201124012231.1869-1-gaoliming@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gUmV2ZXJ0ICJTZWN1cml0eVBrZzogQWRkIFJQTUMgSW5kZXggdG8gdGhlIFJwbWNMaWIi?= Date: Thu, 26 Nov 2020 09:11:39 +0800 Message-ID: <000001d6c391$181a2850$484e78f0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEs6k3tmkraXF4TMbxb3isJIze3VwJcH8Ciqxpsi4A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Create PR https://github.com/tianocore/edk2/pull/1146 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+67855+4905953+8761045@groups.io > =B4=FA=B1=ED Yao, Jiewen > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C224=C8=D5 9:29 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; gaoliming@byosoft.com.cn > =B3=AD=CB=CD: Wang, Jian J ; Mistry, Nishant C > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH 1/1] Revert "SecurityPkg: Add RPMC= Index to > the RpmcLib" >=20 > Acked-by: Jiewen Yao > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > gaoliming > > Sent: Tuesday, November 24, 2020 9:23 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Mistry, Nishant C > > Subject: [edk2-devel] [PATCH 1/1] Revert "SecurityPkg: Add RPMC Index = to > > the RpmcLib" > > > > This reverts commit 6c8dd15c4ae42501438a525ec41299f365f223cb. > > > > Based on the discussion https://edk2.groups.io/g/devel/message/67764, > > this change is regarded as the feature request. But, it doesn't pass > > reviewed before 202011 stable tag soft feature freeze. So, it should > > not be merged into 202011 stable tag. > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Nishant C Mistry > > Signed-off-by: Liming Gao > > --- > > This patch targets for 202011 stable tag. > > > > SecurityPkg/Include/Library/RpmcLib.h | 6 +----- > > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 6 +----- > > 2 files changed, 2 insertions(+), 10 deletions(-) > > > > diff --git a/SecurityPkg/Include/Library/RpmcLib.h > > b/SecurityPkg/Include/Library/RpmcLib.h > > index 3c15bce1ce85..5882bfae2f24 100644 > > --- a/SecurityPkg/Include/Library/RpmcLib.h > > +++ b/SecurityPkg/Include/Library/RpmcLib.h > > @@ -14,7 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > /** > > Requests the monotonic counter from the designated RPMC counter. > > > > - @param[in] CounterIndex The RPMC index > > @param[out] CounterValue A pointer to a buffer to > store the RPMC > > value. > > > > @retval EFI_SUCCESS The operation completed > successfully. > > @@ -24,15 +23,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > EFI_STATUS > > EFIAPI > > RequestMonotonicCounter ( > > - IN UINT8 CounterIndex, > > OUT UINT32 *CounterValue > > ); > > > > /** > > Increments the monotonic counter in the SPI flash device by 1. > > > > - @param[in] CounterIndex The RPMC index > > - > > @retval EFI_SUCCESS The operation completed > successfully. > > @retval EFI_DEVICE_ERROR A device error occurred > while > > attempting to update the counter. > > @retval EFI_UNSUPPORTED The operation is > un-supported. > > @@ -40,7 +36,7 @@ RequestMonotonicCounter ( > > EFI_STATUS > > EFIAPI > > IncrementMonotonicCounter ( > > - IN UINT8 CounterIndex > > + VOID > > ); > > > > #endif > > diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > index 697e493a7cea..e1dd09eb10a0 100644 > > --- a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > +++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > @@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > /** > > Requests the monotonic counter from the designated RPMC counter. > > > > - @param[in] CounterIndex The RPMC index > > @param[out] CounterValue A pointer to a buffer to > store the RPMC > > value. > > > > @retval EFI_SUCCESS The operation completed > successfully. > > @@ -22,7 +21,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > EFI_STATUS > > EFIAPI > > RequestMonotonicCounter ( > > - IN UINT8 CounterIndex, > > OUT UINT32 *CounterValue > > ) > > { > > @@ -33,8 +31,6 @@ RequestMonotonicCounter ( > > /** > > Increments the monotonic counter in the SPI flash device by 1. > > > > - @param[in] CounterIndex The RPMC index > > - > > @retval EFI_SUCCESS The operation completed > successfully. > > @retval EFI_DEVICE_ERROR A device error occurred > while > > attempting to update the counter. > > @retval EFI_UNSUPPORTED The operation is > un-supported. > > @@ -42,7 +38,7 @@ RequestMonotonicCounter ( > > EFI_STATUS > > EFIAPI > > IncrementMonotonicCounter ( > > - IN UINT8 CounterIndex > > + VOID > > ) > > { > > ASSERT (FALSE); > > -- > > 2.27.0.windows.1 > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20