From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.1548.1610066661288367608 for ; Thu, 07 Jan 2021 16:44:22 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 08 Jan 2021 08:44:12 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: "'Ni, Ray'" , References: In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMl0gTWRlUGtnOiBEZWZpbmUgc3RydWN0dXJlcyBmb3IgUmVzaXphYmxlIEJBUiBDYXBhYmlsaXR5?= Date: Fri, 8 Jan 2021 08:44:16 +0800 Message-ID: <000001d6e557$64bb24b0$2e316e10$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEGlC8QGfPMjdapQoT9EMIM3XpZnQGbI3C9q7CtFHA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Cindy: Do you find any impact by this change?=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+69934+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Cindy = Roberts > via groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B41=E6=9C=887=E6=97=A5 = 22:52 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; heng.luo@intel.com > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/2] MdePkg: Define structur= es for Resizable > BAR Capability >=20 > Stop! >=20 > Cindy >=20 > > On Jan 7, 2021, at 12:32 AM, Heng Luo wrote: > > > > =EF=BB=BFHi Liming, > > Ray and I have evaluated the impact, we think only > UefiShellDebug1CommandsLib/Pci.c uses this structure, I have change thi= s > file in this patch, we think it doesn't impact Edk2 and Edk2Platforms. > > > > Thanks, > > Heng > > > >> -----Original Message----- > >> From: devel@edk2.groups.io On Behalf Of > >> gaoliming > >> Sent: Tuesday, December 29, 2020 9:46 AM > >> To: devel@edk2.groups.io; Luo, Heng > >> Cc: Ni, Ray ; Wu, Hao A > >> Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH 1/2] MdePkg: Define = structures for > >> Resizable BAR Capability > >> > >> Heng: > >> This is the incompatible change. Have you evaluated its impact in Ed= k2 > and > >> Edk2Platforms? > >> > >> Thanks > >> Liming > >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+69477+4905953+8761045@grou= ps.io > >>> =E4=BB=A3=E8=A1=A8 He= ng Luo > >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=8828=E6= =97=A5 16:26 > >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > >>> =E6=8A=84=E9=80=81: Ray Ni ; Hao A Wu > >>> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/2] MdePkg: Define structur= es for Resizable > >>> BAR Capability > >>> > >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3138 > >>> > >>> Define structures for Resizable BAR Capability in > >>> MdePkg/Include/IndustryStandard/PciExpress21.h, > >>> Change ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > >>> to use new structures. > >>> > >>> Cc: Ray Ni > >>> Cc: Hao A Wu > >>> Signed-off-by: Heng Luo > >>> --- > >>> MdePkg/Include/IndustryStandard/PciExpress21.h | 30 > >>> +++++++++++++++++++++++++----- > >>> ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 6 +++--- > >>> 2 files changed, 28 insertions(+), 8 deletions(-) > >>> > >>> diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h > >>> b/MdePkg/Include/IndustryStandard/PciExpress21.h > >>> index 2c07cb560e..b7629444eb 100644 > >>> --- a/MdePkg/Include/IndustryStandard/PciExpress21.h > >>> +++ b/MdePkg/Include/IndustryStandard/PciExpress21.h > >>> @@ -1,7 +1,7 @@ > >>> /** @file > >>> > >>> Support for the latest PCI standard. > >>> > >>> > >>> > >>> - Copyright (c) 2006 - 2018, Intel Corporation. All rights > >>> reserved.
> >>> > >>> + Copyright (c) 2006 - 2020, Intel Corporation. All rights > >>> + reserved.
> >>> > >>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> >>> > >>> SPDX-License-Identifier: BSD-2-Clause-Patent > >>> > >>> > >>> > >>> @@ -632,10 +632,30 @@ typedef struct { #define > >>> PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_ID > >>> 0x0015 > >>> > >>> #define PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_VER1 > 0x1 > >>> > >>> > >>> > >>> +typedef union { > >>> > >>> + struct { > >>> > >>> + UINT32 Reserved:4; > >>> > >>> + UINT32 BarSizeCapability:28; > >>> > >>> + } Bits; > >>> > >>> + UINT32 Uint32; > >>> > >>> +} PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CAPABILITY; > >>> > >>> + > >>> > >>> + > >>> > >>> +typedef union { > >>> > >>> + struct { > >>> > >>> + UINT32 BarIndex:3; > >>> > >>> + UINT32 Reserved:2; > >>> > >>> + UINT32 ResizableBarNumber:3; > >>> > >>> + UINT32 BarSize:6; > >>> > >>> + UINT32 Reserved2:2; > >>> > >>> + UINT32 BarSizeCapability:16; > >>> > >>> + } Bits; > >>> > >>> + UINT32 Uint32; > >>> > >>> +} PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CONTROL; > >>> > >>> + > >>> > >>> typedef struct { > >>> > >>> - UINT32 > >>> ResizableBarCapability; > >>> > >>> - UINT16 > >>> ResizableBarControl; > >>> > >>> - UINT16 > >>> Reserved; > >>> > >>> + > PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CAPABILITY > >>> ResizableBarCapability; > >>> > >>> + PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CONTROL > >>> ResizableBarControl; > >>> > >>> } PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_ENTRY; > >>> > >>> > >>> > >>> typedef struct { > >>> > >>> @@ -643,7 +663,7 @@ typedef struct { > >>> PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_ENTRY > >>> Capability[1]; > >>> > >>> } PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR; > >>> > >>> > >>> > >>> -#define GET_NUMBER_RESIZABLE_BARS(x) > >>> (((x->Capability[0].ResizableBarControl) & 0xE0) >> 5) > >>> > >>> +#define GET_NUMBER_RESIZABLE_BARS(x) > >>> (x->Capability[0].ResizableBarControl.Bits.ResizableBarNumber) > >>> > >>> > >>> > >>> #define PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_ID > >>> 0x000E > >>> > >>> #define PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_VER1 > 0x1 > >>> > >>> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > >>> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > >>> index 3e138188ce..5077d56fed 100644 > >>> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > >>> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > >>> @@ -1,7 +1,7 @@ > >>> /** @file > >>> > >>> Main file for Pci shell Debug1 function. > >>> > >>> > >>> > >>> - Copyright (c) 2005 - 2019, Intel Corporation. All rights > >>> reserved.
> >>> > >>> + Copyright (c) 2005 - 2020, Intel Corporation. All rights > >>> + reserved.
> >>> > >>> (C) Copyright 2013-2015 Hewlett-Packard Development Company, > >>> L.P.
> >>> > >>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> >>> > >>> SPDX-License-Identifier: BSD-2-Clause-Patent > >>> > >>> @@ -5534,8 +5534,8 @@ > >>> PrintInterpretedExtendedCompatibilityResizeableBar ( > >>> STRING_TOKEN (STR_PCI_EXT_CAP_RESIZE_BAR), > >>> > >>> gShellDebug1HiiHandle, > >>> > >>> ItemCount+1, > >>> > >>> - Header->Capability[ItemCount].ResizableBarCapability, > >>> > >>> - Header->Capability[ItemCount].ResizableBarControl > >>> > >>> + Header->Capability[ItemCount].ResizableBarCapability.Uint32, > >>> > >>> + Header->Capability[ItemCount].ResizableBarControl.Uint32 > >>> > >>> ); > >>> > >>> } > >>> > >>> > >>> > >>> -- > >>> 2.24.0.windows.2 > >>> > >>> > >>> > >>> -=3D-=3D-=3D-=3D-=3D-=3D > >>> Groups.io Links: You receive all messages sent to this group. > >>> View/Reply Online (#69477): > >>> https://edk2.groups.io/g/devel/message/69477 > >>> Mute This Topic: https://groups.io/mt/79265864/4905953 > >>> Group Owner: devel+owner@edk2.groups.io > >>> Unsubscribe: https://edk2.groups.io/g/devel/unsub > >>> [gaoliming@byosoft.com.cn] > >>> -=3D-=3D-=3D-=3D-=3D-=3D > >>> > >> > >> > >> > >> > >> > >> > >> > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20