From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.16229.1650504472958702557
 for <devel@edk2.groups.io>;
 Wed, 20 Apr 2022 18:27:54 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([101.224.116.119])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <ardb@kernel.org>; Thu, 21 Apr 2022 09:27:46 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 101.224.116.119
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Oliver Steffen'" <osteffen@redhat.com>,
	<devel@edk2.groups.io>,
	<ardb@kernel.org>
Cc: <bob.c.feng@intel.com>,
	<yuwei.chen@intel.com>
References: <16E78AC5D5F67B5F.27458@groups.io> <20220420081603.27503-1-osteffen@redhat.com> <20220420081603.27503-2-osteffen@redhat.com>
In-Reply-To: <20220420081603.27503-2-osteffen@redhat.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjIgMS8xXSBCYXNlVG9vbHM6IGRpc2FibGUgc3RhY2sgcHJvdGVjdG9yIChnY2MsIEFBUkNINjQp?=
Date: Thu, 21 Apr 2022 09:27:51 +0800
Message-ID: <000001d8551f$04a24480$0de6cd80$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQMSvMCmrwwFxg987OQvx4PpNeRIjQJ6RiHTAa+PyQ6qY3V38A==
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Oliver:=20
  The change is good to me. I also include ARM maintainer Ard to review =
this
change.=20
 =20
  Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
 =20
Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Oliver Steffen <osteffen@redhat.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA4=D4=C220=C8=D5 16:16
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: bob.c.feng@intel.com; gaoliming@byosoft.com.cn;
> yuwei.chen@intel.com; Oliver Steffen <osteffen@redhat.com>
> =D6=F7=CC=E2: [PATCH v2 1/1] BaseTools: disable stack protector (gcc, =
AARCH64)
>=20
> Explicity disable the stack protection with
> -fno-stack-protection for builds using GCC on
> AARCH64.
>=20
> The gcc on Ubuntu enables -fstack-protector-strong
> by default starting with Ubuntu 21.10.
>=20
> GenFw fails if stack protection is enabled.
>=20
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 9c310cf23d25..1a49671a2708 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -1915,7 +1915,7 @@ DEFINE GCC48_ARM_ASM_FLAGS           =3D
> $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(GC
>  DEFINE GCC48_AARCH64_ASM_FLAGS       =3D $(ARCHASM_FLAGS)
> $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian
>  DEFINE GCC48_ARM_CC_FLAGS            =3D $(ARCHCC_FLAGS)
> $(PLATFORM_FLAGS) DEF(GCC_ARM_CC_FLAGS) -fstack-protector
> -mword-relocations
>  DEFINE GCC48_ARM_CC_XIPFLAGS         =3D
> DEF(GCC_ARM_CC_XIPFLAGS)
> -DEFINE GCC48_AARCH64_CC_FLAGS        =3D $(ARCHCC_FLAGS)
> $(PLATFORM_FLAGS) -mcmodel=3Dlarge DEF(GCC_AARCH64_CC_FLAGS)
> +DEFINE GCC48_AARCH64_CC_FLAGS        =3D $(ARCHCC_FLAGS)
> $(PLATFORM_FLAGS) -mcmodel=3Dlarge DEF(GCC_AARCH64_CC_FLAGS)
> -fno-stack-protector
>  DEFINE GCC48_AARCH64_CC_XIPFLAGS     =3D
> DEF(GCC_AARCH64_CC_XIPFLAGS)
>  DEFINE GCC48_ARM_DLINK_FLAGS         =3D
> DEF(GCC_ARM_DLINK_FLAGS) -Wl,--oformat=3Delf32-littlearm
>  DEFINE GCC48_ARM_DLINK2_FLAGS        =3D
> DEF(GCC_DLINK2_FLAGS_COMMON)
> -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x220
> --
> 2.36.0