[edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[sivaparvathi C]

 Attached changes to resolve the coverity Issues

 Signed-off-by: sivaparvathic@ami.com
To: sivaparvathic@ami.com

---
 MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c   |  3 +++
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 10 +++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
index 9ea69ee740..2cc61bb942 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
@@ -531,6 +531,9 @@ SCSIBusDriverBindingStart (
     // then create handle and install scsi i/o protocol.

     //

     Status = ScsiScanCreateDevice (This, Controller, &ScsiTargetId, Lun, ScsiBusDev);

+    if (Status == EFI_OUT_OF_RESOURCES) {

+        goto ErrorExit;

+    }

   }



   return EFI_SUCCESS;

diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
index 98e84b4ea8..5f4ead7669 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
@@ -4247,7 +4247,7 @@ BackOff:


   if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || (EFI_ERROR (ReturnStatus))) {

     DEBUG ((DEBUG_ERROR, "ScsiDiskRead10: Check Condition happened!\n"));

-    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

+    DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

     if (Action == ACTION_RETRY_COMMAND_LATER) {

       *NeedRetry = TRUE;

       return EFI_DEVICE_ERROR;

@@ -4371,7 +4371,7 @@ BackOff:


   if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || (EFI_ERROR (ReturnStatus))) {

     DEBUG ((DEBUG_ERROR, "ScsiDiskWrite10: Check Condition happened!\n"));

-    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

+    DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

     if (Action == ACTION_RETRY_COMMAND_LATER) {

       *NeedRetry = TRUE;

       return EFI_DEVICE_ERROR;

@@ -4494,7 +4494,7 @@ BackOff:


   if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || (EFI_ERROR (ReturnStatus))) {

     DEBUG ((DEBUG_ERROR, "ScsiDiskRead16: Check Condition happened!\n"));

-    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

+    DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

     if (Action == ACTION_RETRY_COMMAND_LATER) {

       *NeedRetry = TRUE;

       return EFI_DEVICE_ERROR;

@@ -4618,7 +4618,7 @@ BackOff:


   if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || (EFI_ERROR (ReturnStatus))) {

     DEBUG ((DEBUG_ERROR, "ScsiDiskWrite16: Check Condition happened!\n"));

-    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

+    DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action);

     if (Action == ACTION_RETRY_COMMAND_LATER) {

       *NeedRetry = TRUE;

       return EFI_DEVICE_ERROR;

@@ -4728,7 +4728,7 @@ ScsiDiskNotify (
   if (Request->TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) {

     DEBUG ((DEBUG_ERROR, "ScsiDiskNotify: Check Condition happened!\n"));



-    Status = DetectMediaParsingSenseKeys (

+    DetectMediaParsingSenseKeys (

                ScsiDiskDevice,

                Request->SenseData,

                Request->SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA),

--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[gaoliming]

This change is good to me. Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi
> C via groups.io
> 发送时间: 2022年8月2日 13:00
> 收件人: devel@edk2.groups.io
> 抄送: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S
> <sundaresans@ami.com>; Sivaparvathi Chellaiah <sivaparvathic@ami.com>
> 主题: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags
> multiple issues in edk2-stable202205
> 
>  Attached changes to resolve the coverity Issues
> 
>  Signed-off-by: sivaparvathic@ami.com
> To: sivaparvathic@ami.com
> 
> ---
>  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c   |  3 +++
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 10 +++++-----
>  2 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
> b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
> index 9ea69ee740..2cc61bb942 100644
> --- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
> +++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
> @@ -531,6 +531,9 @@ SCSIBusDriverBindingStart (
>      // then create handle and install scsi i/o protocol.
> 
>      //
> 
>      Status = ScsiScanCreateDevice (This, Controller, &ScsiTargetId, Lun,
> ScsiBusDev);
> 
> +    if (Status == EFI_OUT_OF_RESOURCES) {
> 
> +        goto ErrorExit;
> 
> +    }
> 
>    }
> 
> 
> 
>    return EFI_SUCCESS;
> 
> diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> index 98e84b4ea8..5f4ead7669 100644
> --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> @@ -4247,7 +4247,7 @@ BackOff:
> 
> 
>    if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION)
> || (EFI_ERROR (ReturnStatus))) {
> 
>      DEBUG ((DEBUG_ERROR, "ScsiDiskRead10: Check Condition
> happened!\n"));
> 
> -    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
> +    DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
>      if (Action == ACTION_RETRY_COMMAND_LATER) {
> 
>        *NeedRetry = TRUE;
> 
>        return EFI_DEVICE_ERROR;
> 
> @@ -4371,7 +4371,7 @@ BackOff:
> 
> 
>    if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION)
> || (EFI_ERROR (ReturnStatus))) {
> 
>      DEBUG ((DEBUG_ERROR, "ScsiDiskWrite10: Check Condition
> happened!\n"));
> 
> -    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
> +    DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
>      if (Action == ACTION_RETRY_COMMAND_LATER) {
> 
>        *NeedRetry = TRUE;
> 
>        return EFI_DEVICE_ERROR;
> 
> @@ -4494,7 +4494,7 @@ BackOff:
> 
> 
>    if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION)
> || (EFI_ERROR (ReturnStatus))) {
> 
>      DEBUG ((DEBUG_ERROR, "ScsiDiskRead16: Check Condition
> happened!\n"));
> 
> -    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
> +    DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
>      if (Action == ACTION_RETRY_COMMAND_LATER) {
> 
>        *NeedRetry = TRUE;
> 
>        return EFI_DEVICE_ERROR;
> 
> @@ -4618,7 +4618,7 @@ BackOff:
> 
> 
>    if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION)
> || (EFI_ERROR (ReturnStatus))) {
> 
>      DEBUG ((DEBUG_ERROR, "ScsiDiskWrite16: Check Condition
> happened!\n"));
> 
> -    Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
> +    DetectMediaParsingSenseKeys (ScsiDiskDevice,
> ScsiDiskDevice->SenseData, SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA), &Action);
> 
>      if (Action == ACTION_RETRY_COMMAND_LATER) {
> 
>        *NeedRetry = TRUE;
> 
>        return EFI_DEVICE_ERROR;
> 
> @@ -4728,7 +4728,7 @@ ScsiDiskNotify (
>    if (Request->TargetStatus ==
> EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) {
> 
>      DEBUG ((DEBUG_ERROR, "ScsiDiskNotify: Check Condition
> happened!\n"));
> 
> 
> 
> -    Status = DetectMediaParsingSenseKeys (
> 
> +    DetectMediaParsingSenseKeys (
> 
>                 ScsiDiskDevice,
> 
>                 Request->SenseData,
> 
>                 Request->SenseDataLength / sizeof
> (EFI_SCSI_SENSE_DATA),
> 
> --
> 2.31.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 

Re: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Hi gaoliming,

When these changes will include in the EDK2 source? in next EDK2 release?

Thanks,
Sivaparvathi

[-- Attachment #2: Type: text/html, Size: 149 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Sivaparvathi:

 Can you create edk2 pull request for this change? Then, I can get it from PR. 

 

Thanks

Liming

发件人: sivaparvathic via groups.io <sivaparvathic=ami.com@groups.io> 
发送时间: 2022年9月12日 17:04
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

 

Hi gaoliming,

When these changes will include in the EDK2 source? in next EDK2 release?

Thanks,
Sivaparvathi 


[-- Attachment #2: Type: text/html, Size: 3403 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

Hi gaoliming,

How can i create EDK2 pull request ?
Can you share the steps?

Thanks,
Sivaparvathi C

[-- Attachment #2: Type: text/html, Size: 986 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Please see below wiki pages. 

 

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

 

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年10月6日 15:56
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

 

Hi gaoliming, 

 

How can i create EDK2 pull request ?

Can you share the steps?

 

Thanks,

Sivaparvathi C

 




[-- Attachment #2: Type: text/html, Size: 5931 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]

Sivaparvathi C,

There is also a recently approved RFC to use CodeQL.

https://edk2.groups.io/g/devel/topic/93881031#94669

Michael Kubacki is leading the effort to phase in the checks supported by CodeQL.

We would expect some overlap across different static analysis tools.

I recommend you collaborate with Michael Kubacki on this topic.  The faster we can identify and resolve issues the faster we will be able to phase in a complete set of CodeQL checks.

Coverity scan could be a good cross check after a minimum set of CodeQL checks have been enabled.

Thanks,

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Friday, October 7, 2022 6:51 PM
To: devel@edk2.groups.io; C, sivaparvathi <sivaparvathic@ami.com>
Subject: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

Please see below wiki pages.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 sivaparvathi C via groups.io
发送时间: 2022年10月6日 15:56
收件人: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

Hi gaoliming,

How can i create EDK2 pull request ?
Can you share the steps?

Thanks,
Sivaparvathi C



[-- Attachment #2: Type: text/html, Size: 50198 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

Hi mikuback@linux.microsoft.com , gaoliming@byosoft.com.cn , michael.d.kinney@intel.com

Created Pull Request for edk2_Stable202205 Coverity Changes  for SCSI driver.

https://github.com/tianocore/edk2/pull/3473

Thanks,
Sivaparvathi

[-- Attachment #2: Type: text/html, Size: 1498 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Hi Sivaparvathi ,

Thank you for the contribution.

Can you please send code review using EDK II Dev process?

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

I also see some CI checks are failing.  Please address those before sending updates.

Thanks,

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of sivaparvathi C via groups.io
Sent: Thursday, October 13, 2022 6:15 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

Hi mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>, gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>,michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>

Created Pull Request for edk2_Stable202205 Coverity Changes  for SCSI driver.

https://github.com/tianocore/edk2/pull/3473

Thanks,
Sivaparvathi


[-- Attachment #2: Type: text/html, Size: 42881 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi mikuback@linux.microsoft.com, gaoliming@byosoft.com.cn,michael.d.kinney@intel.com, vasudevans@ami.com, sundaresans@ami.com

Created PULL request for Coverity Issue changes.

SCSI PR: https://github.com/tianocore/edk2/pull/3544
BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3994

All Checks are Passed.

Thanks,
Sivaparvathi C

[-- Attachment #2: Type: text/html, Size: 829 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

Sivaparvathi:

 Thanks for your update. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >

 I will merge this patch if no other comments. 

 

Thanks

Liming

 

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年10月28日 16:02
收件人: Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

 

Hi mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com> , gaoliming@byosoft.com.cn,michael.d.kinney@intel.com, <mailto:gaoliming@byosoft.com.cn,michael.d.kinney@intel.com,>  vasudevans@ami.com, <mailto:vasudevans@ami.com,>  sundaresans@ami.com <mailto:sundaresans@ami.com> 

 

Created PULL request for Coverity Issue changes.

SCSI PR: https://github.com/tianocore/edk2/pull/3544 

BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3994

All Checks are Passed.

Thanks,
Sivaparvathi C




[-- Attachment #2: Type: text/html, Size: 5157 bytes --]