From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.5333.1668650027426713781 for ; Wed, 16 Nov 2022 17:53:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=rJQfiJgs; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id B0EFDCD1F66A for ; Thu, 17 Nov 2022 09:53:44 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1668650024; bh=GTuqXU3iby53S7zLF+vfUAGcSt/0k/dzAaEV9OAahPc=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=rJQfiJgs47yubXr6+qW4F30kvM8hMXFis9qM07j0f51CILabmZS4eBMZzfCMgtL8P IQWAVJaIxEnAHQJgIE1B+qDflwZsjP+yRZ7H83anJZxHDNLA+z7g4BWt2vrhINmn0Q ObLv5j6uD8ERDcgnsfVjZKhdwYhLqUifnvEDy5rw= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id AC05CCD1F677 for ; Thu, 17 Nov 2022 09:53:44 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 7ED4ACD1F64F for ; Thu, 17 Nov 2022 09:53:44 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 04FC3CD1F665 for ; Thu, 17 Nov 2022 09:53:41 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 17 Nov 2022 09:53:35 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kinney, Michael D'" , "'Michael Kubacki'" , Cc: "'Sean Brogan'" , "'Andrew Fish'" , "'Leif Lindholm'" References: <20221115001841.2018-1-mikuback@linux.microsoft.com> <010701d8f89e$6afaeb60$40f0c220$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUEFUQ0ggZWRrMi1zdGFibGUyMDIyMTEgdjIgMC8yXSBVcGRhdGUgUHl0b29sIFBJUCBWZXJzaW9ucw==?= Date: Thu, 17 Nov 2022 09:53:38 +0800 Message-ID: <000001d8fa27$693c2ed0$3bb48c70$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIXGkf/1tCSRRVyYr1n7SxZ4bJfhAI4SoEMAKElKpcB0HbbnAFDRRRwAmx5TUmtg0zpMA== Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike: I find this PR meets with some failure, and re-run it. Now, it passes CI = and merged.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8817=E6=97=A5= 5:46 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kubacki ; > devel@edk2.groups.io; Gao, Liming ; Kinney, > Michael D > =E6=8A=84=E9=80=81: 'Sean Brogan' ; 'Andrew Fi= sh' > ; 'Leif Lindholm' > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH edk2-stab= le202211 v2 0/2] Update > Pytool PIP Versions >=20 > Hi Liming, >=20 > Are you waiting for any additional input or approvals to merge this for > edk2-stable202211? >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: Michael Kubacki > > Sent: Tuesday, November 15, 2022 6:36 AM > > To: devel@edk2.groups.io; Kinney, Michael D > ; Gao, Liming > > Cc: 'Sean Brogan' ; 'Andrew Fish' > ; 'Leif Lindholm' > > Subject: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH edk2-stable202211 = v2 0/2] Update > Pytool PIP Versions > > > > The pull request is rebased and the commits include all Reviewed-by tag= s. > > > > https://github.com/tianocore/edk2/pull/3632 > > > > Thanks, > > Michael > > > > On 11/14/2022 10:45 PM, Michael D Kinney wrote: > > > Reviewed-by: Michael D Kinney > > > > > > Approved for edk2-stable202211 > > > > > > Mike > > > > > >> -----Original Message----- > > >> From: Michael Kubacki > > >> Sent: Monday, November 14, 2022 7:18 PM > > >> To: devel@edk2.groups.io; Gao, Liming > > >> Cc: 'Sean Brogan' ; 'Andrew Fish' > ; 'Leif Lindholm' > > ; > > >> Kinney, Michael D > > >> Subject: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH edk2-stable2022= 11 v2 0/2] > Update Pytool PIP Versions > > >> > > >> I would like to elaborate on some of the information in this cover > > >> letter to better emphasize why this should be included in the > > >> edk2-stable202211 stable tag. > > >> > > >> These releases of edk2-pytool-library and edk2-pytool-extensions mus= t > be > > >> paired together. The edk2-pytool-library release already being used = by > > >> edk2 (0.12.0) requires the edk2-pytool-extensions 0.20.0 release. > > >> > > >> The updates in this series should be considered "required" as oppose= d to > > >> "recommended" to ensure compatibility in the stable tag release. > > >> > > >> The reasoning for updating edk2-pytool-library from 0.12.0 to 0.12.1= is > > >> straightforward, it fixes the bug described in the cover letter. > > >> > > >> The issue with not taking in the 0.20.0 edk2-pytool-extensions updat= e is > > >> that PR Evaluation, which is used in CI to determine what packages t= o > > >> build, will not build the code in some cases causing build failures = to > > >> potentially creep through. > > >> > > >> For example, without this update, a PR with a file only changed outs= ide > > >> a package, such as pip-requirements.txt or a file in .pytool, will n= ot > > >> trigger a full build to test the change as a file is not modified wi= thin > > >> an edk2 package. > > >> > > >> Thanks, > > >> Michael > > >> > > >> On 11/14/2022 10:00 PM, gaoliming via groups.io wrote: > > >>> Michael: > > >>> I have no comments to merge this patch set for the stable tag. > > >>> > > >>> Thanks > > >>> Liming > > >>>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > >>>> =E5=8F=91=E4=BB=B6=E4=BA=BA: mikuback@linux.microsoft.com > > > >>>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8815= =E6=97=A5 8:19 > > >>>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > >>>> =E6=8A=84=E9=80=81: Sean Brogan ; Micha= el Kubacki > > >>>> ; Liming Gao > ; > > >>>> Andrew Fish ; Leif Lindholm > > > >>>> =E4=B8=BB=E9=A2=98: [PATCH edk2-stable202211 v2 0/2] Update Pytool= PIP Versions > > >>>> > > >>>> From: Michael Kubacki > > >>>> > > >>>> 1. Updates edk2-pytool-library to 0.12.1 > > >>>> - Picks up a minor bug fix > > >>>> > > >>>> 2. Updates edk2-pytool-extensions to 0.20.0 > > >>>> - Picks up a major release > > >>>> > > >>>> The changes in each update are in the respective patch commit > > >>>> messages. > > >>>> > > >>>> CI was run against both of these patches in this pull request: > > >>>> https://github.com/tianocore/edk2/pull/3632 > > >>>> > > >>>> These changes are recommended to be included in the > edk2-stable202211 > > >>>> tag for the following reasons: > > >>>> > > >>>> 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix > > >>>> that simply returns file paths from > > >>>> Edk2Path.GetContainingModules() with the original case used > by > > >>>> the operating system. This allow case sensitive callers to ma= tch > > >>>> paths returned by the function correctly. > > >>>> > > >>>> This can impact flows such as PR Eval that use this function = to > > >>>> determine which modules were impacted by a code change. > Without > > >>>> this change PR eval may not return consistent/expected result= s > > >>>> across operating systems. > > >>>> > > >>>> 2. The edk2-pytool-library change requires edk2-pytool-extensions > > >>>> 0.20.0. For this reason, edk2-pytool-extensions setup.py was > > >>>> updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-librar= y > > >>>> requirement. The logic of determining a package in > pytool-library > > >>>> (Edk2Path.GetContainingPackage()) needs a corresponding > change in > > >>>> the edk2-pytool-extensions 0.20.0 release. > > >>>> > > >>>> Without this change, flows such as PR Eval will not have > updated > > >>>> logic for calling the function and return incorrect results. > > >>>> > > >>>> These changes have been tested against edk2 in pytool integration > > >>>> testing, the PR linked above, and against similar code in Mu. > > >>>> > > >>>> V2 changes: > > >>>> > > >>>> 1. Add stable tag to patch subject > > >>>> 2. Explain why changes should be included in stable tag > > >>>> 3. Add Reviewed-by tags to patches from v1 > > >>>> > > >>>> Cc: Sean Brogan > > >>>> Cc: Michael Kubacki > > >>>> Cc: Liming Gao > > >>>> Cc: Andrew Fish > > >>>> Cc: Leif Lindholm > > >>>> Signed-off-by: Michael Kubacki > > >>>> > > >>>> Michael Kubacki (2): > > >>>> pip-requirements.txt: Update to edk2-pytool-library 0.12.1 > > >>>> pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0 > > >>>> > > >>>> pip-requirements.txt | 4 ++-- > > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > > >>>> > > >>>> -- > > >>>> 2.28.0.windows.1 > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > > > > > > > >=20 > > > > > >