Christine:

 I can't directly reply to the original mail because it is too large. This
is a new feature to add python version VfrCompiler. I don't think we have
enough time to review the design and implementation. Although it has no real
impact, its code may have many change in future. So, I suggest to merge it
after this stable tag. 

 

Thanks

Liming

 

Below is your request. 

 

Hi Liming and Cran, 

 

Could you help on quick reviewing this new VfrCompiler python tool, it has
the same functions with origin C version VfrCompiler, meanwhile it supports
more new features such as generated Vfr files config info into Yaml format. 

 

This feature is urgent for us to use, and we really hope it can be merged
into this stable tag. This patch is linked to the edk2-basetools PR:
https://github.com/tianocore/edk2-basetools/pull/109. We list all the known
issues which will be enhanced in the ReadMe file. And will enhance them one
by one after the patch merged.

For the code quality, in this patch, the new tool is not enabled in build
process, it just saves in the basetools python folder, which will not
influence the current edk2 behaviors. We will enable it with a new patch
when everything is ready.

Many thanks~

Hi Vincent, please help add more information if necessary~ Thanks a lot~

Thanks,

Christine

 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110985): https://edk2.groups.io/g/devel/message/110985
Mute This Topic: https://groups.io/mt/102486097/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-