From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3A516D811DA for ; Thu, 9 Nov 2023 14:19:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qPKN7xGCNKpQFg86VqIE+g46I0a/dxk2JdzbommlwFU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1699539560; v=1; b=mL9NfbJbkleLiKODEupj5Oky3QxnKaDtggfLdJZtqaL2whfL4yNAlxZs3iShCd76NjJCaRWc jBb0o7SCu6osSERtuOkUfnLDkXhBFcZYB/gdaH7ovRl4tYcCRji5AH2aTMQpN+1e5+y/Dk5694r B9f43nzbsDD3Co2gTRfsjwz0= X-Received: by 127.0.0.2 with SMTP id 8qlsYY7687511xGpZa9hZmxY; Thu, 09 Nov 2023 06:19:20 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.122183.1699539559286520011 for ; Thu, 09 Nov 2023 06:19:19 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 14F23A32E11E for ; Thu, 9 Nov 2023 22:19:16 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id DC740A32E0DD for ; Thu, 9 Nov 2023 22:19:15 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 4AB15A32E0FF for ; Thu, 9 Nov 2023 22:19:11 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([124.133.49.51]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 09 Nov 2023 22:19:02 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 124.133.49.51 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Rebecca Cran'" , "'Gao, Liming'" , "'Zimmer, Vincent'" , "'Chen, Christine'" , "'Kinney, Michael D'" , "'Leif Lindholm'" , "'Andrew Fish'" Cc: "'Feng, Bob C'" , "'Yang, Yuting2'" , , "'Hartung, Stephen'" Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation Date: Thu, 9 Nov 2023 22:19:04 +0800 Message-ID: <000001da1317$b227a890$1676f9b0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AdoTFrHyrunoe9acRQSuUxcGn6URWQ== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xyFxc4DyS33nsenjJeDSyFtWx7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0001_01DA135A.C04B5DC0" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mL9NfbJb; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none ------=_NextPart_000_0001_01DA135A.C04B5DC0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Christine: I can't directly reply to the original mail because it is too large. This is a new feature to add python version VfrCompiler. I don't think we have enough time to review the design and implementation. Although it has no rea= l impact, its code may have many change in future. So, I suggest to merge it after this stable tag.=20 =20 Thanks Liming =20 Below is your request.=20 =20 Hi Liming and Cran,=20 =20 Could you help on quick reviewing this new VfrCompiler python tool, it has the same functions with origin C version VfrCompiler, meanwhile it supports more new features such as generated Vfr files config info into Yaml format.= =20 =20 This feature is urgent for us to use, and we really hope it can be merged into this stable tag. This patch is linked to the edk2-basetools PR: https://github.com/tianocore/edk2-basetools/pull/109. We list all the known issues which will be enhanced in the ReadMe file. And will enhance them one by one after the patch merged. For the code quality, in this patch, the new tool is not enabled in build process, it just saves in the basetools python folder, which will not influence the current edk2 behaviors. We will enable it with a new patch when everything is ready. Many thanks~ Hi Vincent, please help add more information if necessary~ Thanks a lot~ Thanks, Christine =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110985): https://edk2.groups.io/g/devel/message/110985 Mute This Topic: https://groups.io/mt/102486097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0001_01DA135A.C04B5DC0 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

= Christine:

=  I can&= #8217;t directly reply to the original mail becau= se it is too large. This is a new feature to add python version VfrCompiler= . I don’= ;t think we have enough time to review the design= and implementation. Although it has no real impact, its code may have many= change in future. So, I suggest to merge it after this stable tag.

 =

Thanks

Liming<= /p>

 

<= p class=3DMsoPlainText>Below is your request.

 

Hi Liming and Cran,

 

Could you help on = quick reviewing this new VfrCompiler python tool, it has the same functions= with origin C version VfrCompiler, meanwhile it supports more new features= such as generated Vfr files config info into Yaml format.

 

This feature is urgent for us = to use, and we really hope it can be merged into this stable tag. This patc= h is linked to the edk2-basetools PR: https://github.com/tianocore/edk2-basetools/pul= l/109. We list all the known issues which will be enhanced in the ReadM= e file. And will enhance them one by one after the patch merged.=

For the code quality, in this = patch, the new tool is not enabled in build process, it just saves in the b= asetools python folder, which will not influence the current edk2 behaviors= . We will enable it with a new patch when everything is ready.

=

Many thanks~

Hi Vincent, please help add more inform= ation if necessary~ Thanks a lot~

Thanks,

Christine

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#110985) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_0001_01DA135A.C04B5DC0--