From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 77B0774003A for ; Fri, 24 May 2024 06:47:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wyW37L8O2AHJjWnfQx1xBZ463D8lGyJ+Rs+6SgV+KNA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1716533254; v=1; b=Os9h3XeeZoYWhE9Vw7GXQEGwujnWPx+yZb3EqEoE3AN71z+j+cQFSC2If2y5RMHxYHJdLxjC VdjJ2YizpPd48ATALZg6pYmVvJ7chRaMSKV2PS5BgIEJfTEy/xEpCaFajfyNV1XhzxIoYL24pbq QHs1GVYwvTEb4vl+ehmmNYd40ST6nS9JRV27ZOFRjVoOtYbO8bRMT+Lvx8nv00XKtBQVDGcaUFc 55dtoC9NDmyKxY4Lgw8Fqq7ohbqhBhALl/88+7iRQN2F5BYwklVA3+L+4qh+3fom9CQ5Q4UbQKO s2joOtnOs9hLg091XVzPBZhPSAm9IpHQvZ2dfW7VxvOYw== X-Received: by 127.0.0.2 with SMTP id LKL9YY7687511xmpgaAM8dMy; Thu, 23 May 2024 23:47:34 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.9872.1716533252931640403 for ; Thu, 23 May 2024 23:47:34 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 01AF1A32E0A9 for ; Fri, 24 May 2024 14:47:30 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id D99D1A32E0A6 for ; Fri, 24 May 2024 14:47:29 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 16359A32E16F for ; Fri, 24 May 2024 14:47:25 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Fri, 24 May 2024 14:47:21 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Michael D Kinney'" , "'Zhiguang Liu'" References: <20240524054512.523329-1-douglas.flick@microsoft.com> <20240524054512.523329-17-douglas.flick@microsoft.com> In-Reply-To: <20240524054512.523329-17-douglas.flick@microsoft.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYzIDE2LzIwXSBNZGVQa2cvQmFzZVJuZ0xpYiBBQVJDSDY0OiBSZW1vdmUgb3ZlcnplYWxvdXMgQVNTRVJUKCk=?= Date: Fri, 24 May 2024 14:47:24 +0800 Message-ID: <000001daada6$3c583100$b5089300$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKDb+eujiMXEG5By6JZvHytBKYtfAL0WW8EsDzJwbA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 23 May 2024 23:47:34 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yDvNMPOGkq3C7TjYStfLlCOCx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Os9h3Xee; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Doug Flick via > groups.io > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA5=D4=C224=C8=D5 13:45 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > =D6=F7=CC=E2: [edk2-devel] [PATCH v3 16/20] MdePkg/BaseRngLib AARCH64: Re= move > overzealous ASSERT() >=20 > From: Ard Biesheuvel >=20 > BaseRngLib on AARCH64 will discover whether or not RNDR instructions are > supported, by inspecting the ISAR0 identification register, and setting > a global boolean accordingly. This boolean is used in subsequent > execution to decide whether or not to issue the instruction. >=20 > The same discovery code also ASSERT()s that RNDR instructions are > implemented, which is unnecessary, and breaks execution on systems that > incorporate the library but don't implement the instruction (or fail to > expose it to the exception level that the firmware executes at). >=20 > So drop the ASSERT(). >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu >=20 > Committed-by: Ard Biesheuvel > Signed-off-by: Doug Flick [MSFT] > --- > MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/MdePkg/Library/BaseRngLib/AArch64/Rndr.c > b/MdePkg/Library/BaseRngLib/AArch64/Rndr.c > index d39db62153..3a556a2e3f 100644 > --- a/MdePkg/Library/BaseRngLib/AArch64/Rndr.c > +++ b/MdePkg/Library/BaseRngLib/AArch64/Rndr.c > @@ -50,7 +50,6 @@ BaseRngLibConstructor ( > // MSR. A non-zero value indicates that the processor supports the RND= R > instruction. >=20 > // >=20 > Isar0 =3D ArmReadIdIsar0 (); >=20 > - ASSERT ((Isar0 & RNDR_MASK) !=3D 0); >=20 >=20 >=20 > mRndrSupported =3D ((Isar0 & RNDR_MASK) !=3D 0); >=20 >=20 >=20 > -- > 2.34.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#119243): https://edk2.groups.io/g/devel/message/11924= 3 > Mute This Topic: https://groups.io/mt/106276868/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119247): https://edk2.groups.io/g/devel/message/119247 Mute This Topic: https://groups.io/mt/106277273/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-