From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <ray.ni@intel.com>,
"'Wenyi Xie'" <xiewenyi2@huawei.com>,
"'Justen, Jordan L'" <jordan.l.justen@intel.com>,
<afish@apple.com>
Cc: <lersek@redhat.com>, <songdongkuang@huawei.com>
Subject: 回复: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
Date: Mon, 14 Sep 2020 10:57:49 +0800 [thread overview]
Message-ID: <000201d68a42$d56048a0$8020d9e0$@byosoft.com.cn> (raw)
In-Reply-To: <BY5PR11MB40073CEE3DBFC1E4D96F78088C240@BY5PR11MB4007.namprd11.prod.outlook.com>
Yes. This change is correct. Reviewed-by: Liming Gao <gaoliming@byosoft.com.
cn>
> -----邮件原件-----
> 发件人: bounce+27952+65182+4905953+8761045@groups.io
> <bounce+27952+65182+4905953+8761045@groups.io> 代表 Ni, Ray
> 发送时间: 2020年9月11日 10:19
> 收件人: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Justen,
> Jordan L <jordan.l.justen@intel.com>; afish@apple.com; gaoliming
> <gaoliming@byosoft.com.cn>
> 抄送: lersek@redhat.com; songdongkuang@huawei.com
> 主题: Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change
> DEC_VERSION to DEC_SPECIFICATION
>
> + Liming who is expert on the EDK II Build spec.
>
> > -----Original Message-----
> > From: Wenyi Xie <xiewenyi2@huawei.com>
> > Sent: Friday, September 11, 2020 9:49 AM
> > To: devel@edk2.groups.io; Justen, Jordan L <jordan.l.justen@intel.com>;
> afish@apple.com; Ni, Ray <ray.ni@intel.com>
> > Cc: lersek@redhat.com; songdongkuang@huawei.com;
> xiewenyi2@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to
> DEC_SPECIFICATION
> >
> > edk2 DEC specification document only knows about DEC_SPECIFICATION,
> > so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> > correct.
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> > EmulatorPkg/EmulatorPkg.dec | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> > index 90a8d2a8681a..064f963c72c6 100644
> > --- a/EmulatorPkg/EmulatorPkg.dec
> > +++ b/EmulatorPkg/EmulatorPkg.dec
> > @@ -11,7 +11,7 @@
> > ##
> >
> > [Defines]
> > - DEC_VERSION = 0x00010005
> > + DEC_SPECIFICATION = 0x00010005
> > PACKAGE_NAME = EmulatorPkg
> > PACKAGE_GUID =
> 36E48BD7-7D92-5A47-A2CD-513F072E3300
> > PACKAGE_VERSION = 0.1
> > --
> > 2.20.1.windows.1
>
>
>
next prev parent reply other threads:[~2020-09-14 2:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 1:49 [PATCH EDK2 v1 0/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION wenyi,xie
2020-09-11 1:49 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2020-09-11 2:18 ` Ni, Ray
2020-09-14 2:57 ` gaoliming [this message]
2020-09-11 7:03 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201d68a42$d56048a0$8020d9e0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox