From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.53235.1600052281410894646
 for <devel@edk2.groups.io>;
 Sun, 13 Sep 2020 19:58:02 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <afish@apple.com>; Mon, 14 Sep 2020 10:57:50 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<ray.ni@intel.com>,
	"'Wenyi Xie'" <xiewenyi2@huawei.com>,
	"'Justen, Jordan L'" <jordan.l.justen@intel.com>,
	<afish@apple.com>
Cc: <lersek@redhat.com>,
	<songdongkuang@huawei.com>
References: <1599788966-78918-1-git-send-email-xiewenyi2@huawei.com> <1599788966-78918-2-git-send-email-xiewenyi2@huawei.com> <BY5PR11MB40073CEE3DBFC1E4D96F78088C240@BY5PR11MB4007.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB40073CEE3DBFC1E4D96F78088C240@BY5PR11MB4007.namprd11.prod.outlook.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIEVESzIgdjEgMS8xXSBFbXVsYXRvclBrZzpDaGFuZ2UgREVDX1ZFUlNJT04gdG8gREVDX1NQRUNJRklDQVRJT04=?=
Date: Mon, 14 Sep 2020 10:57:49 +0800
Message-ID: <000201d68a42$d56048a0$8020d9e0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQJ4qsrBnuTG6Gu+m4o1BRqO5pIhsAFojKKYAebaGZ2oCJsusA==
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Yes. This change is correct. Reviewed-by: Liming Gao <gaoliming@byosoft.com=
.
cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+65182+4905953+8761045@groups.io
> <bounce+27952+65182+4905953+8761045@groups.io> =B4=FA=B1=ED Ni, Ray
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA9=D4=C211=C8=D5 10:19
> =CA=D5=BC=FE=C8=CB: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.=
io; Justen,
> Jordan L <jordan.l.justen@intel.com>; afish@apple.com; gaoliming
> <gaoliming@byosoft.com.cn>
> =B3=AD=CB=CD: lersek@redhat.com; songdongkuang@huawei.com
> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change
> DEC_VERSION to DEC_SPECIFICATION
>=20
> + Liming who is expert on the EDK II Build spec.
>=20
> > -----Original Message-----
> > From: Wenyi Xie <xiewenyi2@huawei.com>
> > Sent: Friday, September 11, 2020 9:49 AM
> > To: devel@edk2.groups.io; Justen, Jordan L <jordan.l.justen@intel.com>=
;
> afish@apple.com; Ni, Ray <ray.ni@intel.com>
> > Cc: lersek@redhat.com; songdongkuang@huawei.com;
> xiewenyi2@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to
> DEC_SPECIFICATION
> >
> > edk2 DEC specification document only knows about DEC_SPECIFICATION,
> > so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> > correct.
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> >  EmulatorPkg/EmulatorPkg.dec | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> > index 90a8d2a8681a..064f963c72c6 100644
> > --- a/EmulatorPkg/EmulatorPkg.dec
> > +++ b/EmulatorPkg/EmulatorPkg.dec
> > @@ -11,7 +11,7 @@
> >  ##
> >
> >  [Defines]
> > -  DEC_VERSION                    =3D 0x00010005
> > +  DEC_SPECIFICATION              =3D 0x00010005
> >    PACKAGE_NAME                   =3D EmulatorPkg
> >    PACKAGE_GUID                   =3D
> 36E48BD7-7D92-5A47-A2CD-513F072E3300
> >    PACKAGE_VERSION                =3D 0.1
> > --
> > 2.20.1.windows.1
>=20
>=20
>=20