From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.28027.1612144465045678913
 for <devel@edk2.groups.io>;
 Sun, 31 Jan 2021 17:54:25 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <abner.chang@hpe.com>; Mon, 01 Feb 2021 09:54:15 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<abner.chang@hpe.com>
Cc: "'Leif Lindholm'" <leif@nuviainc.com>,
	"'Nickle Wang'" <nickle.wang@hpe.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>
References: <20210129041954.20623-1-abner.chang@hpe.com>
In-Reply-To: <20210129041954.20623-1-abner.chang@hpe.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBSZWRmaXNoUGtnL0pzb25MaWI6IEZpeCB0aGUgbWlzdGFrZSBvZiByZW1vdmluZyBjb2RlIGJ5IGEgYWNjaWRlbnQ=?=
Date: Mon, 1 Feb 2021 09:54:20 +0800
Message-ID: <000201d6f83d$286cc9c0$79465d40$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQJDW9fj2HZeve4MCqEBmcCvGfKCsKlpwnkw
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Besides, does CI enable in RedfishPkg?

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+70885+4905953+8761045@groups.io
> <bounce+27952+70885+4905953+8761045@groups.io> =B4=FA=B1=ED Abner Chang
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA1=D4=C229=C8=D5 12:20
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Leif Lindholm <leif@nuviainc.com>; Nickle Wang
> <nickle.wang@hpe.com>; Michael D Kinney <michael.d.kinney@intel.com>
> =D6=F7=CC=E2: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake o=
f removing
> code by a accident
>=20
> json_string_value() in JsonValueGetAsciiString () is removed by a accide=
nt
> when clean up the code.
>=20
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>=20
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> b/RedfishPkg/Library/JsonLib/JsonLib.c
> index 34ff381aee..d729e3ec27 100644
> --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> @@ -430,10 +430,10 @@ JsonValueGetAsciiString (
>    IN    EDKII_JSON_VALUE    Json
>    )
>  {
> -  CHAR8          *AsciiStr;
> +  CONST CHAR8    *AsciiStr;
>    UINTN          Index;
>=20
> -  AsciiStr =3D (CHAR8 *)  ((json_t *) Json);
> +  AsciiStr =3D json_string_value ((json_t *) Json);
>    if (AsciiStr =3D=3D NULL) {
>      return NULL;
>    }
> --
> 2.17.1
>=20
>=20
>=20
>=20
>=20