From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.2167.1618794392960631541
 for <devel@edk2.groups.io>;
 Sun, 18 Apr 2021 18:06:35 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Mon, 19 Apr 2021 09:06:19 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<steven.shi@intel.com>
Cc: <bob.c.feng@intel.com>
References: <20210417122133.1879-1-steven.shi@intel.com>
In-Reply-To: <20210417122133.1879-1-steven.shi@intel.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzOiBBZGQgZG91YmxlIHF1b3RlIGFyb3VuZCBDTEFOR19CSU4gcGF0aCBzdHJpbmc=?=
Date: Mon, 19 Apr 2021 09:06:30 +0800
Message-ID: <000201d734b8$3b7d6760$b2783620$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQEwOPpLLEmgBU3AD2GdHPXG6e+YLawI/mpQ
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =
=B4=FA=B1=ED Steven Shi
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA4=D4=C217=C8=D5 20:22
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: bob.c.feng@intel.com; gaoliming@byosoft.com.cn; Steven =
Shi
> <steven.shi@intel.com>
> =D6=F7=CC=E2: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote =
around
> CLANG_BIN path string
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3341
>=20
> Current CLANG_BIN env variable is set without double quote
> around the LLVM default installation path string in windows,
> which causes some CI build service cannot find the LLVM path
> in windows.
> This patch enhance it to add double quote around it.
>=20
> Signed-off-by: Steven Shi <steven.shi@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  edksetup.bat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/edksetup.bat b/edksetup.bat
> index 7b9377aaa5c2..7ad137bb3e9b 100755
> --- a/edksetup.bat
> +++ b/edksetup.bat
> @@ -120,7 +120,7 @@ if not defined CLANG_BIN (
>      @echo.
>=20
>      @echo !!! WARNING !!! CLANG_BIN environment variable is not set
>=20
>      @if exist "C:\Program Files\LLVM\bin\clang.exe" (
>=20
> -        @set CLANG_BIN=3DC:\Program Files\LLVM\bin\
>=20
> +        @set "CLANG_BIN=3DC:\Program Files\LLVM\bin\"
>=20
>          @echo   Found LLVM, setting CLANG_BIN environment variable
> to C:\Program Files\LLVM\bin\
>=20
>      )
>=20
>  )
>=20
> --
> 2.28.0.windows.1
>=20
>=20
>=20
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#74227): =
https://edk2.groups.io/g/devel/message/74227
> Mute This Topic: https://groups.io/mt/82163598/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=3D-=3D-=3D-=3D-=3D-=3D
>=20