From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web12.5527.1621386819391520502
 for <devel@edk2.groups.io>;
 Tue, 18 May 2021 18:13:40 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <devel@edk2.groups.io>; Wed, 19 May 2021 09:13:35 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<sergei@posteo.net>
Cc: "'Ray Ni'" <ray.ni@intel.com>,
	"'Zhichao Gao'" <zhichao.gao@intel.com>
References: <20210518160942.17634-1-sergei@posteo.net> <20210518160942.17634-2-sergei@posteo.net>
In-Reply-To: <20210518160942.17634-2-sergei@posteo.net>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDEvM10gU2hlbGxQa2cvSHR0cER5bmFtaWNDb21tYW5kOiBGaXggcG9zc2libGUgdW5pbml0aWFsaXplZCB1c2U=?=
Date: Wed, 19 May 2021 09:13:26 +0800
Message-ID: <000201d74c4c$328d5e70$97a81b50$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQDRzbzfNcXTsVtNJ7TQhSptEQgpBwFEhfKgrOrYNpA=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

This fix is clear.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=
=B1=ED Sergei
> Dmitrouk
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C219=C8=D5 0:10
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.=
com>
> =D6=F7=CC=E2: [edk2-devel] [PATCH v2 1/3] ShellPkg/HttpDynamicCommand: F=
ix
> possible uninitialized use
>=20
> `Status` can be used uninitialized:
>=20
>     /* Evaluates to FALSE */
>     if (ShellGetExecutionBreakFlag ()) {
>         Status =3D EFI_ABORTED;
>         break;
>     }
>=20
>     /* Evaluates to FALSE */
>     if (!Context->ContentDownloaded && !Context->ResponseToken.Event) {
>         Status =3D ...;
>         ASSERT_EFI_ERROR (Status);
>     } else {
>         ResponseMessage.Data.Response =3D NULL;
>     }
>=20
>     /* UNINITIALIZED USE */
>     if (EFI_ERROR (Status)) {
>         break;
>     }
>=20
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Sergei Dmitrouk <sergei@posteo.net>
> ---
>  ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
> b/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
> index 3735a4a7e645..7b9b2d238015 100644
> --- a/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
> +++ b/ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
> @@ -1524,6 +1524,7 @@ GetResponse (
>    Context->ResponseToken.Message =3D &ResponseMessage;
>    Context->ContentLength =3D 0;
>    Context->Status =3D REQ_OK;
> +  Status =3D EFI_SUCCESS;
>    MsgParser =3D NULL;
>    ResponseData.StatusCode =3D HTTP_STATUS_UNSUPPORTED_STATUS;
>    ResponseMessage.Data.Response =3D &ResponseData;
> --
> 2.17.6
>=20
>=20
>=20
>=20
>=20