From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Tinh Nguyen'" <tinhnguyen@os.amperecomputing.com>,
<devel@edk2.groups.io>
Cc: <patches@amperecomputing.com>, <michael.d.kinney@intel.com>,
<zhiguang.liu@intel.com>, <abner.chang@amd.com>
Subject: 回复: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions
Date: Fri, 28 Apr 2023 13:41:02 +0800 [thread overview]
Message-ID: <000201d97994$04ee7f40$0ecb7dc0$@byosoft.com.cn> (raw)
In-Reply-To: <20230428035940.1765700-3-tinhnguyen@os.amperecomputing.com>
Tinh:
Please use the specific word in the subject. For example, add Capabilities
definitions.
> -----邮件原件-----
> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 发送时间: 2023年4月28日 12:00
> 收件人: devel@edk2.groups.io
> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com;
> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 主题: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more
> definitions
>
> This adds more definitions for the IPMI Get System Interface
> Capabilities command.
>
> Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> ---
> MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31
> ++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> index a5835ba08c00..933303b0fa2c 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> @@ -13,6 +13,7 @@
>
> Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
> Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.<BR>
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> @@ -1046,6 +1047,36 @@ typedef struct {
> // Constants and Structure definitions for "Get System Interface
> Capabilities" command to follow here
> //
>
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF 0x0
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS 0x1
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC 0x2
> +
KCS and SMIC type are added. Can you also add KCS and SMIC Capabilities
definitions?
Thanks
Liming
> +typedef union {
> + struct {
> + UINT8 InterfaceType : 4;
> + UINT8 Reserved : 4;
> + } Bits;
> + UINT8 Uint8;
> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
> +
> +typedef union {
> + struct {
> + UINT8 Version : 3;
> + UINT8 PecSupport : 1;
> + UINT8 Reserved : 2;
> + UINT8 TransactionSupport : 2;
> + } Bits;
> + UINT8 Uint8;
> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
> +
> +typedef struct {
> + UINT8 CompletionCode;
> + UINT8 Reserved;
> + IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES InterfaceCap;
> + UINT8 InputMsgSize;
> + UINT8 OutputMsgSize;
> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
> +
> //
> // Definitions for Get System Interface Capabilities command SSIF
> transaction support
> //
> --
> 2.40.0
next prev parent reply other threads:[~2023-04-28 5:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 3:59 [PATCH 0/2] Add IPMI SSIF definitions Tinh Nguyen
2023-04-28 3:59 ` [PATCH 1/2] MdePkg/IndustryStandard: Adds definitions for IPMI SSIF Tinh Nguyen
2023-04-28 5:17 ` 回复: " gaoliming
2023-04-28 9:01 ` Tinh Nguyen
2023-04-29 3:22 ` Chang, Abner
2023-05-02 8:09 ` Tinh Nguyen
2023-05-02 8:18 ` Chang, Abner
2023-04-28 3:59 ` [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions Tinh Nguyen
2023-04-28 5:41 ` gaoliming [this message]
2023-04-29 3:32 ` Chang, Abner
2023-04-29 3:35 ` [PATCH 0/2] Add IPMI SSIF definitions Chang, Abner
2023-05-02 8:08 ` Tinh Nguyen
2023-05-02 8:21 ` Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201d97994$04ee7f40$0ecb7dc0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox