From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.12766.1682660493475919520 for ; Thu, 27 Apr 2023 22:41:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=pHiHn9Nh; spf=pass (domain: byosoft.com.cn, ip: 114.80.218.36, mailfrom: gaoliming@byosoft.com.cn) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 95A96A32E143 for ; Fri, 28 Apr 2023 13:41:26 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1682660486; bh=c3+zUhq8nn+K3AMduC8QNPK5/RoLrqer8jxBwFJlZMs=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=pHiHn9NhfdKHa2qIKSkKOd2eDiyIRTI9iz/wTGZCnrPqaXyIXy2uXJ/zwesK8I1eR 9zjo+aLPHi9gsGTnqzvD4endg0Y8K9LV9c1pCprD2CpT3BTbJ1AN3REuxTuvZ3zdx6 2bJAKfkrt1WuG7F4WzKipnQHo/kAoU7NYTU2F3AA= Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 70A55A32E13B for ; Fri, 28 Apr 2023 13:41:26 +0800 (CST) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 0D7E6A32E13A for ; Fri, 28 Apr 2023 13:41:26 +0800 (CST) Authentication-Results: zrleap.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id E5668A32E0DD for ; Fri, 28 Apr 2023 13:41:22 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 28 Apr 2023 13:40:58 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Tinh Nguyen'" , Cc: , , , References: <20230428035940.1765700-1-tinhnguyen@os.amperecomputing.com> <20230428035940.1765700-3-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230428035940.1765700-3-tinhnguyen@os.amperecomputing.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggMi8yXSBNZGVQa2cvSW5kdXN0cnlTdGFuZGFyZC9JcG1pTmV0Rm5BcHAuaDogQWRkIG1vcmUgZGVmaW5pdGlvbnM=?= Date: Fri, 28 Apr 2023 13:41:02 +0800 Message-ID: <000201d97994$04ee7f40$0ecb7dc0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIGqEaGrVJUancjNnmTUp/GZig9XAFZnoIvrtsFvEA= Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Tinh: Please use the specific word in the subject. For example, add = Capabilities definitions. > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Tinh Nguyen > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA4=D4=C228=C8=D5 12:00 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com; > Tinh Nguyen > =D6=F7=CC=E2: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add = more > definitions >=20 > This adds more definitions for the IPMI Get System Interface > Capabilities command. >=20 > Signed-off-by: Tinh Nguyen > --- > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31 > ++++++++++++++++++++ > 1 file changed, 31 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > index a5835ba08c00..933303b0fa2c 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > @@ -13,6 +13,7 @@ >=20 > Copyright (c) 1999 - 2018, Intel Corporation. All rights = reserved.
> Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > @@ -1046,6 +1047,36 @@ typedef struct { > // Constants and Structure definitions for "Get System Interface > Capabilities" command to follow here > // >=20 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF 0x0 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS 0x1 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC 0x2 > + KCS and SMIC type are added. Can you also add KCS and SMIC Capabilities definitions?=20 Thanks Liming > +typedef union { > + struct { > + UINT8 InterfaceType : 4; > + UINT8 Reserved : 4; > + } Bits; > + UINT8 Uint8; > +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST; > + > +typedef union { > + struct { > + UINT8 Version : 3; > + UINT8 PecSupport : 1; > + UINT8 Reserved : 2; > + UINT8 TransactionSupport : 2; > + } Bits; > + UINT8 Uint8; > +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES; > + > +typedef struct { > + UINT8 CompletionCode; > + UINT8 Reserved; > + IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES InterfaceCap; > + UINT8 InputMsgSize; > + UINT8 OutputMsgSize; > +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE; > + > // > // Definitions for Get System Interface Capabilities command SSIF > transaction support > // > -- > 2.40.0