* Re: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
2020-10-13 2:43 [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue fengyunhua
@ 2020-10-13 2:47 ` Chiu, Chasel
2020-10-14 2:38 ` Nate DeSimone
2020-10-20 1:14 ` Chiu, Chasel
2 siblings, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2020-10-13 2:47 UTC (permalink / raw)
To: fengyunhua, devel@edk2.groups.io; +Cc: Zeng, Star, Desimone, Nathaniel L
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: fengyunhua <fengyunhua@byosoft.com.cn>
> Sent: Tuesday, October 13, 2020 10:44 AM
> To: devel@edk2.groups.io
> Cc: Zeng, Star <star.zeng@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
>
> Error message:
> raise Exception ("'%s' is not a valid directory!" % FvDir)
> NameError: name 'FvDir' is not defined
>
> FvDir should be fvDir.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
> IntelFsp2Pkg/Tools/PatchFv.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py
> index edb30c816b..0c8d908063 100644
> --- a/IntelFsp2Pkg/Tools/PatchFv.py
> +++ b/IntelFsp2Pkg/Tools/PatchFv.py
> @@ -163,7 +163,7 @@ class Symbols:
> # If the fvDir is not a directory, then raise an exception
> #
> if not os.path.isdir(fvDir):
> - raise Exception ("'%s' is not a valid directory!" % FvDir)
> + raise Exception ("'%s' is not a valid directory!" % fvDir)
>
> #
> # If the Guid.xref is not existing in fvDir, then raise an exception
> --
> 2.27.0.windows.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
2020-10-13 2:43 [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue fengyunhua
2020-10-13 2:47 ` Chiu, Chasel
@ 2020-10-14 2:38 ` Nate DeSimone
2020-10-20 1:14 ` Chiu, Chasel
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-10-14 2:38 UTC (permalink / raw)
To: fengyunhua, devel@edk2.groups.io; +Cc: Zeng, Star, Chiu, Chasel
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
On 10/12/20, 7:44 PM, "fengyunhua" <fengyunhua@byosoft.com.cn> wrote:
Error message:
raise Exception ("'%s' is not a valid directory!" % FvDir)
NameError: name 'FvDir' is not defined
FvDir should be fvDir.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
IntelFsp2Pkg/Tools/PatchFv.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py
index edb30c816b..0c8d908063 100644
--- a/IntelFsp2Pkg/Tools/PatchFv.py
+++ b/IntelFsp2Pkg/Tools/PatchFv.py
@@ -163,7 +163,7 @@ class Symbols:
# If the fvDir is not a directory, then raise an exception
#
if not os.path.isdir(fvDir):
- raise Exception ("'%s' is not a valid directory!" % FvDir)
+ raise Exception ("'%s' is not a valid directory!" % fvDir)
#
# If the Guid.xref is not existing in fvDir, then raise an exception
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
2020-10-13 2:43 [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue fengyunhua
2020-10-13 2:47 ` Chiu, Chasel
2020-10-14 2:38 ` Nate DeSimone
@ 2020-10-20 1:14 ` Chiu, Chasel
2 siblings, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2020-10-20 1:14 UTC (permalink / raw)
To: fengyunhua, devel@edk2.groups.io; +Cc: Zeng, Star, Desimone, Nathaniel L
Thanks Yunhua, change pushed: 29d14d3a30fdfbe017d39b759423832054280f10
> -----Original Message-----
> From: fengyunhua <fengyunhua@byosoft.com.cn>
> Sent: Tuesday, October 13, 2020 10:44 AM
> To: devel@edk2.groups.io
> Cc: Zeng, Star <star.zeng@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
>
> Error message:
> raise Exception ("'%s' is not a valid directory!" % FvDir)
> NameError: name 'FvDir' is not defined
>
> FvDir should be fvDir.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
> IntelFsp2Pkg/Tools/PatchFv.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py
> index edb30c816b..0c8d908063 100644
> --- a/IntelFsp2Pkg/Tools/PatchFv.py
> +++ b/IntelFsp2Pkg/Tools/PatchFv.py
> @@ -163,7 +163,7 @@ class Symbols:
> # If the fvDir is not a directory, then raise an exception
> #
> if not os.path.isdir(fvDir):
> - raise Exception ("'%s' is not a valid directory!" % FvDir)
> + raise Exception ("'%s' is not a valid directory!" % fvDir)
>
> #
> # If the Guid.xref is not existing in fvDir, then raise an exception
> --
> 2.27.0.windows.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread