From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.2190.1626917312001768430 for ; Wed, 21 Jul 2021 18:28:32 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 22 Jul 2021 09:28:28 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Kinney, Michael D'" References: <20210721132328.1415485-1-chengchieh@google.com> <20210721132328.1415485-6-chengchieh@google.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDUvNl0gVWVmaVBheWxvYWRQa2c6IEFkZCBESVNBQkxFX01NWF9TU0UgdG8gYXZvaWQgZ2VuZXJhdGluZyBmbG9hdGluZyBwb2ludHMgb3BlcmF0aW9u?= Date: Thu, 22 Jul 2021 09:28:31 +0800 Message-ID: <000301d77e98$e1c0d9c0$a5428d40$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI+d2iBu/gDct1ldzWMcca8HhaDTgFuoWO6Ad4b3ZcBaYRmP6paj+1g Content-Type: multipart/alternative; boundary="----=_NextPart_000_0004_01D77EDB.EFE55240" Content-Language: zh-cn ------=_NextPart_000_0004_01D77EDB.EFE55240 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Tools_def.txt doesn=E2=80=99t support build flag DISABLE_GCC_MMX_SSE. If th= is flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse = option will be the default GCC options. That means all platforms will apply= them.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Cheng-Chieh Huang via groups.io =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=8822=E6=97=A5 1= :43 =E6=94=B6=E4=BB=B6=E4=BA=BA: Kinney, Michael D =E6=8A=84=E9=80=81: devel@edk2.groups.io =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DI= SABLE_MMX_SSE to avoid generating floating points operation =20 Yes, we can. I will drop this patch for this uefipayload batch and send a= nother one for support DISABLE_GCC_MMX_SSE in tools_de.txt. =20 -- Cheng-Chieh=20 On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D > wrote: Are those flags needed for all packages that build with GCC? Should this be moved into tools_def.txt? Mike > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Cheng-Chieh Huang via = groups.io =20 > Sent: Wednesday, July 21, 2021 6:23 AM > To: devel@edk2.groups.io =20 > Cc: Cheng-Chieh Huang > > Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE= to avoid generating floating points operation >=20 > This will allow we compile payload using gcc8 >=20 > Signed-off-by: Cheng-Chieh Huang > > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayl= oadPkg.dsc > index 8aa5f18cd35c..fa41c5a24af5 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -30,6 +30,8 @@ [Defines] > DEFINE PS2_KEYBOARD_ENABLE =3D FALSE > DEFINE UNIVERSAL_PAYLOAD =3D FALSE >=20 > + DEFINE DISABLE_MMX_SSE =3D FALSE > + > # > # SBL: UEFI payload for Slim Bootloader > # COREBOOT: UEFI payload for coreboot > @@ -96,6 +98,9 @@ [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFAC= ES > !if $(BOOTLOADER) =3D=3D "LINUXBOOT" > *_*_*_CC_FLAGS =3D -D LINUXBOOT_PAYLOAD > +!endif > +!if $(DISABLE_MMX_SSE) > + *_*_*_CC_FLAGS =3D -mno-mmx -mno-sse > !endif > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > -- > 2.32.0.402.g57bb445576-goog >=20 >=20 >=20 >=20 >=20 ------=_NextPart_000_0004_01D77EDB.EFE55240 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Tools_def.txt doesn=E2=80=99t support build flag DISABLE_GCC_MMX_SSE. If this flag is moved into BaseTo= ols\Conf\tools_def.template, -mno-mmx -mno-sse option will be the default G= CC options. That means all platforms will apply them.

 

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB= =A3=E8=A1=A8 Cheng-Chieh Huang via groups.io
=E5=8F=91=E9= =80=81=E6=97=B6=E9=97=B4: 2021=E5=B9= = =B47=E6=9C=8822=E6=97= =A5 1:43
=E6=94=B6=E4=BB=B6=E4=BA=BA: Kinney, Michael D <michael.= d.kinney@intel.com>
=E6=8A=84=E9=80=81:<= /span> devel@edk2.groups.io
=E4=B8=BB= =E9=A2=98: Re: [edk2-deve= l] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating f= loating points operation

 

Yes, we can. I will drop this patch for= this  uefipayload batch and send another one for support DISABLE_GCC_= MMX_SSE in tools_de.txt.

 

--

Cheng-Chieh <= o:p>

On T= hu, Jul 22, 2021, 12:35 AM Kinney, Michael D <michael.d.kinney@intel.com> wrote:

Are those f= lags needed for all packages that build with GCC?

Should this be mov= ed into tools_def.txt?

Mike

> -----Original Message-----> From: deve= l@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Cheng-Chieh Huang via groups.io
> Sent: Wed= nesday, July 21, 2021 6:23 AM
> To: devel@edk2.groups.io
> Cc: Cheng-Chieh H= uang <chengch= ieh@google.com>
> Subject: [edk2-devel] [PATCH v1 5/6] UefiPay= loadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation<= br>>
> This will allow we compile payload using gcc8
>
= > Signed-off-by: Cheng-Chieh Huang <chengchieh@google.com>
> ---
>=   UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++
>  1 file cha= nged, 5 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayl= oadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 8aa5f18cd35c..= fa41c5a24af5 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
>= +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -30,6 +30,8 @@ [Defines= ]
>    DEFINE PS2_KEYBOARD_ENABLE       = ;   =3D FALSE
>    DEFINE UNIVERSAL_PAYLOAD  &nbs= p;         =3D FALSE
>
> +  DEFINE DI= SABLE_MMX_SSE              =3D FALSE
= > +
>    #
>    # SBL:    &nbs= p; UEFI payload for Slim Bootloader
>    # COREBOOT: UEFI p= ayload for coreboot
> @@ -96,6 +98,9 @@ [BuildOptions]
>  =   *_*_*_CC_FLAGS               = ;  =3D -D DISABLE_NEW_DEPRECATED_INTERFACES
>  !if $(BOOTLO= ADER) =3D=3D "LINUXBOOT"
>    *_*_*_CC_FLAGS = ;                =3D -D LINUXBOOT_P= AYLOAD
> +!endif
> +!if $(DISABLE_MMX_SSE)
> +  *_*_= *_CC_FLAGS                 =3D= -mno-mmx -mno-sse
>  !endif
>    GCC:*_UNIXGCC_= *_CC_FLAGS       =3D -DMDEPKG_NDEBUG
>  &nbs= p; GCC:RELEASE_*_*_CC_FLAGS       =3D -DMDEPKG_NDEBUG> --
> 2.32.0.402.g57bb445576-goog
>
>
> >
>

------=_NextPart_000_0004_01D77EDB.EFE55240--