From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.1109.1643420673775553217 for ; Fri, 28 Jan 2022 17:44:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([101.224.116.119]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sat, 29 Jan 2022 09:44:24 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.224.116.119 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: , "'Alexander Graf'" References: <9447e1ddbb2aa9089456a25779cd5b8e1f0140ac.1643120206.git.ncoleon@amazon.com> <20220128105240.2uofqayzqo5mfbto@sirius.home.kraxel.org> In-Reply-To: <20220128105240.2uofqayzqo5mfbto@sirius.home.kraxel.org> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYzIDcvOF0gTWRlTW9kdWxlUGtnL1BjaSBNZGVQa2c6IENyZWF0ZSBzZXJ2aWNlIHRvIHJldHJpZXZlIFBDSSBiYXNlIGFkZHJlc3Nlcw==?= Date: Sat, 29 Jan 2022 09:44:24 +0800 Message-ID: <000301d814b1$bed35f00$3c7a1d00$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQD56awtIMm7F9zeJntoTOGc0MfCFQI3spT9APiCu6GuHAwbQA== Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Gerd > Hoffmann > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA1=D4=C228=C8=D5 18:53 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; ncoleon@amazon.com > =B3=AD=CB=CD: atugup@amazon.com; Alexander Graf > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v3 7/8] MdeModulePkg/Pci MdePkg: Cr= eate > service to retrieve PCI base addresses >=20 > Hi, >=20 > > --- a/MdePkg/Include/Protocol/PciHostBridgeResourceAllocation.h > > +++ b/MdePkg/Include/Protocol/PciHostBridgeResourceAllocation.h > > @@ -367,6 +367,33 @@ EFI_STATUS > > IN EFI_PCI_CONTROLLER_RESOURCE_ALLOCATION_PHASE > Phase > > ); > > > > +/** > > + Retrieves the base addresses of ost bridge resources. > > + > > + @param This The pointer to the > EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL instance. > > + @param RootBridgeHandle The PCI root bridge handle. > > + @param IoBase The pointer to PIO aperture base > address. > > + @param Mem32Base The pointer to 32-bit aperture base > address. > > + @param PMem32Base The pointer to 32-bit prefetchable > aperture base address. > > + @param Mem64Base The pointer to 64-bit aperture base > address. > > + @param PMem64Base The pointer to 64-bit prefetchable > aperture base address. > > + > > + @retval EFI_SUCCESS Succeed. > > + @retval EFI_NOT_FOUND Root bridge was not found. > > + > > +**/ > > +typedef > > +EFI_STATUS > > +(EFIAPI > *EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL_GET_RESOU > RCES_BASES)( > > + IN EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL *This, > > + IN EFI_HANDLE > RootBridgeHandle, > > + OUT UINT64 > *IoBase, > > + OUT UINT64 > *Mem32Base, > > + OUT UINT64 > *PMem32Base, > > + OUT UINT64 > *Mem64Base, > > + OUT UINT64 > *PMem64Base > > + ); > > + > > /// > > /// Provides the basic interfaces to abstract a PCI host bridge resource > allocation. > > /// > > @@ -415,6 +442,12 @@ struct > _EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL { > > /// before enumeration. > > /// > > > EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL_PREPROCESS_ > CONTROLLER PreprocessController; > > + > > + /// > > + /// Returns the aligned base addresses of the different resource > windows > > + /// of the host bridge. Intended for use before resources are submitted. > > + /// > > + > EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL_GET_RESOUR > CES_BASES GetResourcesBases; > > }; >=20 > Hmm, not sure the protocol can be changed like that without risking > breakage, the uefi protocols are the binary interface between uefi > modules ... >=20 This protocol is defined in PI spec. Its change needs to get UEFI org approve. If this service is required, one new protocol can be added into MdeModulePk= g as=20 edk2 implementation protocol.=20 Thanks Liming > take care, > Gerd >=20 >=20 >=20 >=20 >=20