回复: [PATCH v2 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & length defines.

["gaoliming" <gaoliming@byosoft.com.cn>]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Giri Mudusuru <girim@apple.com>
> 发送时间: 2023年5月5日 8:17
> 收件人: devel@edk2.groups.io
> 抄送: Giri Mudusuru <girim@apple.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Andrew Fish <afish@apple.com>
> 主题: [PATCH v2 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string &
> length defines.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3805
> 
> Add SMBIOS spec defined anchor strings & length defines.
> 
>  - '_SM_' chapter 5.2.1 SMBIOS 2.1 (32-bit) Entry Point
>  - '_SM3_' chapter 5.2.2 SMBIOS 3.0 (64-bit) Entry Point
> 
> Changes from v1 to v2:
>  - Replace non-ASCII characters
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Signed-off-by: Giri Mudusuru <girim@apple.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 22
> ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 9cbdec1182..89985bb418 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -48,6 +48,24 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  //
> 
>  #define SMBIOS_3_0_TABLE_MAX_LENGTH  0xFFFFFFFF
> 
> 
> 
> +///
> 
> +/// Reference SMBIOS 3.4, chapter 5.2.1 SMBIOS 2.1 (32-bit) Entry Point
> 
> +/// Table 1 - SMBIOS 2.1 (32-bit) Entry Point structure, offset 00h
> 
> +/// _SM_, specified as four ASCII characters (5F 53 4D 5F).
> 
> +///@{
> 
> +#define SMBIOS_ANCHOR_STRING         "_SM_"
> 
> +#define SMBIOS_ANCHOR_STRING_LENGTH  4
> 
> +///@}
> 
> +
> 
> +///
> 
> +/// Reference SMBIOS 3.4, chapter 5.2.2 SMBIOS 3.0 (64-bit) Entry Point
> 
> +/// Table 2 - SMBIOS 3.0 (64-bit) Entry Point structure, offset 00h
> 
> +/// _SM3_, specified as five ASCII characters (5F 53 4D 33 5F).
> 
> +///@{
> 
> +#define SMBIOS_3_0_ANCHOR_STRING         "_SM3_"
> 
> +#define SMBIOS_3_0_ANCHOR_STRING_LENGTH  5
> 
> +///@}
> 
> +
> 
>  //
> 
>  // SMBIOS type macros which is according to SMBIOS 3.3.0 specification.
> 
>  //
> 
> @@ -138,7 +156,7 @@ typedef UINT16 SMBIOS_HANDLE;
>  ///
> 
>  #pragma pack(1)
> 
>  typedef struct {
> 
> -  UINT8     AnchorString[4];
> 
> +  UINT8     AnchorString[SMBIOS_ANCHOR_STRING_LENGTH];
> 
>    UINT8     EntryPointStructureChecksum;
> 
>    UINT8     EntryPointLength;
> 
>    UINT8     MajorVersion;
> 
> @@ -155,7 +173,7 @@ typedef struct {
>  } SMBIOS_TABLE_ENTRY_POINT;
> 
> 
> 
>  typedef struct {
> 
> -  UINT8     AnchorString[5];
> 
> +  UINT8     AnchorString[SMBIOS_3_0_ANCHOR_STRING_LENGTH];
> 
>    UINT8     EntryPointStructureChecksum;
> 
>    UINT8     EntryPointLength;
> 
>    UINT8     MajorVersion;
> 
> --
> 2.39.2 (Apple Git-144)