From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.3376.1603421880948616700 for ; Thu, 22 Oct 2020 19:58:01 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 23 Oct 2020 10:57:47 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Ray Ni'" , "'Dong, Eric'" , "'Michael D Kinney'" Cc: "'Brijesh Singh'" , "'Michael D Kinney'" , "'Zhiguang Liu'" , "'Jordan Justen'" , "'Ard Biesheuvel'" References: <523f270e4e6f7a62cdbebc541b442bd766e7ab3a.1602864557.git.thomas.lendacky@amd.com> <000d01d6a5b9$03d14ef0$0b73ecd0$@byosoft.com.cn> <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com> <006f01d6a67d$80b77d80$82267880$@byosoft.com.cn> <8734b948-e36c-81f4-43ae-6c63fba1374b@amd.com> <004401d6a744$b6208e90$2261abb0$@byosoft.com.cn> <008b01d6a812$4a331df0$de9959d0$@byosoft.com.cn> <4f1962a2-f417-4c27-1ddb-957b3d3abeb0@redhat.com> In-Reply-To: <4f1962a2-f417-4c27-1ddb-957b3d3abeb0@redhat.com> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSDlm57lpI06IOWbnuWkjTog5Zue5aSNOiBbUEFUQ0ggdjIgMDEvMTFdIE1kZVBrZywgT3ZtZlBrZzogQ2xlYW4gdXAgR0hDQiBmaWVsZCBvZmZzZXRzIGFuZCBzYXZlIGFyZWE=?= Date: Fri, 23 Oct 2020 10:57:49 +0800 Message-ID: <000401d6a8e8$4b15d790$e14186b0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKfp3CfnkRussMBowKfV6mBTee23AEhTXMjAhC1oQABkbdHWQKBSxHFAkw2+IcBgYSO7gGljQ5xAb05JFEB4uAvjAKlFgZfAfbmtJinatqKYA== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Laszlo: I agree Bisectability is important. I want to consider the impact and bal= ance the change. Now, this change will update UefiCpuPkg. I also want to co= llect the feedback from UefiCpuPkg maintainer: Ray and Eric.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66536+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Laszlo= Ersek > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8822=E6=97= =A5 21:13 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel= @edk2.groups.io; > thomas.lendacky@amd.com > =E6=8A=84=E9=80=81: 'Brijesh Singh' ; 'Michael D = Kinney' > ; 'Zhiguang Liu' ; > 'Jordan Justen' ; 'Ard Biesheuvel' > > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4= = =8D: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [PATCH v2 01/11] MdePkg, > OvmfPkg: Clean up GHCB field offsets and save area >=20 > On 10/22/20 03:25, gaoliming wrote: > > Tom: > > For the patch in UefiCpuPkg, this changes the library interface. So,= the > consumer and producer code is required to be changed together. There is = no > good compatible way to do it. I still prefer to separate them for the di= fferent > package. Although the first commit breaks the tree, your patch is the pa= tch > serial, they will be merged together. Its impact should be small. >=20 > I really disagree here. Bisectability is way more important, in my > opinion, than avoiding a multi-package patch. >=20 > I agree we should avoid multi-package patches as much as we can -- but > not more than we can. Bisectability (=3D keeping the tree buildable at > every commit) is very important, in my opinion. >=20 > Thanks, > Laszlo >=20 >=20 >=20 >=20 >=20