From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 792D2941135 for ; Wed, 19 Jul 2023 05:23:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=B6adYm7DeBQAC0g2IWmsGE8j8gHVTG6tk8/cOTonmOE=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-Received:X-Received:X-Received:X-WM-Sender:X-Originating-IP:X-WM-AuthFlag:X-WM-AuthUser:From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1689744224; v=1; b=fET5knCRMJVo70fyHKR3alQPx41qoB3Wo76GQ2cAwOeOHsStTB4HNvy8dAmaKMRNugt3PB24 5/ZAUIhcC5ab3a/4sWtAglERqN7dAlPb4Qasdczd/TMQp8AFWlSjiQAUkdVTB56a9qzv7POVlFq Gol3SpL5dSnLZAQ2RTnkfbAc= X-Received: by 127.0.0.2 with SMTP id lWmPYY7687511x6eUmbu5VjW; Tue, 18 Jul 2023 22:23:44 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.7506.1689744222536161806 for ; Tue, 18 Jul 2023 22:23:43 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id CA92CA32E20F for ; Wed, 19 Jul 2023 13:23:37 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 4E787A32E1FF for ; Wed, 19 Jul 2023 13:23:37 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id BBA0DA32E1C3 for ; Wed, 19 Jul 2023 13:23:25 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 19 Jul 2023 13:23:15 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , , "'Taylor Beebe'" Cc: "'Andrew Fish'" , "'Dandan Bi'" , "'Eric Dong'" , "'Gerd Hoffmann'" , "'Guo Dong'" , "'Gua Guo'" , "'James Lu'" , "'Jian J Wang'" , "'Jiewen Yao'" , "'Jordan Justen'" , "'Leif Lindholm'" , "'Rahul Kumar'" , "'Ray Ni'" , "'Sami Mujawar'" , "'Sean Rhodes'" References: <20230718184006.534-1-t@taylorbeebe.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDAvOV0gQWRkIEltYWdlUHJvcGVydGllc1JlY29yZExpYiBhbmQgRml4IE1BVCBCdWdz?= Date: Wed, 19 Jul 2023 13:23:15 +0800 Message-ID: <000501d9ba01$1edb6a50$5c923ef0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIz9/mX0XP/RFIcgMjqaEeYTT90SQJZTUOJrvlF6MA= Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: CJuDuMv1AxTq8DRzqwnbUDLsx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fET5knCR; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Ard: Now, there is no compatible way to introduce new library class for the ba= sic module. One possible solution is to define the default library instance= in package dec file together with the library class declaration.=20 Beebe: This patch set looks good. But, the last patch 9/9 will require every pla= tform to be updated. I may suggest to merge the first 8 patches for this st= able tag 202308. The last one 9/9 can be merged for next stable tag 202311.= Then, the platform owner have time to update their DSC first.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Ard > Biesheuvel > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B47=E6=9C=8819=E6=97=A5 = 4:18 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Taylor Beebe > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Andrew Fish ; = Dandan Bi > ; Eric Dong ; Gerd Hoffmann > ; Guo Dong ; Gua Guo > ; James Lu ; Jian J Wang > ; Jiewen Yao ; Jordan Justen > ; Leif Lindholm ; > Liming Gao ; Rahul Kumar > ; Ray Ni ; Sami Mujawar > ; Sean Rhodes > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 0/9] Add ImagePropertiesRe= cordLib and Fix > MAT Bugs >=20 > On Tue, 18 Jul 2023 at 20:40, Taylor Beebe wrote: > > > > Reference: https://github.com/tianocore/edk2/pull/4590 > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4492 > > > > The UEFI and SMM MAT logic contains duplicate logic for manipulating > image > > properties records which is used to track runtime images. > > This patch series adds a new library, ImagePropertiesRecordLib, > > which consolidates this logic and fixes the bugs which currently exist = in > > the MAT logic. > > > > The first patch adds the ImagePropertiesRecordLib implementation which > > is a copy of the UEFI MAT logic with minor modifications to remove the > > reliance on globabl variables and make the code unit testable. > > > > The second patch adds a unit test for the ImagePropertiesRecordLib. The > > logic tests various potential layouts of the EFI memory map and runtime > > images. 3/4 of these tests will fail which demonstrates the MAT logic > > bugs. > > > > The third patch fixes the logic in the ImagePropertiesRecordLib so > > that all of the unit tests pass and the MAT logic can be fixed by > > using the library. > > > > The remaining patches add library instances to DSC files and remove > > the image properties record logic from the SMM and UEFI MAT logic. > > >=20 > This all looks fine to me, but this is another series of the pattern > - break out some functionality into a new lib class > - provide a single implementation of that lib class > - track down every DSC in existence and add the same library class > resolution to each. >=20 > Could we *please* have a way for library classes to be declared with a > default resolution? That way, series such as this one will be a lot > leaner, and as a bonus, I am sure that there is a lot of boilerplate > that can be removed from existing DSCs for library classes that only > have a single implementation. >=20 > For this series, >=20 > Acked-by: Ard Biesheuvel >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107036): https://edk2.groups.io/g/devel/message/107036 Mute This Topic: https://groups.io/mt/100230477/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-