From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <pierre.gondois@arm.com>,
"'Bob Feng'" <bob.c.feng@intel.com>,
"'Sami Mujawar'" <sami.mujawar@arm.com>
Cc: "'Christopher Jones'" <Christopher.Jones@arm.com>
Subject: 回复: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name
Date: Wed, 29 Sep 2021 09:35:22 +0800 [thread overview]
Message-ID: <000601d7b4d2$451c1880$cf544980$@byosoft.com.cn> (raw)
In-Reply-To: <bb15487d-1500-13e9-a28f-26a2d16cd16c@arm.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> PierreGondois
> 发送时间: 2021年9月24日 19:57
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Bob
> Feng' <bob.c.feng@intel.com>; 'Sami Mujawar' <sami.mujawar@arm.com>
> 抄送: 'Christopher Jones' <Christopher.Jones@arm.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name
>
> Hi Liming,
>
> I created: https://bugzilla.tianocore.org/show_bug.cgi?id=3653
>
> Regards,
>
> Pierre
>
> On 9/24/21 1:48 AM, gaoliming wrote:
> > Pierre:
> > Can you submit BZ for this change request?
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> >> 发送时间: 2021年9月23日 16:59
> >> 收件人: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>;
> Liming
> >> Gao <gaoliming@byosoft.com.cn>; Sami Mujawar
> <sami.mujawar@arm.com>
> >> 主题: [PATCH v1 0/4] Set default Makefile name
> >>
> >> From: Pierre Gondois <Pierre.Gondois@arm.com>
> >>
> >> A Makefile name is not set in BaseTools when only building modules
> >> or libraries. This patch-set sets a default Makefile name for the
> >> "build" command.
> >>
> >> The patch-set also:
> >> - Removes unsused Makefile variables
> >> - Removes hard-coded references to "target.txt" and "tools_def.txt"
> >>
> >> The changes can be seen at:
> >>
> https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_correcti
> >> ons_v1
> >>
> >> Pierre Gondois (4):
> >> BaseTools/GenMake: Use ToolDefinition as fallback option
> >> BaseTools/build: Set MakefileName
> >> BaseTools: Remove Makefile/MakefileName fields
> >> BaseTools: Remove hard-coded strings for target and tools_def
> >>
> >> BaseTools/Source/Python/AutoGen/GenMake.py | 8
> >> ++++----
> >> BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 1 -
> >> BaseTools/Source/Python/GenFds/GenFds.py | 4 ++--
> >> .../Source/Python/GenFds/GenFdsGlobalVariable.py | 4 ++--
> >> BaseTools/Source/Python/TargetTool/TargetTool.py | 3 ++-
> >> BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 --
> >> BaseTools/Source/Python/Workspace/DscBuildData.py | 9
> ++++-----
> >> BaseTools/Source/Python/build/build.py | 11
> ++++-------
> >> 8 files changed, 18 insertions(+), 24 deletions(-)
> >>
> >> --
> >> 2.17.1
> >
> >
> >
> >
>
>
>
>
next prev parent reply other threads:[~2021-09-29 1:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:58 [PATCH v1 0/4] Set default Makefile name PierreGondois
2021-09-23 8:59 ` [PATCH v1 1/4] BaseTools/GenMake: Use ToolDefinition as fallback option PierreGondois
2021-09-23 8:59 ` [PATCH v1 2/4] BaseTools/build: Set MakefileName PierreGondois
2021-09-23 8:59 ` [PATCH v1 3/4] BaseTools: Remove Makefile/MakefileName fields PierreGondois
2021-09-23 8:59 ` [PATCH v1 4/4] BaseTools: Remove hard-coded strings for target and tools_def PierreGondois
2021-09-23 10:05 ` [edk2-devel] [PATCH v1 0/4] Set default Makefile name Chris Jones
2021-09-24 0:48 ` 回复: " gaoliming
2021-09-24 11:57 ` PierreGondois
2021-09-29 1:35 ` gaoliming [this message]
2021-09-29 11:43 ` Bob Feng
[not found] ` <16A94849D004DAA5.16095@groups.io>
2021-09-29 11:53 ` [edk2-devel] " Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601d7b4d2$451c1880$cf544980$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox