From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.62516.1679534212005876368 for ; Wed, 22 Mar 2023 18:16:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=dWwAi1sq; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6CBD3CD1F790 for ; Thu, 23 Mar 2023 09:16:49 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1679534209; bh=wJM+Dp6djr/qcXFA5sWrXR+KKNgwJDFOSZk7ts6g+3Y=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=dWwAi1sqUwJAMH5Z3Etuv/Pw7rlPnpdL9VvFXvE+e+nWJlyb+3iovMoztuClq0emJ dsfJfEm1kD5ddU8slZIDYA0N4QnSH4aDuLiXlZp1124cyVhrIgQ0UWZ/vbgli/epjx u1s5AzX9cx8JFPD1RXFL1NQdUtf+uhTGYEWplvmA= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 686EDCD1F777 for ; Thu, 23 Mar 2023 09:16:49 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 3D68CCD1F734 for ; Thu, 23 Mar 2023 09:16:49 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id B6AB7CD1F72C for ; Thu, 23 Mar 2023 09:16:46 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 23 Mar 2023 09:16:42 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Tan, Dun'" , Cc: "'Kinney, Michael D'" , "'Liu, Zhiguang'" References: <20230309034005.927-1-dun.tan@intel.com> <20230309034005.927-2-dun.tan@intel.com> <007601d952f6$3e2efec0$ba8cfc40$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbUGF0Y2ggVjMgMS8yXSBNZGVQa2c6IG1vZGlmeSB0aGUgd3JvbmcgJ0FjcGlJZCcgdG8gJ0FwaWNJZCcgaW4gTXBXYWtldXBTdHJ1Y3R1cmU=?= Date: Thu, 23 Mar 2023 09:16:44 +0800 Message-ID: <000601d95d25$221c3f70$6654be50$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG2R1h9sMdW4rfdI1rsYMw90uhYpAISsdrjAfKfGmoCAFwTg68djdiQ Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Dun: OK. Reviewed-by: Liming Gao =20 Can you create PR for this patch set? I will merge this PR.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Tan, Dun > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2023=E5=B9=B43=E6=9C=8810=E6=97=A5 14:17 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Gao, Liming ; = devel@edk2.groups.io > =E6=8A=84=E9=80=81: Kinney, Michael D ; = Liu, Zhiguang > > =E4=B8=BB=E9=A2=98: RE: [Patch V3 1/2] MdePkg: modify the wrong = 'AcpiId' to 'ApicId' in > MpWakeupStructure >=20 > Hi Liming, >=20 > I've checked edk2 and edk2-platforms repo. This code change doesn't > impacted any code. > The MultiprocessorWakeupMailbox structure has not been used yet. >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: gaoliming > Sent: Friday, March 10, 2023 10:16 AM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Liu, Zhiguang > > Subject: =E5=9B=9E=E5=A4=8D: [Patch V3 1/2] MdePkg: modify the wrong = 'AcpiId' to 'ApicId' > in MpWakeupStructure >=20 > Dun: > Is there any code impact with this change? >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Dun Tan > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2023=E5=B9=B43=E6=9C=889=E6=97=A5 11:40 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Michael D Kinney ; = Liming Gao > > ; Zhiguang Liu > > =E4=B8=BB=E9=A2=98: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' = to 'ApicId' in > > MpWakeupStructure > > > > modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure = defination > > in Acpi64.h. > > > > Signed-off-by: Dun Tan > > Cc: Michael D Kinney > > Cc: Liming Gao > > Reviewed-by: Zhiguang Liu > > --- > > MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > > b/MdePkg/Include/IndustryStandard/Acpi64.h > > index fe5ebfac2b..bfd022b6b6 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > > @@ -607,7 +607,7 @@ typedef struct { > > typedef struct { > > UINT16 Command; > > UINT16 Reserved; > > - UINT32 AcpiId; > > + UINT32 ApicId; > > UINT64 WakeupVector; > > UINT8 ReservedForOs[2032]; > > UINT8 ReservedForFirmware[2048]; > > -- > > 2.31.1.windows.1 >=20 >=20