回复: [edk2-devel] [Patch] BaseTools: Fix PcdValueInit tool build issue with VS compiler x64

["gaoliming" <gaoliming@byosoft.com.cn>]

Sean and Bob:
  How verify this change?

Thanks
Liming
> -----邮件原件-----
> 发件人: Sean Brogan <spbrogan@outlook.com>
> 发送时间: 2020年10月17日 6:17
> 收件人: devel@edk2.groups.io; bob.c.feng@intel.com
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen
> <yuwei.chen@intel.com>; Michael D Kinney <michael.d.kinney@intel.com>;
> Sean Brogan <sean.brogan@microsoft.com>
> 主题: Re: [edk2-devel] [Patch] BaseTools: Fix PcdValueInit tool build issue
> with VS compiler x64
> 
> Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
> 
> On 10/15/2020 4:20 AM, Bob Feng wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3001
> >
> > When the 64-bit version of VS compiler is used, the generated
> > PcdValueInit tool will be failed to compile.
> >
> > This patch is going to fix that issue.
> >
> > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> >
> > ---
> >   BaseTools/Source/C/Common/PcdValueCommon.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/C/Common/PcdValueCommon.h
> b/BaseTools/Source/C/Common/PcdValueCommon.h
> > index cfd3bb76e1..1652bd5430 100644
> > --- a/BaseTools/Source/C/Common/PcdValueCommon.h
> > +++ b/BaseTools/Source/C/Common/PcdValueCommon.h
> > @@ -12,11 +12,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >   #include <Common/UefiBaseTypes.h>
> >   #include <Common/UefiInternalFormRepresentation.h>
> >
> >   #define __FIELD_SIZE(TYPE, Field) (sizeof((TYPE *)0)->Field)
> >   #define __ARRAY_ELEMENT_SIZE(TYPE, Field) (sizeof((TYPE
> *)0)->Field[0])
> > -#define __OFFSET_OF(TYPE, Field) ((UINT32) &(((TYPE *)0)->Field))
> > +#define __OFFSET_OF(TYPE, Field) ((UINT32)(size_t) &(((TYPE *)0)->Field))
> >   #define __FLEXIBLE_SIZE(Size, TYPE, Field, MaxIndex)   if
> (__FIELD_SIZE(TYPE, Field) == 0) Size = MAX((__OFFSET_OF(TYPE, Field) +
> __ARRAY_ELEMENT_SIZE(TYPE, Field) * (MaxIndex)), Size)
> >   #define __ARRAY_SIZE(Array) (sizeof(Array)/sizeof(Array[0]))
> >
> >   #if defined(_MSC_EXTENSIONS)
> >   #define __STATIC_ASSERT static_assert
> >