From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.8554.1604909496283789628 for ; Mon, 09 Nov 2020 00:11:37 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: fengyunhua@byosoft.com.cn) Received: from LAPTOP2AECFQIA ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 09 Nov 2020 16:11:34 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: fengyunhua@byosoft.com.cn From: "fengyunhua" To: , Cc: "'Liming Gao'" , "'Chen, Christine'" References: <20201030033939.2094-1-fengyunhua@byosoft.com.cn> <20201030033939.2094-3-fengyunhua@byosoft.com.cn> <000001d6b662$f4eef6c0$decce440$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDIvMl0gQmFzZVRvb2xzOiB1cGRhdGUgcmVwb3J0IG1hcCBmaWxlIGZvcm1hdA==?= Date: Mon, 9 Nov 2020 16:11:33 +0800 Message-ID: <000701d6b66f$f03c3130$d0b49390$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEswrjjJEBfHs6pNUEUQY+rCEqxJwJ+InjLAYoNF8EBc4HMJgGEgbTNqttYGQA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Ok, I have updated commit message with v3 Thanks, Yunhua -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67162+5049190+8953120@groups.io = =E4=BB=A3=E8=A1=A8 Bob Feng =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=889=E6=97=A5 1= 5:09 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; fengyunhua@byosoft.com.= cn =E6=8A=84=E9=80=81: 'Liming Gao' ; Chen, Christi= ne =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update repo= rt map file format Yes. I know this from the code review mail. But only the patch subject and= message body will be recorded in commit log. People can not tell what the = relationship between your patch 1/2 and patch 2/2 based on the commit histo= ry. So I think each of the patches need to have a complete description. There = should be some necessary context info about this patch. Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of fengyunhua Sent: Monday, November 9, 2020 2:39 PM To: devel@edk2.groups.io; Feng, Bob C Cc: 'Liming Gao' ; Chen, Christine Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v2 2/2] BaseTools: update= report map file format Hi Bob, This series patch for BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2977 Because of .map file changed, so we should change the regular expression p= attern for the match Thanks, Yunhua -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67141+5049190+8953120@groups.io =E4=BB=A3=E8=A1=A8 Bob Feng =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=889=E6=97=A5 1= 4:15 =E6=94=B6=E4=BB=B6=E4=BA=BA: Yunhua Feng ; deve= l@edk2.groups.io =E6=8A=84=E9=80=81: Liming Gao ; Chen, Christine= =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update repo= rt map file format Yuhuan, Would you please provide a complete commit message to this patch? Thanks, Bob -----Original Message----- From: Yunhua Feng Sent: Friday, October 30, 2020 11:40 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [PATCH v2 2/2] BaseTools: update report map file format update report map file format Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py index 8efa869162..330234e5af 100644 --- a/BaseTools/Source/Python/build/BuildReport.py +++ b/BaseTools/Source/Python/build/BuildReport.py @@ -60,7 +60,7 @@ gPcdGuidPattern =3D re.compile(r"PCD\((\w+)[.](\w+)\)") gOffsetGuidPattern =3D re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)") =20 ## Pattern to find module base address and entry point in fixed flash map= file -gModulePattern =3D r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=3D%(Address= )s,\s*EntryPoint=3D%(Address)s\ )\s*\(GUID=3D([-0-9A-Fa-f]+)[^)]*\)" +gModulePattern =3D r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=3D%(Address)s,\s*EntryPoint=3D%(Addr= ess)s, \s*Type=3D\w+\)\s*\(GUID=3D([-0-9A-Fa-f]+)[^)]*\)" gMapFileItemPattern =3D re.compile(gModulePattern % {"Address" : "(-?0[xX][0-9A-Fa-f]+)"}) =20 ## Pattern to find all module referenced header files in source files -- 2.27.0.windows.1