From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web08.7436.1609722100620665274
 for <devel@edk2.groups.io>;
 Sun, 03 Jan 2021 17:01:41 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Mon, 04 Jan 2021 09:01:36 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Name'" <ipark@nvidia.com>,
	<devel@edk2.groups.io>,
	<bob.c.feng@intel.com>
References: <ba5c63d5c4d379bfcb2d3d34f257a6e48b2fc6b9.1609205485.git.ipark@nvidia.com>
In-Reply-To: <ba5c63d5c4d379bfcb2d3d34f257a6e48b2fc6b9.1609205485.git.ipark@nvidia.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0hdIEJhc2VUb29sczogRml4IHRoZSBpbXByb3BlciBlcnJvciBsb2dnaW5n?=
Date: Mon, 4 Jan 2021 09:01:36 +0800
Message-ID: <000801d6e235$270f8180$752e8480$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKDLyH10okezvRdqUoMe7GRvpOpdai+C+rg
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Good catch. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Name <ipark@nvidia.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA12=D4=C229=C8=D5 9:47
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; bob.c.feng@intel.com;
> gaoliming@byosoft.com.cn
> =B3=AD=CB=CD: Irene Park <ipark@nvidia.com>
> =D6=F7=CC=E2: [PATCH] BaseTools: Fix the improper error logging
>=20
> From: Irene Park <ipark@nvidia.com>
>=20
> EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the
> expected error message when an error occurs.
>=20
> Signed-off-by: Irene Park <ipark@nvidia.com>
>=20
> ---
>  BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> index 0870c44..ad5dae0 100644
> --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> @@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
>      delta =3D {}
>      for skuname, skuid in PcdDBData:
>          if len(PcdDBData[(skuname, skuid)][1]) !=3D
> len(PcdDBData[(TAB_DEFAULT, "0")][1]):
> -            EdkLogger.ERROR("The size of each sku in one pcd are not
> same")
> +            EdkLogger.error("build", AUTOGEN_ERROR, "The size of each
> sku in one pcd are not same")
>      for skuname, skuid in PcdDBData:
>          if skuname =3D=3D TAB_DEFAULT:
>              continue
> --
> 2.7.4