* [PATCH] BaseTools: Fix the improper error logging
@ 2020-12-29 1:46 Irene Park
2021-01-04 1:01 ` 回复: " gaoliming
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Irene Park @ 2020-12-29 1:46 UTC (permalink / raw)
To: devel, bob.c.feng, gaoliming; +Cc: Irene Park
From: Irene Park <ipark@nvidia.com>
EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the
expected error message when an error occurs.
Signed-off-by: Irene Park <ipark@nvidia.com>
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
delta = {}
for skuname, skuid in PcdDBData:
if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
- EdkLogger.ERROR("The size of each sku in one pcd are not same")
+ EdkLogger.error("build", AUTOGEN_ERROR, "The size of each sku in one pcd are not same")
for skuname, skuid in PcdDBData:
if skuname == TAB_DEFAULT:
continue
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* 回复: [PATCH] BaseTools: Fix the improper error logging
2020-12-29 1:46 [PATCH] BaseTools: Fix the improper error logging Irene Park
@ 2021-01-04 1:01 ` gaoliming
2021-01-04 2:32 ` [edk2-devel] " Bob Feng
[not found] ` <1656E6B2AE248774.11073@groups.io>
2 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2021-01-04 1:01 UTC (permalink / raw)
To: 'Name', devel, bob.c.feng
Good catch. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Name <ipark@nvidia.com>
> 发送时间: 2020年12月29日 9:47
> 收件人: devel@edk2.groups.io; bob.c.feng@intel.com;
> gaoliming@byosoft.com.cn
> 抄送: Irene Park <ipark@nvidia.com>
> 主题: [PATCH] BaseTools: Fix the improper error logging
>
> From: Irene Park <ipark@nvidia.com>
>
> EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the
> expected error message when an error occurs.
>
> Signed-off-by: Irene Park <ipark@nvidia.com>
>
> ---
> BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> index 0870c44..ad5dae0 100644
> --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> @@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
> delta = {}
> for skuname, skuid in PcdDBData:
> if len(PcdDBData[(skuname, skuid)][1]) !=
> len(PcdDBData[(TAB_DEFAULT, "0")][1]):
> - EdkLogger.ERROR("The size of each sku in one pcd are not
> same")
> + EdkLogger.error("build", AUTOGEN_ERROR, "The size of each
> sku in one pcd are not same")
> for skuname, skuid in PcdDBData:
> if skuname == TAB_DEFAULT:
> continue
> --
> 2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
2020-12-29 1:46 [PATCH] BaseTools: Fix the improper error logging Irene Park
2021-01-04 1:01 ` 回复: " gaoliming
@ 2021-01-04 2:32 ` Bob Feng
[not found] ` <1656E6B2AE248774.11073@groups.io>
2 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-01-04 2:32 UTC (permalink / raw)
To: devel@edk2.groups.io, ipark@nvidia.com, gaoliming@byosoft.com.cn
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park
Sent: Tuesday, December 29, 2020 9:47 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn
Cc: Irene Park <ipark@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
From: Irene Park <ipark@nvidia.com>
EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expected error message when an error occurs.
Signed-off-by: Irene Park <ipark@nvidia.com>
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
delta = {}
for skuname, skuid in PcdDBData:
if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
- EdkLogger.ERROR("The size of each sku in one pcd are not same")
+ EdkLogger.error("build", AUTOGEN_ERROR, "The size of each
+ sku in one pcd are not same")
for skuname, skuid in PcdDBData:
if skuname == TAB_DEFAULT:
continue
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1656E6B2AE248774.11073@groups.io>]
* Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
[not found] ` <1656E6B2AE248774.11073@groups.io>
@ 2021-01-06 1:49 ` Bob Feng
0 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-01-06 1:49 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C, ipark@nvidia.com,
gaoliming@byosoft.com.cn
Created a PR https://github.com/tianocore/edk2/pull/1297
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Monday, January 4, 2021 10:33 AM
To: devel@edk2.groups.io; ipark@nvidia.com; gaoliming@byosoft.com.cn
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park
Sent: Tuesday, December 29, 2020 9:47 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn
Cc: Irene Park <ipark@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
From: Irene Park <ipark@nvidia.com>
EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expected error message when an error occurs.
Signed-off-by: Irene Park <ipark@nvidia.com>
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
delta = {}
for skuname, skuid in PcdDBData:
if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
- EdkLogger.ERROR("The size of each sku in one pcd are not same")
+ EdkLogger.error("build", AUTOGEN_ERROR, "The size of each
+ sku in one pcd are not same")
for skuname, skuid in PcdDBData:
if skuname == TAB_DEFAULT:
continue
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-06 1:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-29 1:46 [PATCH] BaseTools: Fix the improper error logging Irene Park
2021-01-04 1:01 ` 回复: " gaoliming
2021-01-04 2:32 ` [edk2-devel] " Bob Feng
[not found] ` <1656E6B2AE248774.11073@groups.io>
2021-01-06 1:49 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox