From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 14FA5AC0E6A for ; Mon, 27 May 2024 09:25:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7LgVZM3gv8aSeYNGBsywRtUn65luNYyd9fESnYk3VM0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1716801919; v=1; b=riMqBFHMCVG0ddjMX2gO1i5yLe+Q/zCt3oCtAtJ6J9uxU0bC9p8AP8z0TfMEPKhH7IdNylCu cwj4Mq1yWYcincMKmjbCWu3WOTXaN6bt3eBhlI09PD/iLRkESQ03G/CVO2Zf4ji7y1JydQfkjEk tHYBr5bEekiPY7WrCVJ/HQBEMsCNZIVGPaeS0QpBkwRRFBekYLKZ3gnfklClkVE9V3P8cLHSTMU PZQCcZl01LpW2hITWlVkhwoxIMl3logVC4No1uHe4mYI1etf8yK+Ft4ZDzMZ3EQZVbiUDuJTAeS W11IDsgl+6CiIjK7RFYmTN+tij316FyFjDKxvXA2bAO0Q== X-Received: by 127.0.0.2 with SMTP id FA8XYY7687511xwXfLd7E0iy; Mon, 27 May 2024 02:25:18 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.23747.1716801910412423758 for ; Mon, 27 May 2024 02:25:12 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id D52FEA32E104 for ; Mon, 27 May 2024 17:25:07 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id AF1CBA32E032 for ; Mon, 27 May 2024 17:25:07 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 91CEAA32E0AC for ; Mon, 27 May 2024 17:25:04 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 27 May 2024 17:24:54 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Hou, Wenxing'" , , "'Kinney, Michael D'" , "'Andrew Fish'" , "'Leif Lindholm'" Cc: "'Ard Biesheuvel'" , , , "'Mathews, John'" , "'Li, Yi1'" , "'Yao, Jiewen'" References: <17CD1075E73EEFD7.30273@groups.io> <002501daa2ee$c4445660$4ccd0320$@byosoft.com.cn> <033201daa661$b5fbd670$21f38350$@byosoft.com.cn> <07b501daab8a$20f3b510$62db1f30$@byosoft.com.cn> <001201dab00e$d0ccbbc0$72663340$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gU29mdCBGZWF0dXJlIEZyZWV6ZSBzdGFydHMgbm93IGZvciBlZGsyLXN0YWJsZTIwMjQwNQ==?= Date: Mon, 27 May 2024 17:24:54 +0800 Message-ID: <000801dab017$bc4efb00$34ecf100$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKfbKTbXoEYRIOo6T31ZtZb+qHX+wLixre/AjTZjFUBoY5x1gKwsRPUA3duR2wBQDt5vgLXIFD6AbL91cOvi/jfUA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 27 May 2024 02:25:12 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kdQs2aOxphfG4fKjy1Erh4hKx7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0009_01DAB05A.CA74AC00" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=riMqBFHM; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io ------=_NextPart_000_0009_01DAB05A.CA74AC00 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I just add push label.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Hou, Wenxing =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8827=E6=97=A5 16= :24 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@ed= k2.groups.io; Kinney, Michael D ; 'Andrew Fish'= ; 'Leif Lindholm' =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; sam.kaynor@arm.com;= dougflick@microsoft.com; Mathews, John ; Li, Yi1 <= yi1.li@intel.com>; Yao, Jiewen =E4=B8=BB=E9=A2=98: RE: [edk2-devel] Soft Feature Freeze starts now for edk= 2-stable202405 =20 Hi Liming, =20 Yes. We want to merge it immediately. =20 Thanks for your support! =20 =20 Thanks, Wenxing =20 From: gaoliming = >=20 Sent: Monday, May 27, 2024 4:21 PM To: devel@edk2.groups.io ; Hou, Wenxing >; Kinney, Michael D >; 'Andrew Fish'= >; 'Leif Lindholm' > Cc: 'Ard Biesheuvel' >; sam.kayno= r@arm.com ; dougflick@microsoft.com ; Mathews, John >; Li, Yi1 >= ; Yao, Jiewen > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now fo= r edk2-stable202405 =20 Wenxing: If this patch is required to be merged immediately, I will help add push = label. =20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8=A1= =A8 Wenxing Hou =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8827=E6=97=A5 12= :24 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming >; devel@edk2.groups.io ; Kinney, Michael D >; 'Andrew Fish' >; '= Leif Lindholm' > =E6=8A=84=E9=80=81: 'Ard Biesheuvel' >; sam.kaynor@arm.com ; dougflick@microsoft= .com ; Mathews, John >; Li, Yi1 >; Yao, Jiewen > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] Soft Feature Freeze starts now for edk= 2-stable202405 =20 Hi Liming, =20 =20 Our PR: https://github.com/tianocore/edk2/pull/5645 need to be merged too. And the CryptoPkg maintainer Li Yi can not add the Push label. =20 Could you please merge this PR? =20 Thanks, Wenxing =20 =20 From: gaoliming = >=20 Sent: Tuesday, May 21, 2024 10:21 PM To: devel@edk2.groups.io ; Hou, Wenxing >; Kinney, Michael D >; 'Andrew Fish'= >; 'Leif Lindholm' > Cc: 'Ard Biesheuvel' >; sam.kayno= r@arm.com ; dougflick@microsoft.com ; Mathews, John >; Li, Yi1 >= ; Yao, Jiewen > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now fo= r edk2-stable202405 =20 Wenxing: We are in hard feature freeze phase. In this phase, only bug fixes will b= e accepted (https://github.com/tianocore/tianocore.github.io/wiki/HardFeatu= reFreeze).=20 =20 So, this patch set may be merged after the stable tag is created.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.grou= ps.io < devel@edk2.groups.io> =E4=BB=A3=E8=A1= =A8 Wenxing Hou =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8817=E6=97=A5 23= :10 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming < = gaoliming@byosoft.com.cn>; Kinney, Michael D < michael.d.kinney@intel.com>; devel@e= dk2.groups.io; 'Andrew Fish' < afish@apple.com>; '= Leif Lindholm' < quic_llindhol@quicinc.c= om> =E6=8A=84=E9=80=81: 'Ard Biesheuvel' < ardb@kernel= .org>; sam.kaynor@arm.com; dougflick@microsoft.com; Mathews, John < john.mathews@intel.com>; Li, Yi1 < y= i1.li@intel.com>; Yao, Jiewen < jiewen.yao@in= tel.com> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] Soft Feature Freeze starts now for edk= 2-stable202405 =20 Hi Liming and Mike, =20 For the PATCH: Add more crypt APIs based on Mbedtls ( https://edk2.groups.io/g/devel/message/118772), I have fixed the code based on Mike=E2=80=99s feedback and added the platform integration test table in commit message. =20 Could you approve this PATCH to catch this table tag? =20 =20 Thanks, Wenxing From: gaoliming < gaoliming@byosoft.com.c= n>=20 Sent: Wednesday, May 15, 2024 8:49 AM To: Kinney, Michael D < michael.d.kinne= y@intel.com>; devel@edk2.groups.io; 'Andrew = Fish' < afish@apple.com>; 'Leif Lindholm' < quic_llindhol@quicinc.com> Cc: 'Ard Biesheuvel' < ardb@kernel.org>; sam.kaynor@arm.com; d= ougflick@microsoft.com; Mathews, John < joh= n.mathews@intel.com>; Hou, Wenxing < wenxing= .hou@intel.com>; Li, Yi1 < yi1.li@intel.com>; Yao= , Jiewen < jiewen.yao@intel.com> Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now fo= r edk2-stable202405 =20 Mike: Thanks for your comments. I update the status below.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D < michael.d.kinney@intel.com>=20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8815=E6=97=A5 0:= 35 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming < = gaoliming@byosoft.com.cn>; devel@edk2.groups= .io; 'Andrew Fish' < afish@apple.com>; 'Leif Lindh= olm' < quic_llindhol@quicinc.com> =E6=8A=84=E9=80=81: 'Ard Biesheuvel' < ardb@kernel= .org>; sam.kaynor@arm.com; dougflick@microsoft.com; Mathews, John < john.mathews@intel.com>; Hou, Wenxing < wenxing.hou@intel.com>; Li, Yi1 < yi1.li= @intel.com>; Yao, Jiewen < jiewen.yao@intel.c= om>; Kinney, Michael D < michael.d.kinn= ey@intel.com> =E4=B8=BB=E9=A2=98: RE: [edk2-devel] Soft Feature Freeze starts now for edk= 2-stable202405 =20 Hi Liming, =20 My responses below in [Mike]. =20 Mike =20 =20 From: gaoliming < gaoliming@byosoft.com.c= n>=20 Sent: Friday, May 10, 2024 8:29 AM To: devel@edk2.groups.io; Kinney, Michael D = < michael.d.kinney@intel.com>; 'Andrew = Fish' < afish@apple.com>; 'Leif Lindholm' < quic_llindhol@quicinc.com> Cc: 'Ard Biesheuvel' < ardb@kernel.org>; sam.kaynor@arm.com; d= ougflick@microsoft.com; Mathews, John < joh= n.mathews@intel.com>; Hou, Wenxing < wenxing= .hou@intel.com> Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now fo= r edk2-stable202405 =20 Stewards: Now, there are several patches to catch this table tag. Could you give th= e comments for them? =20 1. Adding support for verbose UEFI Table dumping to Dmem.c (https://ed= k2.groups.io/g/devel/message/118582) [Liming] This patch set has been reviewed before soft feature freeze. It pl= ans to catch this stable tag.=20 =20 [Mike] I see this PR: https:= //github.com/tianocore/edk2/pull/5653 that is not passing CI and appears it= will require additional code changes =20 [Mike] Reject for edk2-stable202405 =20 2. MdePkg/BaseLib: Fix AARCH64 compilation error (https://edk2.groups.io/g= /devel/message/118690) [Liming] This bug fix is reviewed in soft feature freeze phase. It plans to= catch this stable tag.=20 =20 [Mike] Approved for edk2-stable202405 [Liming] I add push label for https://github.com/tianocore/edk2/pull/5642 =20 3. MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount ( https://edk2.groups.io/g/devel/message= /118745) [Liming] This security fix is reviewed in soft feature freeze phase. It pla= ns to catch this stable tag. =20 [Mike] Approved for edk2-stable202405 [Liming] I add push label for https://github.com/tianocore/edk2/pull/5659 =20 4. NetworkPkg: CVE-2023-45236 and CVE-2023-45237 ( https://edk2.groups.io/g/devel/message/118768) [Liming] This security fix is still under code review. It plans to catch th= is stable tag. =20 [Mike] Is the code review complete? Is there a link to the PR? [Liming] NetworkPkg reviewer will review this patch set this week.=20 =20 Thanks =20 5. Add more crypt APIs based on Mbedtls ( https://edk2.groups.io/g/devel/message/118772) [Liming] This patch set passes code review in soft feature freeze phase. It= plans to catch this stable tag. =20 [Mike] This patch series uses =E2=80=98..=E2=80=99 in INF to access source = files in another component. This is not legal. I am surprised this was no= t caught in code review. =20 DEFINE OPENSSL_PATH =3D ../OpensslLib/openssl DEFINE BASE_CRYPT_PATH =3D ../BaseCryptLib =20 [Mike] I see a reference to some =E2=80=9Cplatform integration=E2=80=9D tes= ting. Given that this patch series implements a number of crypto service APIs and is a large number of new lines of code, it would be= good to know if all of the newly added APIs=20 were tested in a platform integration. A table of the added APIs and the pl= atform integration test status would be good to=20 know if there was any functional testing of each API. If there are APIs th= at are not covered by any platform integration=20 testing, then I would be concerned with such a large change with limited te= sting. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.grou= ps.io < devel@edk2.groups.io> =E4=BB=A3=E8=A1= =A8 gaoliming via groups.io =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=887=E6=97=A5 9:2= 5 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.grou= ps.io; announce@edk2.groups.io =E6=8A=84=E9=80=81: 'Michael D Kinney' < michael.d.kinney@intel.com>; 'Andrew Fish' < afi= sh@apple.com>; 'Leif Lindholm' < quic_ll= indhol@quicinc.com> =E4=B8=BB=E9=A2=98: [edk2-devel] Soft Feature Freeze starts now for edk2-st= able202405 =20 Hi, all =20 We enter into Soft Feature Freeze phase now. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. =20 The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable ta= g, the patch contributor need reply to his patch and notify edk2 community. If the patch is sent after Soft Feature Freeze, and plans to catch this stable tag= , please add edk2-stable202405 key words in the patch title and BZ, so the community know this patch target and give the feedback. =20 To avoid the unnecessary changes to be merged in edk2 stable tag release, all edk2 maintainers' write access will be temporarily disabled until stabl= e tag is released on 05-24. That means edk2 maintainer can't set push label i= n pull request after soft feature freeze starts. =20 If the change wants to catch this stable tag 202405, please follow above rules, then send the merge request to ga= oliming@byosoft.com.cn or=20 michael.d.kinney@intel.com. =20 We will help merge the code change in soft feature freeze and hard featur= e freeze phase.=20 =20 Below is edk2-stable202405 tag planning Proposed Schedule Date (00:00:00 UTC-8) Description =20 2024-02-23 Beginning of development 2024-05-06 Soft Feature Freeze 2024-05-10 Hard Feature Freeze 2024-05-24 Release =20 Thanks Liming =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119281): https://edk2.groups.io/g/devel/message/119281 Mute This Topic: https://groups.io/mt/106327381/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0009_01DAB05A.CA74AC00 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I j= ust add push label.

 

Thanks

Limin= g

=E5=8F=91= =E4=BB=B6=E4=BA=BA: Hou, Wenxing <wenxing.hou@intel.com>
= =E5=8F=91=E9=80=81=E6=97=B6=E9= =97=B4: 2024=E5=B9=B45=E6=9C=8827=E6=97=A5 16:24
=E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming <gaoliming@byosoft.com.cn>= ;; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com&g= t;; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindho= l@quicinc.com>
=E6=8A=84=E9=80=81: 'Ard Biesheuvel' <ardb@kernel.org>; sam.kayn= or@arm.com; dougflick@microsoft.com; Mathews, John <john.mathews@intel.c= om>; Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.= com>
=E4=B8=BB=E9=A2=98: RE: [edk2-devel] Soft Feature Freeze starts now for edk2-sta= ble202405

 

Hi Liming,

 

Yes. We want t= o merge it immediately.

&n= bsp;

Thanks for your support!

 

 

Thanks,<= o:p>

Wenxing

 

From:= gaoliming <gaoliming@byosof= t.com.cn>
Sent: Monday, May 27, 2024 4:21 PM
To: devel@edk2.groups.io; Hou, We= nxing <wenxing.hou@intel.com>; Kinney, Michael D <= michael.d.kinney@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
Cc: 'Ard Biesheuvel' <ardb@kernel.org>; sam.kaynor@arm.com; dougflick@microsoft.com; Mathews,= John <john.mathews@intel.com<= /a>>; Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@= intel.com>
Subject: =E5=9B=9E= =E5=A4=8D: [edk2-devel] Soft Feature Freeze starts now for edk2-= stable202405

 <= /p>

Wenxing:

  If this patch is required to be merged immediately, I will help = add push label.  

&nb= sp;

Thanks

Liming

= =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 Wenxing Hou
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8827=E6=97=A5 12:24
=E6= =94=B6=E4=BB=B6=E4=BA=BA: = gaoliming <gaoliming@byosoft= .com.cn>; devel@edk2.groups.= io; Kinney, Michael D <michael.d.kinney@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
<= b>=E6=8A=84=E9=80=81: 'Ard= Biesheuvel' <ardb@kernel.org>= ; sam.kaynor@arm.com; dougflick@microsoft.com; Mathews, John = <john.mathews@intel.com>= ;; Li, Yi1 <yi1.li@intel.com>= ; Yao, Jiewen <jiewen.yao@intel.= com>
=E4=B8=BB=E9=A2=98:<= span lang=3DEN-US> Re: [edk2-devel] Soft Feature Freeze starts now for edk2= -stable202405

 =

Hi Liming,

 

&nb= sp;

Our PR: https://github.com/tianocore/edk2/pull/5645= need to be merged too.

And= the CryptoPkg maintainer Li Yi  can not add the Push label.

 

Could you please merge this PR?

 

Thanks,=

Wenxing

 

&n= bsp;

From: gaoliming <gaoliming@byosoft.com.cn>
Sen= t: Tuesday, May 21, 2024 10:21 PM
To: devel@edk2.groups.io; Hou, Wenxing <wenxing.hou@intel.com>; Kinney, Michael D = <michael.d.kinney@intel.co= m>; 'Andrew Fish' <afish@apple= .com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
Cc: 'Ard Biesheuvel' <ardb@kernel.org>; sam.kaynor@arm.com; dougflick@microsoft.com; Mathews, John <john.mathews@intel.com>; Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <<= a href=3D"mailto:jiewen.yao@intel.com">jiewen.yao@intel.com>
S= ubject: =E5=9B=9E=E5=A4=8D: [ed= k2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

<= span lang=3DEN-US>Wenxing:

  We are in hard feature freeze phase. In this phase, onl= y bug fixes will be accepted (https://github.com/tianocore/tianoco= re.github.io/wiki/HardFeatureFreeze).

 

So, this patch set may b= e merged after the stable tag is created.

 

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk= 2.groups.io= <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 Wenxing Hou
=E5= =8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8817=E6=97=A5 23:10
=E6=94=B6=E4=BB= =B6=E4=BA=BA: gaoliming &l= t;gaoliming@byosoft.com.cn>; Kinney, Michael D &= lt;= michael.d.kinney@intel.com>; devel@edk2.groups.io; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm= ' <quic_llindhol@quicinc.com>
=E6=8A=84=E9=80=81: 'Ard Biesheuvel' <<= /span>ardb@kernel.org>; sam.kaynor@arm.com= ; dougflick@microsoft.com; Mathews, John <john.m= athews@intel.com>; Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] Soft Feature Freeze starts= now for edk2-stable202405

 =

Hi Liming and Mike,

 

For the PATCH: Add more crypt APIs based on Mbedtls= (https= ://edk2.groups.io/g/devel/message/118772)= ,=

I have fixed the code based on Mi= ke=E2=80=99s feedback

and ad= ded the platform integration test table in commit message.

 

Could you approve this PATCH to catch this table tag?

 

 

Thanks,

Wenxing

<= span lang=3DEN-US style=3D'font-size:11.0pt;font-family:"Calibri",sans-seri= f'>From: gaoliming <gaoliming@byosoft.com.cn> =
Sent: Wednesday, May 15, 2024 8:49 AM
To: Kinney, Mich= ael D <mi= chael.d.kinney@intel.com>; devel@edk2.groups.io; 'Andrew Fish' <af= ish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
Cc: 'Ard Biesheuvel' <ardb@kernel.org&= gt;; sam.kaynor@arm.= com; dougflick@microsoft.com; Mathews, John &l= t;john.mathews@i= ntel.com>; Hou, Wenxing <wenxing.hou@intel.com= >; Li, Yi1 <= yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: =E5=9B=9E=E5=A4= =8D: [edk2-devel] Soft Feature Freeze starts now for edk2-stable= 202405

 

Mike:

  Thanks for your comments. I update the = status below.

 

Thanks=

Liming

=E5=8F=91=E4=BB=B6= =E4=BA=BA: Kinney, Michael D <mic= hael.d.kinney@intel.com>
=E5=8F=91= =E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8815=E6=97=A5 0:35
=E6=94=B6=E4=BB=B6=E4=BA= =BA: gaoliming <= gaoliming@byosoft.com.cn>; deve= l@edk2.groups.io; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <<= /span>quic_llindhol@quicinc.com>
=E6=8A=84=E9=80=81:<= span lang=3DEN-US style=3D'font-size:11.0pt'> 'Ard Biesheuvel' <<= span lang=3DEN-US>ardb@kernel.org>; sam.kaynor@arm.com; dougflick@microsoft.com; Mathews, John <john.mathews@= intel.com&g= t;; Hou, Wenxing <wenxing.hou@intel.com<= /a>>; Li, Yi1 <<= /span>yi1.li@intel.com>; Yao, Jiewen <jiewe= n.yao@intel.com>; Kinney, Michael D <michael.d.kin= ney@intel.com>
=E4=B8=BB=E9=A2=98: RE: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405=

 

Hi Liming,

 

My responses bel= ow in [Mike].

 

Mike

 

 

=

From:<= /span> gaoliming <gaoliming@byosoft.com.cn>
Se= nt: Friday, May 10, 2024 8:29 AM
To: devel@edk2.groups.io= ; Kinney, Michael D <michael.d.kinney@intel.com>; 'Andrew F= ish' <afish@apple.co= m>; 'Leif Lindholm' <= quic_llindhol@quicinc.com>
Cc: 'Ard Biesheuvel' <<= a href=3D"mailto:ardb@kernel.org">ardb@kernel.org>; = sam.kaynor@arm.com; = dougflick@microsoft.com; Mathews, John <john.mathews@intel.com>; Hou, Wenxing <wenxing.hou@intel.com>Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] Soft Feature Free= ze starts now for edk2-stable202405

 

Stewards:=

  Now, t= here are several patches to catch this table tag. Could you give the commen= ts for them?

<= o:p> 

1.      Adding supp= ort for verbose UEFI Table dumping to Dmem.c (https://edk2.groups.io/g/devel/message/118582)

[Liming] This patch = set has been reviewed before soft feature freeze. It plans to catch this st= able tag.

&nbs= p;

[Mike] I see this PR: https://github.com/tianocor= e/edk2/pull/5653 that is not passing CI a= nd appears it will require additional code changes

 <= /span>

[Mik= e] Reject for edk2-stable202405

 

2.  MdePkg/BaseLib: Fix AARCH64 c= ompilation error (https://edk2.groups.io/g= /devel/message/118690)

[Li= ming] This bug fix is reviewed in soft feature freeze phase. It plans to ca= tch this stable tag.

&nbs= p;

[Mike] Approved fo= r edk2-stable202405

[Liming] I add push label for = https://github.com/tianocore/edk2/pull/5642<= span lang=3DEN-US style=3D'font-size:11.0pt;font-family:"Calibri",sans-seri= f'>

 

3.&nbs= p; MdeModulePkg: Potential UINT32 overflow in S3 ResumeCo= unt (ht= tps://edk2.groups.io/g/devel/message/118745)

[Liming] This security fix is reviewed in soft fe= ature freeze phase. It plans to catch this stable tag.

 

[Mike] Approved for edk2-stable202405<= span lang=3DEN-US style=3D'font-size:11.0pt;font-family:"Calibri",sans-seri= f'>

[Liming] I add push label for https://github.com/tianocore/edk2/pull/5659

 

4.&n= bsp; NetworkPkg: CVE-2023-45236 and CVE-2023-45237 (https://edk2= .groups.io/g/devel/message/118768)

[Liming] This security fix is still under code review. It = plans to catch this stable tag.=

 

[Mike]= Is the code review complete?  Is there a link to the PR?

[Liming] NetworkPkg reviewer will review this patch set this week.

 

Thanks

 

5.  Add more crypt APIs based on Mbedtls (https://ed= k2.groups.io/g/devel/message/118772)

[Liming] This patch set passes code review in soft featur= e freeze phase. It plans to catch this stable tag.

 <= /o:p>

[Mike] This patch series uses =E2= =80=98..=E2=80=99 in INF to access source files in another component. = This is not legal.  I am surprised this was not caught in code review= .

 

= DEFINE OPENSSL_PATH         &n= bsp;  =3D ../OpensslLib/openssl

DEFINE BASE_CRYPT_P= ATH         =3D ../BaseCryptLib

 

[Mike] I see a reference to some =E2=80=9Cplatform int= egration=E2=80=9D testing.  Given that this patch series implements a = number of

crypto service APIs= and is a large number of new lines of code, it would be good to know if al= l of the newly added APIs

we= re tested in a platform integration. A table of the added APIs and the plat= form integration test status would be good to

know if there was any functional testing of each API.&nbs= p; If there are APIs that are not covered by any platform integration =

testing, then I would be concerne= d with such a large change with limited testing.

 

Thanks

Liming

=E5= =8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups= .io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 gaoliming via groups.io
= =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:<= span lang=3DEN-US style=3D'font-size:11.0pt'> 2024=E5=B9=B45=E6=9C=887=E6=97=A5 9:25
=E6=94=B6=E4=BB= =B6=E4=BA=BA: devel@edk2.groups.io; announce@edk2.grou= ps.io
=E6=8A=84=E9=80=81: 'Micha= el D Kinney' <michael.d.kinney@intel.com>; 'Andrew= Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>
=E4=B8=BB=E9=A2=98: [edk2-devel] Soft Feature Freeze starts n= ow for edk2-stable202405

 

Hi, all

=  

  We enter into Soft Feature Freeze phase now.= In this phase,

the feature under review will= not be allowed to be pushed. The feature

pas= sed review can still be merged.

=  

  The patch review can continue without break = in edk2 community. If the

patch is sent bef= ore Soft Feature Freeze, and plans to catch this stable tag, the=

patch contributor need reply to his patch and notify ed= k2 community. If the

patch is sent after Sof= t Feature Freeze, and plans to catch this stable tag,

=

please add edk2-stable202405 key words in the patch title and BZ, = so the

community know this patch target and = give the feedback.

 

  To avoid the unnecessary changes to be merged in edk2 sta= ble tag release,

all edk2 maintainers' write = access will be temporarily disabled until stable

tag is released on 05-24. That means edk2 maintainer can't set push lab= el in

pull request after soft feature freez= e starts.

 

  If the change wants to catch this stable tag 202405, please follow= above

rules, then send the merge request to= gaoliming@byosoft.co= m.cn or

michael.d.kinney@intel.com.=

 

  We will he= lp merge the code change in soft feature freeze and hard feature=

freeze phase.

 = ;

Below is edk2-stable202405 tag planning Proposed= Schedule

Date (00:00:00 UTC-8) Description

 

2024-02-2= 3 Beginning of development

2024-05-06 Soft F= eature Freeze

2024-05-10 Hard Feature Freeze=

2024-05-24 Release

 

Thanks

Liming

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119281) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_0009_01DAB05A.CA74AC00--