From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.2016.1613618007758105980 for ; Wed, 17 Feb 2021 19:13:29 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 18 Feb 2021 11:13:19 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Sami Mujawar'" , "'Ilias Apalodimas'" , "'Ard Biesheuvel'" References: <20210217112717.6820-1-sughosh.ganu@linaro.org> <20210217112717.6820-14-sughosh.ganu@linaro.org> In-Reply-To: <20210217112717.6820-14-sughosh.ganu@linaro.org> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY0IDEzLzE0XSBNZGVNb2R1bGVQa2cvVmFyaWFibGVTdGFuZGFsb25lTW06IFNldCBQY2RGbGFzaE52U3RvcmFnZVZhcmlhYmxlQmFzZSB0byBQY2Q=?= Date: Thu, 18 Feb 2021 11:13:21 +0800 Message-ID: <000901d705a4$02f958b0$08ec0a10$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJVIfExuDv3PmCFJgwN2KPvYcE1hwHNtfuYqVKUQiA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn I suggest to directly change [FixedPcd] to [Pcd] section. All Pcds can support FixedAtBuild and PatchableInModule.=20 With this change, Reviewed-by: Liming Gao Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+71734+4905953+8761045@groups.io > =B4=FA=B1=ED Sughosh Ganu > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA2=D4=C217=C8=D5 19:27 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Sami Mujawar ; Ilias Apalodimas > ; Ard Biesheuvel > =D6=F7=CC=E2: [edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandal= oneMm: > Set PcdFlashNvStorageVariableBase to Pcd >=20 > From: Ilias Apalodimas >=20 > Instead of running StMM in SPM, OP-TEE creates a new secure partition, > which emulates SPM and isolates StMM from the rest of the Trusted > Applications (TAs). We can then compile StMM as an FD image and run it > in OP-TEE. With the addition of a new RPMB driver, we can leverage OP-TE= E > and store variables to an RPMB device. >=20 > Since EDK2 upper layers expect byte addressable code, for the RPMB to > work, we need to allocate memory and sync it with the hardware on > read/writes. Since DynamicPCDs are not supported in that context we > can only use PatchablePCDs. So let's switch them to Pcd instead of > FixedPcd and accomodate the new driver. >=20 > Signed-off-by: Ilias Apalodimas > Reviewed-by: Sami Mujawar > --- >=20 > Changes since V3: None >=20 > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.in > f > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.in > f > index fada0bf3c5..2a25fbdada 100644 > --- > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.in > f > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.in > f > @@ -119,10 +119,12 @@ > ## SOMETIMES_PRODUCES ## Variable:L"VarErrorFlag" > gEdkiiVarErrorFlagGuid >=20 > -[FixedPcd] > - gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > ## CONSUMES > +[Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase > ## SOMETIMES_CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 > ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > ## CONSUMES > + > +[FixedPcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize > ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize > ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize > ## CONSUMES > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20