From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Sami Mujawar'" <sami.mujawar@arm.com>, <devel@edk2.groups.io>
Cc: <ardb+tianocore@kernel.org>, <leif@nuviainc.com>,
<rebecca@bsdio.com>, <kraxel@redhat.com>,
<michael.d.kinney@intel.com>, <zhiguang.liu@intel.com>,
<jiewen.yao@intel.com>, <jian.j.wang@intel.com>,
<Matteo.Carlini@arm.com>, <Akanksha.Jain2@arm.com>,
<Ben.Adderson@arm.com>, <nd@arm.com>
Subject: 回复: [PATCH v1 0/9] Add Raw algorithm support using Arm FW-TRNG interface
Date: Fri, 8 Oct 2021 13:35:19 +0800 [thread overview]
Message-ID: <000901d7bc06$48708bc0$d951a340$@byosoft.com.cn> (raw)
In-Reply-To: <20210930154044.37336-1-sami.mujawar@arm.com>
Sami:
Here is my comments for this patch set.
1. MdeModulePkg\Include\Guid\ZeroGuid.h has defined gZeroGuid. You don't
define it again.
2. MdePkg\Include\Library\TrngLib.h is base type library. It can use
RETURN_STATUS instead of EFI_STATUS. Then, it doesn't need to include
<Uefi/UefiBaseType.h>
3. MdePkg\Include\Library\TrngLib.h API parameter doesn't require CONST.
CONST means the value specified by the input pointer will not be changed in
API implementation.
Thanks
Liming
> -----邮件原件-----
> 发件人: Sami Mujawar <sami.mujawar@arm.com>
> 发送时间: 2021年9月30日 23:41
> 收件人: devel@edk2.groups.io
> 抄送: Sami Mujawar <sami.mujawar@arm.com>; ardb+tianocore@kernel.org;
> leif@nuviainc.com; rebecca@bsdio.com; kraxel@redhat.com;
> michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; jiewen.yao@intel.com; jian.j.wang@intel.com;
> Matteo.Carlini@arm.com; Akanksha.Jain2@arm.com;
> Ben.Adderson@arm.com; nd@arm.com
> 主题: [PATCH v1 0/9] Add Raw algorithm support using Arm FW-TRNG
> interface
>
> Bugzilla: Bug 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
>
> The Arm True Random Number Generator Firmware, Interface 1.0,
> specification
> defines an interface between an Operating System (OS) executing at EL1 and
> Firmware (FW) exposing a conditioned entropy source that is provided by a
> TRNG back end.
>
> This patch series:
> - defines a TRNG library class that provides an interface to access the
> entropy source on a platform.
> - implements a TRNG library instance that uses the Arm FW-TRNG interface.
> - Adds RawAlgorithm support to RngDxe for Arm architecture using the Arm
> FW-TRNG interface.
> - Enables RNG support using FW-TRNG interface for Kvmtool Guest/Virtual
> firmware.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1829_arm_fw_trng_v1
>
> Sami Mujawar (9):
> MdePkg: Definition for TRNG library class interface
> ArmPkg: PCD to select conduit for monitor calls
> ArmPkg: Add Arm Firmware TRNG library
> MdePkg: Add definition for NULL GUID
> MdePkg: Add NULL instance of TRNG Library
> SecurityPkg: Rename RdRandGenerateEntropy to common name
> SecurityPkg: Restructure checks in RngGetInfo
> SecurityPkg: Add RawAlgorithm support using TRNG library
> ArmVirtPkg: Kvmtool: Add RNG support using FW-TRNG interface
>
> ArmPkg/ArmPkg.dec |
> 5 +
> ArmPkg/ArmPkg.dsc |
> 1 +
> ArmPkg/Library/ArmFwTrngLib/ArmFwTrngDefs.h | 64
> +++
> ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.c | 483
> ++++++++++++++++++++
> ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.inf | 34
> ++
> ArmVirtPkg/ArmVirtKvmTool.dsc | 10
> +
> ArmVirtPkg/ArmVirtKvmTool.fdf | 5
> +
> MdePkg/Include/Guid/NullGuid.h | 21
> +
> MdePkg/Include/Library/TrngLib.h | 123
> +++++
> MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.c | 111
> +++++
> MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.inf | 30 ++
> MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.uni | 12 +
> MdePkg/MdePkg.dec |
> 13 +-
> MdePkg/MdePkg.dsc |
> 1 +
> SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 79
> +++-
> SecurityPkg/RandomNumberGenerator/RngDxe/Arm/RngDxe.c | 164
> +++++++
> SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c | 61
> +++
> SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.c |
> 13 +-
> SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.h |
> 43 --
> SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c | 12
> +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 13
> +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf | 13
> +-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h | 22 +-
> SecurityPkg/SecurityPkg.dsc | 12
> +-
> 24 files changed, 1272 insertions(+), 73 deletions(-)
> create mode 100644 ArmPkg/Library/ArmFwTrngLib/ArmFwTrngDefs.h
> create mode 100644 ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.c
> create mode 100644 ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.inf
> create mode 100644 MdePkg/Include/Guid/NullGuid.h
> create mode 100644 MdePkg/Include/Library/TrngLib.h
> create mode 100644 MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.c
> create mode 100644 MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.inf
> create mode 100644 MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.uni
> create mode 100644
> SecurityPkg/RandomNumberGenerator/RngDxe/Arm/RngDxe.c
> create mode 100644
> SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c
> delete mode 100644
> SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.h
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
prev parent reply other threads:[~2021-10-08 5:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 15:40 [PATCH v1 0/9] Add Raw algorithm support using Arm FW-TRNG interface Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 1/9] MdePkg: Definition for TRNG library class interface Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 2/9] ArmPkg: PCD to select conduit for monitor calls Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 3/9] ArmPkg: Add Arm Firmware TRNG library Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 4/9] MdePkg: Add definition for NULL GUID Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 5/9] MdePkg: Add NULL instance of TRNG Library Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 6/9] SecurityPkg: Rename RdRandGenerateEntropy to common name Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 7/9] SecurityPkg: Restructure checks in RngGetInfo Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 8/9] SecurityPkg: Add RawAlgorithm support using TRNG library Sami Mujawar
2021-09-30 15:40 ` [PATCH v1 9/9] ArmVirtPkg: Kvmtool: Add RNG support using FW-TRNG interface Sami Mujawar
2021-10-01 17:47 ` [edk2-devel] " Joey Gouly
2021-10-08 5:35 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000901d7bc06$48708bc0$d951a340$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox