From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.5157.1633671519999483045 for ; Thu, 07 Oct 2021 22:38:41 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 08 Oct 2021 13:35:17 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Sami Mujawar'" , Cc: , , , , , , , , , , , References: <20210930154044.37336-1-sami.mujawar@arm.com> In-Reply-To: <20210930154044.37336-1-sami.mujawar@arm.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjEgMC85XSBBZGQgUmF3IGFsZ29yaXRobSBzdXBwb3J0IHVzaW5nIEFybSBGVy1UUk5HIGludGVyZmFjZQ==?= Date: Fri, 8 Oct 2021 13:35:19 +0800 Message-ID: <000901d7bc06$48708bc0$d951a340$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGOqG09xStL7fFbCJDKhSMDK6rIvaxat9Hw Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Sami: Here is my comments for this patch set.=20 1. MdeModulePkg\Include\Guid\ZeroGuid.h has defined gZeroGuid. You don't define it again.=20 2. MdePkg\Include\Library\TrngLib.h is base type library. It can use RETURN_STATUS instead of EFI_STATUS. Then, it doesn't need to include 3. MdePkg\Include\Library\TrngLib.h API parameter doesn't require CONST. CONST means the value specified by the input pointer will not be changed = in API implementation.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Sami Mujawar > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA9=D4=C230=C8=D5 23:41 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Sami Mujawar ; = ardb+tianocore@kernel.org; > leif@nuviainc.com; rebecca@bsdio.com; kraxel@redhat.com; > michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > Matteo.Carlini@arm.com; Akanksha.Jain2@arm.com; > Ben.Adderson@arm.com; nd@arm.com > =D6=F7=CC=E2: [PATCH v1 0/9] Add Raw algorithm support using Arm = FW-TRNG > interface >=20 > Bugzilla: Bug 3668 = (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3668) >=20 > The Arm True Random Number Generator Firmware, Interface 1.0, > specification > defines an interface between an Operating System (OS) executing at EL1 = and > Firmware (FW) exposing a conditioned entropy source that is provided = by a > TRNG back end. >=20 > This patch series: > - defines a TRNG library class that provides an interface to access = the > entropy source on a platform. > - implements a TRNG library instance that uses the Arm FW-TRNG = interface. > - Adds RawAlgorithm support to RngDxe for Arm architecture using the = Arm > FW-TRNG interface. > - Enables RNG support using FW-TRNG interface for Kvmtool = Guest/Virtual > firmware. >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/1829_arm_fw_trng_v1 >=20 > Sami Mujawar (9): > MdePkg: Definition for TRNG library class interface > ArmPkg: PCD to select conduit for monitor calls > ArmPkg: Add Arm Firmware TRNG library > MdePkg: Add definition for NULL GUID > MdePkg: Add NULL instance of TRNG Library > SecurityPkg: Rename RdRandGenerateEntropy to common name > SecurityPkg: Restructure checks in RngGetInfo > SecurityPkg: Add RawAlgorithm support using TRNG library > ArmVirtPkg: Kvmtool: Add RNG support using FW-TRNG interface >=20 > ArmPkg/ArmPkg.dec | > 5 + > ArmPkg/ArmPkg.dsc | > 1 + > ArmPkg/Library/ArmFwTrngLib/ArmFwTrngDefs.h | 64 > +++ > ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.c | 483 > ++++++++++++++++++++ > ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.inf | 34 > ++ > ArmVirtPkg/ArmVirtKvmTool.dsc | 10 > + > ArmVirtPkg/ArmVirtKvmTool.fdf | 5 > + > MdePkg/Include/Guid/NullGuid.h | 21 > + > MdePkg/Include/Library/TrngLib.h | 123 > +++++ > MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.c | 111 > +++++ > MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.inf | 30 ++ > MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.uni | 12 + > MdePkg/MdePkg.dec | > 13 +- > MdePkg/MdePkg.dsc | > 1 + > SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 79 > +++- > SecurityPkg/RandomNumberGenerator/RngDxe/Arm/RngDxe.c | 164 > +++++++ > SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c | 61 > +++ > SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.c | > 13 +- > SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.h | > 43 -- > SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c | 12 > +- > SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 13 > +- > SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf | 13 > +- > SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h | 22 +- > SecurityPkg/SecurityPkg.dsc | 12 > +- > 24 files changed, 1272 insertions(+), 73 deletions(-) > create mode 100644 ArmPkg/Library/ArmFwTrngLib/ArmFwTrngDefs.h > create mode 100644 ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.c > create mode 100644 ArmPkg/Library/ArmFwTrngLib/ArmFwTrngLib.inf > create mode 100644 MdePkg/Include/Guid/NullGuid.h > create mode 100644 MdePkg/Include/Library/TrngLib.h > create mode 100644 MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.c > create mode 100644 MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.inf > create mode 100644 MdePkg/Library/BaseTrngLibNull/BaseTrngLibNull.uni > create mode 100644 > SecurityPkg/RandomNumberGenerator/RngDxe/Arm/RngDxe.c > create mode 100644 > SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c > delete mode 100644 > SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RdRand.h >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'