回复: [edk2-devel] 回复: [PATCH V4 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

["gaoliming" <gaoliming@byosoft.com.cn>]

Min:

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Min Xu
> 发送时间: 2021年11月4日 20:35
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, Ken <ken.lu@intel.com>; 'Sami Mujawar'
> <sami.mujawar@arm.com>; 'Gerd Hoffmann' <kraxel@redhat.com>
> 主题: Re: [edk2-devel] 回复: [PATCH V4 1/3] MdePkg: Introduce
> CcMeasurementProtocol for CC Guest firmware
> 
> On November 4, 2021 1:51 PM, Gao, Liming wrote:
> > Min:
> >   I have one minor comment. gEfiCcFinalEventsTableGuid may be placed
> into
> > [Guids] section instead of [Protocols] section.
> >
> Hi, Liming
> I follow the definition of gEfiTcg2ProtocolGuid and
> gEfiTcg2FinalEventsTableGuid. See
> https://github.com/tianocore/edk2/blob/master/MdePkg/MdePkg.dec#L159
> 0-L1592
> Actually gEfiCcMeasurementProtocolGuid and gEfiCcFinalEventsTableGuid are
> the counterpart protocol/guid definition in Confidential Computing measure
> boot.
> I am not sure if there is some other consideration that
gEfiTcg2ProtocolGuid
> and gEfiTcg2FinalEventsTableGuid are defined in the section of
[Protocols].
I find gEfiTcg2FinalEventsTableGuid is used for configuration table. This is
one Guid usage. 
It should be placed into [Guids] section. 

You can see hash protocol and hash algorithm guid in MdePkg. 
gEfiHashProtocolGuid is defined in [Protocols] section, and
gEfiHashAlgorithmMD5Guid
is defined in [Guids] section. They are both from
MdePkg/Include/Protocol/Hash.h.

So, I suggest to follow the guid usage to define this Guid into the
different section.

Thanks
Liming
> 
> Thanks
> Min
> 
> 
> 
>