public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <brian.johnson@hpe.com>, <kraxel@redhat.com>
Cc: "'Alexey Kardashevskiy'" <aik@ozlabs.ru>,
	"'Erdem Aktas'" <erdemaktas@google.com>,
	"'Pawel Polawski'" <ppolawsk@redhat.com>,
	"'Jordan Justen'" <jordan.l.justen@intel.com>,
	"'Ard Biesheuvel'" <ardb+tianocore@kernel.org>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>,
	"'Tom Lendacky'" <thomas.lendacky@amd.com>,
	"'James Bottomley'" <jejb@linux.ibm.com>,
	"'Oliver Steffen'" <osteffen@redhat.com>,
	"'Jiewen Yao'" <jiewen.yao@intel.com>,
	"'Min Xu'" <min.m.xu@intel.com>,
	"'Brijesh Singh'" <brijesh.singh@amd.com>,
	"'Bob Feng'" <bob.c.feng@intel.com>
Subject: 回复: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
Date: Wed, 7 Dec 2022 09:36:21 +0800	[thread overview]
Message-ID: <000901d909dc$4f608140$ee2183c0$@byosoft.com.cn> (raw)
In-Reply-To: <50495e6e-a8cf-44de-6ffe-42b6c7c8972d@hpe.com>

Gerd:
  I have no comments for this change. Acked-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brian J.
> Johnson
> 发送时间: 2022年12月2日 0:18
> 收件人: devel@edk2.groups.io; kraxel@redhat.com
> 抄送: Alexey Kardashevskiy <aik@ozlabs.ru>; Liming Gao
> <gaoliming@byosoft.com.cn>; Erdem Aktas <erdemaktas@google.com>;
> Pawel Polawski <ppolawsk@redhat.com>; Jordan Justen
> <jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Yuwei Chen <yuwei.chen@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; James Bottomley <jejb@linux.ibm.com>;
> Oliver Steffen <osteffen@redhat.com>; Jiewen Yao <jiewen.yao@intel.com>;
> Min Xu <min.m.xu@intel.com>; Brijesh Singh <brijesh.singh@amd.com>; Bob
> Feng <bob.c.feng@intel.com>
> 主题: Re: [edk2-devel] [PATCH v7 2/2] tools_def: add
> -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
> 
> OK.  Doesn't look like a big impact.
> 
> Thanks,
> Brian J. Johnson
> -------- Original Message --------
> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> Sent: Thursday, December 1, 2022 at 2:38 AM
> To: Brian J. Johnson <brian.johnson@hpe.com>
> Cc: devel@edk2.groups.io, Alexey Kardashevskiy <aik@ozlabs.ru>, Liming
> Gao <gaoliming@byosoft.com.cn>, Erdem Aktas <erdemaktas@google.com>,
> Pawel Polawski <ppolawsk@redhat.com>, Jordan Justen
> <jordan.l.justen@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>,
> Yuwei Chen <yuwei.chen@intel.com>, Tom Lendacky
> <thomas.lendacky@amd.com>, James Bottomley <jejb@linux.ibm.com>,
> Oliver
> Steffen <osteffen@redhat.com>, Jiewen Yao <jiewen.yao@intel.com>, Min Xu
> <min.m.xu@intel.com>, Brijesh Singh <brijesh.singh@amd.com>, Bob Feng
> <bob.c.feng@intel.com>
> Subject: [edk2-devel] [PATCH v7 2/2] tools_def: add
> -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
> 
> On Wed, Nov 30, 2022 at 01:28:42PM -0600, Brian J. Johnson wrote:
> > Gerd,
> >
> > Sorry, gotta ask:  does this make much difference in the size of the
> > compiled code?  That's a constraint on many real-hardware X64 platforms,
> > especially for 32-bit code.
> 
> Quick test with OvmfPkg/OvmfPkgIa32X64.dsc (sec/pei ia32, dxe x64):
> 
> master branch:
> 
> FV Space Information
> SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264
> (0x2e350) free
> PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088
> (0x92048) free
> DXEFV [49%Full] 12582912 (0xc00000) total, 6268032 (0x5fa480) used,
> 6314880 (0x605b80) free
> FVMAIN_COMPACT [98%Full] 1753088 (0x1ac000) total, 1725328 (0x1a5390)
> used, 27760 (0x6c70) free
> 
> with patch applied:
> 
> FV Space Information
> SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264
> (0x2e350) free
> PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088
> (0x92048) free
> DXEFV [50%Full] 12582912 (0xc00000) total, 6335936 (0x60adc0) used,
> 6246976 (0x5f5240) free
> FVMAIN_COMPACT [99%Full] 1753088 (0x1ac000) total, 1738176 (0x1a85c0)
> used, 14912 (0x3a40) free
> 
> So slightly more for 64-bit code.
> 
> take care,
>     Gerd
> 
> 
> 
> 
> 
> 
> 
> 
> 




  reply	other threads:[~2022-12-07  1:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  9:44 [PATCH v7 0/2] Fix stack switching Gerd Hoffmann
2022-11-30  9:44 ` [PATCH v7 1/2] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS Gerd Hoffmann
2022-12-07  1:34   ` 回复: [edk2-devel] " gaoliming
2022-11-30  9:44 ` [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS Gerd Hoffmann
2022-11-30 19:28   ` [edk2-devel] " Brian J. Johnson
2022-12-01  8:38     ` Gerd Hoffmann
2022-12-01 16:17       ` Brian J. Johnson
2022-12-07  1:36         ` gaoliming [this message]
     [not found]         ` <172E5F05A68BEFC2.5063@groups.io>
2022-12-21  1:29           ` 回复: " gaoliming
2022-12-21  6:26             ` Gerd Hoffmann
2022-12-22  0:44               ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000901d909dc$4f608140$ee2183c0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox