From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ED29D740032 for ; Thu, 9 Nov 2023 14:20:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hNLz0m5/d1z0aV6tRT0IZ4JLU2HPE6ENFJAWP5IsCOw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1699539643; v=1; b=V1sqnN+6JrEOwMq2Vhlpp1IJHxcvRCt4CjfBXWH1XlN6wm+n63Q08HGa5BG1sK/U0NbdIPIb JLo0rzdpvf9oAUQTpQpjmYIk2Fwqqctz24qeGFwII9bubMBOQQ8t7+tdes7cesd1tWeoJ3QxnYl gip5zYFaAz30dRzcegRYzHQ0= X-Received: by 127.0.0.2 with SMTP id jIa6YY7687511xh8LlGT3zBH; Thu, 09 Nov 2023 06:20:43 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.122542.1699539627551024651 for ; Thu, 09 Nov 2023 06:20:43 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id C8E51A32E07C for ; Thu, 9 Nov 2023 22:20:18 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id B48AFA32E002 for ; Thu, 9 Nov 2023 22:20:18 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id D0B49A32E0FF for ; Thu, 9 Nov 2023 22:20:15 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([124.133.49.51]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 09 Nov 2023 22:20:09 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 124.133.49.51 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Chang, Abner'" , Cc: "'Nate DeSimone'" , "'Chasel Chiu'" , "'Li-Xia Huang'" , "'Attar, AbdulLateef \(Abdul Lateef\)'" , "'Nickle Wang'" References: <1792D0690F720C15.7262@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItcGxhdGZvcm1zXVtQQVRDSF0gRmVhdHVyZXMvSXBtaUZlYXR1cmVQa2c6IFJlbW92ZSBJcG1pQ29tbWFuZExpYiBmcm9tIElwbWlGZWF0dXJlUGtn?= Date: Thu, 9 Nov 2023 22:20:12 +0800 Message-ID: <000901da1317$da626cf0$8f2746d0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQGfb+k3JjOgiTyt4ru6+r8YRxHBfQJpAT4CsNQHvrA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1XpRofuJtGc4XyhjuAQRH2nnx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=V1sqnN+6; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Abner: I agree this change. Reviewed-by: Liming Gao Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Chang, Abner > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA11=D4=C28=C8=D5 11:22 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Nate DeSimone ; Liming Gao > ; Chasel Chiu ; Li-Xia > Huang ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang > =D6=F7=CC=E2: RE: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeatu= rePkg: > Remove IpmiCommandLib from IpmiFeaturePkg >=20 > [AMD Official Use Only - General] >=20 > Hi Nate and Liming, > Please check this patch. The one under IpmiFeaturePkg is an old one, we > should remove it to avoid the confusions. >=20 > Thanks > Abner >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Monday, October 30, 2023 2:59 PM > > To: devel@edk2.groups.io > > Cc: Nate DeSimone ; Liming Gao > > ; Chasel Chiu ; Li-Xia > > Huang ; Attar, AbdulLateef (Abdul Lateef) > > ; Nickle Wang > > Subject: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: > > Remove IpmiCommandLib from IpmiFeaturePkg > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > From: Abner Chang > > > > Remove IpmiCommandLib from IpmiFeaturePkg as ManageabilityPkg > > already had one and is newer. > > > > Signed-off-by: Abner Chang > > Cc: Nate DeSimone > > Cc: Liming Gao > > Cc: Chasel Chiu > > Cc: Li-Xia Huang > > Cc: Abdul Lateef Attar > > Cc: Nickle Wang > > --- > > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 4 - > > .../IpmiFeaturePkg/Include/IpmiFeature.dsc | 2 +- > > .../Library/IpmiCommandLib/IpmiCommandLib.inf | 32 -- > > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 335 > ------------------ > > .../IpmiCommandLibNetFnChassis.c | 144 -------- > > .../IpmiCommandLibNetFnStorage.c | 274 -------------- > > .../IpmiCommandLibNetFnTransport.c | 123 ------- > > 7 files changed, 1 insertion(+), 913 deletions(-) > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > > ndLib/IpmiCommandLib.inf > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > > ndLib/IpmiCommandLibNetFnApp.c > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > > ndLib/IpmiCommandLibNetFnChassis.c > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > > ndLib/IpmiCommandLibNetFnStorage.c > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > > ndLib/IpmiCommandLibNetFnTransport.c > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > index 5df71300cb..f26741e244 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > @@ -32,10 +32,6 @@ > > OsWdt > > > > [LibraryClasses] > > - ## @libraryclass Provides services to send IPMI commands. > > - # > > - IpmiCommandLib|Include/Library/IpmiCommandLib.inf > > - > > ## @libraryclass Provides an API for platform-specific IPMI hooks. > > # > > IpmiCommandLib|Include/Library/IpmiPlatformHookLib.h > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > > ure.dsc > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > > ure.dsc > > index 0401974b82..063638ce56 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > > ure.dsc > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > > ure.dsc > > @@ -37,7 +37,7 @@ > > [LibraryClasses] > > IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf > > > > - > > > IpmiCommandLib|IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommand > > Lib.inf > > + > > > IpmiCommandLib|ManageabilityPkg/Library/IpmiCommandLib/IpmiComman > > dLib.inf > > > > > IpmiPlatformHookLib|IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/Ipmi > > PlatformHookLibNull.inf > > > > [LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLib.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLib.inf > > deleted file mode 100644 > > index d5c14ff2a4..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLib.inf > > +++ /dev/null > > @@ -1,32 +0,0 @@ > > -### @file > > -# Component description file for IPMI Command Library. > > -# > > -# Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> > -# > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > -# > > -### > > - > > -[Defines] > > - INF_VERSION =3D 0x00010005 > > - BASE_NAME =3D IpmiCommandLib > > - FILE_GUID =3D > E599C9C7-5913-40A0-8669-67282E2BEC53 > > - MODULE_TYPE =3D UEFI_DRIVER > > - VERSION_STRING =3D 1.0 > > - LIBRARY_CLASS =3D IpmiCommandLib > > - > > -[sources] > > - IpmiCommandLibNetFnApp.c > > - IpmiCommandLibNetFnTransport.c > > - IpmiCommandLibNetFnChassis.c > > - IpmiCommandLibNetFnStorage.c > > - > > -[Packages] > > - MdePkg/MdePkg.dec > > - MdeModulePkg/MdeModulePkg.dec > > - IpmiFeaturePkg/IpmiFeaturePkg.dec > > - > > -[LibraryClasses] > > - BaseMemoryLib > > - DebugLib > > - IpmiBaseLib > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnApp.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnApp.c > > deleted file mode 100644 > > index 2e34909f3e..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnApp.c > > +++ /dev/null > > @@ -1,335 +0,0 @@ > > -/** @file > > - IPMI Command - NetFnApp. > > - > > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> > - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > reserved.
> > - > > - SPDX-License-Identifier: BSD-2-Clause-Patent > > -**/ > > - > > -#include > > -#include > > -#include > > -#include > > - > > -#include > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetDeviceId ( > > - OUT IPMI_GET_DEVICE_ID_RESPONSE *DeviceId > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*DeviceId); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_DEVICE_ID, > > - NULL, > > - 0, > > - (VOID *)DeviceId, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelfTestResult ( > > - OUT IPMI_SELF_TEST_RESULT_RESPONSE *SelfTestResult > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*SelfTestResult); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_SELFTEST_RESULTS, > > - NULL, > > - 0, > > - (VOID *)SelfTestResult, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiResetWatchdogTimer ( > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_RESET_WATCHDOG_TIMER, > > - NULL, > > - 0, > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetWatchdogTimer ( > > - IN IPMI_SET_WATCHDOG_TIMER_REQUEST *SetWatchdogTimer, > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_SET_WATCHDOG_TIMER, > > - (VOID *)SetWatchdogTimer, > > - sizeof(*SetWatchdogTimer), > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetWatchdogTimer ( > > - OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE *GetWatchdogTimer > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetWatchdogTimer); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_WATCHDOG_TIMER, > > - NULL, > > - 0, > > - (VOID *)GetWatchdogTimer, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetBmcGlobalEnables ( > > - IN IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST > *SetBmcGlobalEnables, > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_SET_BMC_GLOBAL_ENABLES, > > - (VOID *)SetBmcGlobalEnables, > > - sizeof(*SetBmcGlobalEnables), > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetBmcGlobalEnables ( > > - OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE > *GetBmcGlobalEnables > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetBmcGlobalEnables); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_BMC_GLOBAL_ENABLES, > > - NULL, > > - 0, > > - (VOID *)GetBmcGlobalEnables, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiClearMessageFlags ( > > - IN IPMI_CLEAR_MESSAGE_FLAGS_REQUEST > *ClearMessageFlagsRequest, > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_CLEAR_MESSAGE_FLAGS, > > - (VOID *)ClearMessageFlagsRequest, > > - sizeof(*ClearMessageFlagsRequest), > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetMessageFlags ( > > - OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE > *GetMessageFlagsResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetMessageFlagsResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_MESSAGE_FLAGS, > > - NULL, > > - 0, > > - (VOID *)GetMessageFlagsResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetMessage ( > > - OUT IPMI_GET_MESSAGE_RESPONSE *GetMessageResponse, > > - IN OUT UINT32 *GetMessageResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_MESSAGE, > > - NULL, > > - 0, > > - (VOID *)GetMessageResponse, > > - GetMessageResponseSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSendMessage ( > > - IN IPMI_SEND_MESSAGE_REQUEST *SendMessageRequest, > > - IN UINT32 SendMessageRequestSize, > > - OUT IPMI_SEND_MESSAGE_RESPONSE *SendMessageResponse, > > - IN OUT UINT32 *SendMessageResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_SEND_MESSAGE, > > - (VOID *)SendMessageRequest, > > - SendMessageRequestSize, > > - (VOID *)SendMessageResponse, > > - SendMessageResponseSize > > - ); > > - return Status; > > -} > > - > > -/** > > - This function gets the system UUID. > > - > > - @param[out] SystemGuid The pointer to retrieve system UUID. > > - > > - @retval EFI_SUCCESS UUID is returned. > > - @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer. > > - @retval Others Other errors. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSystemUuid ( > > - OUT EFI_GUID *SystemGuid > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 RequestSize; > > - UINT32 ResponseSize; > > - IPMI_GET_SYSTEM_UUID_RESPONSE GetSystemUuidResponse; > > - > > - if (SystemGuid =3D=3D NULL) { > > - return EFI_INVALID_PARAMETER; > > - } > > - RequestSize =3D 0; > > - ResponseSize =3D sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_SYSTEM_GUID, > > - (VOID *)NULL, > > - RequestSize, > > - (VOID *)&GetSystemUuidResponse, > > - &ResponseSize > > - ); > > - if (!EFI_ERROR (Status) && GetSystemUuidResponse.CompletionCode =3D= =3D > > IPMI_COMP_CODE_NORMAL) { > > - CopyMem ( > > - (VOID *)SystemGuid, > > - (VOID *)&GetSystemUuidResponse.SystemUuid, > > - sizeof (EFI_GUID) > > - ); > > - } > > - return Status; > > -} > > - > > -/** > > - This function gets the channel information. > > - > > - @param[in] GetChannelInfoRequest The get channel > information > > request. > > - @param[out] GetChannelInfoResponse The get channel > information > > response. > > - @param[out] GetChannelInfoResponseSize When input, the > expected size > > of response. > > - When output, the > exact size of the returned > > - response. > > - > > - @retval EFI_SUCCESS Get channel information > successfully. > > - @retval EFI_INVALID_PARAMETER One of the given input parameters > is > > invalid. > > - @retval Others Other errors. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChannelInfo ( > > - IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest, > > - OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse, > > - OUT UINT32 > *GetChannelInfoResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - if (GetChannelInfoRequest =3D=3D NULL || > > - GetChannelInfoResponse =3D=3D NULL || > > - GetChannelInfoResponseSize =3D=3D NULL) { > > - return EFI_INVALID_PARAMETER; > > - } > > - > > - *GetChannelInfoResponseSize =3D sizeof > > (IPMI_GET_CHANNEL_INFO_RESPONSE); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_APP, > > - IPMI_APP_GET_CHANNEL_INFO, > > - (UINT8 *)GetChannelInfoRequest, > > - sizeof (IPMI_GET_CHANNEL_INFO_REQUEST), > > - (UINT8 *)GetChannelInfoResponse, > > - GetChannelInfoResponseSize > > - ); > > - return Status; > > -} > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnChassis.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnChassis.c > > deleted file mode 100644 > > index 9c19f52ce4..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnChassis.c > > +++ /dev/null > > @@ -1,144 +0,0 @@ > > -/** @file > > - IPMI Command - NetFnChassis. > > - > > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> > - SPDX-License-Identifier: BSD-2-Clause-Patent > > -**/ > > - > > -#include > > -#include > > -#include > > -#include > > - > > -#include > > - > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChassisCapabilities ( > > - OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE > > *GetChassisCapabilitiesResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetChassisCapabilitiesResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_GET_CAPABILITIES, > > - NULL, > > - 0, > > - (VOID *)GetChassisCapabilitiesResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChassisStatus ( > > - OUT IPMI_GET_CHASSIS_STATUS_RESPONSE > *GetChassisStatusResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetChassisStatusResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_GET_STATUS, > > - NULL, > > - 0, > > - (VOID *)GetChassisStatusResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiChassisControl ( > > - IN IPMI_CHASSIS_CONTROL_REQUEST *ChassisControlRequest, > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_CONTROL, > > - (VOID *)ChassisControlRequest, > > - sizeof(*ChassisControlRequest), > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetPowerRestorePolicy ( > > - IN IPMI_SET_POWER_RESTORE_POLICY_REQUEST > *ChassisControlRequest, > > - OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE > > *ChassisControlResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*ChassisControlResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_SET_POWER_RESTORE_POLICY, > > - (VOID *)ChassisControlRequest, > > - sizeof(*ChassisControlRequest), > > - (VOID *)ChassisControlResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSystemBootOptions ( > > - IN IPMI_SET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > > - OUT IPMI_SET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*BootOptionsResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS, > > - (VOID *)BootOptionsRequest, > > - sizeof(*BootOptionsRequest), > > - (VOID *)BootOptionsResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSystemBootOptions ( > > - IN IPMI_GET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > > - OUT IPMI_GET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*BootOptionsResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS, > > - (VOID *)BootOptionsRequest, > > - sizeof(*BootOptionsRequest), > > - (VOID *)BootOptionsResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnStorage.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnStorage.c > > deleted file mode 100644 > > index 2215028089..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnStorage.c > > +++ /dev/null > > @@ -1,274 +0,0 @@ > > -/** @file > > - IPMI Command - NetFnStorage. > > - > > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> > - SPDX-License-Identifier: BSD-2-Clause-Patent > > -**/ > > - > > -#include > > -#include > > -#include > > -#include > > - > > -#include > > - > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetFruInventoryAreaInfo ( > > - IN IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST > > *GetFruInventoryAreaInfoRequest, > > - OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE > > *GetFruInventoryAreaInfoResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetFruInventoryAreaInfoResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_GET_FRU_INVENTORY_AREAINFO, > > - (VOID *)GetFruInventoryAreaInfoRequest, > > - sizeof(*GetFruInventoryAreaInfoRequest), > > - (VOID *)GetFruInventoryAreaInfoResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiReadFruData ( > > - IN IPMI_READ_FRU_DATA_REQUEST *ReadFruDataRequest, > > - OUT IPMI_READ_FRU_DATA_RESPONSE > *ReadFruDataResponse, > > - IN OUT UINT32 > *ReadFruDataResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_READ_FRU_DATA, > > - (VOID *)ReadFruDataRequest, > > - sizeof(*ReadFruDataRequest), > > - (VOID *)ReadFruDataResponse, > > - ReadFruDataResponseSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiWriteFruData ( > > - IN IPMI_WRITE_FRU_DATA_REQUEST *WriteFruDataRequest, > > - IN UINT32 > WriteFruDataRequestSize, > > - OUT IPMI_WRITE_FRU_DATA_RESPONSE > *WriteFruDataResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*WriteFruDataResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_WRITE_FRU_DATA, > > - (VOID *)WriteFruDataRequest, > > - WriteFruDataRequestSize, > > - (VOID *)WriteFruDataResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelInfo ( > > - OUT IPMI_GET_SEL_INFO_RESPONSE *GetSelInfoResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetSelInfoResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_GET_SEL_INFO, > > - NULL, > > - 0, > > - (VOID *)GetSelInfoResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelEntry ( > > - IN IPMI_GET_SEL_ENTRY_REQUEST *GetSelEntryRequest, > > - OUT IPMI_GET_SEL_ENTRY_RESPONSE *GetSelEntryResponse, > > - IN OUT UINT32 *GetSelEntryResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_GET_SEL_ENTRY, > > - (VOID *)GetSelEntryRequest, > > - sizeof(*GetSelEntryRequest), > > - (VOID *)GetSelEntryResponse, > > - GetSelEntryResponseSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiAddSelEntry ( > > - IN IPMI_ADD_SEL_ENTRY_REQUEST *AddSelEntryRequest, > > - OUT IPMI_ADD_SEL_ENTRY_RESPONSE *AddSelEntryResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*AddSelEntryResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_ADD_SEL_ENTRY, > > - (VOID *)AddSelEntryRequest, > > - sizeof(*AddSelEntryRequest), > > - (VOID *)AddSelEntryResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiPartialAddSelEntry ( > > - IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST > *PartialAddSelEntryRequest, > > - IN UINT32 > PartialAddSelEntryRequestSize, > > - OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE > > *PartialAddSelEntryResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*PartialAddSelEntryResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_PARTIAL_ADD_SEL_ENTRY, > > - (VOID *)PartialAddSelEntryRequest, > > - PartialAddSelEntryRequestSize, > > - (VOID *)PartialAddSelEntryResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiClearSel ( > > - IN IPMI_CLEAR_SEL_REQUEST *ClearSelRequest, > > - OUT IPMI_CLEAR_SEL_RESPONSE *ClearSelResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*ClearSelResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_CLEAR_SEL, > > - (VOID *)ClearSelRequest, > > - sizeof(*ClearSelRequest), > > - (VOID *)ClearSelResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelTime ( > > - OUT IPMI_GET_SEL_TIME_RESPONSE *GetSelTimeResponse > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetSelTimeResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_GET_SEL_TIME, > > - NULL, > > - 0, > > - (VOID *)GetSelTimeResponse, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSelTime ( > > - IN IPMI_SET_SEL_TIME_REQUEST *SetSelTimeRequest, > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_SET_SEL_TIME, > > - (VOID *)SetSelTimeRequest, > > - sizeof(*SetSelTimeRequest), > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSdrRepositoryInfo ( > > - OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE > > *GetSdrRepositoryInfoResp > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*GetSdrRepositoryInfoResp); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_GET_SDR_REPOSITORY_INFO, > > - NULL, > > - 0, > > - (VOID *)GetSdrRepositoryInfoResp, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSdr ( > > - IN IPMI_GET_SDR_REQUEST *GetSdrRequest, > > - OUT IPMI_GET_SDR_RESPONSE *GetSdrResponse, > > - IN OUT UINT32 *GetSdrResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_STORAGE, > > - IPMI_STORAGE_GET_SDR, > > - (VOID *)GetSdrRequest, > > - sizeof(*GetSdrRequest), > > - (VOID *)GetSdrResponse, > > - GetSdrResponseSize > > - ); > > - return Status; > > -} > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnTransport.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnTransport.c > > deleted file mode 100644 > > index 30ea84c04b..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > > mandLib/IpmiCommandLibNetFnTransport.c > > +++ /dev/null > > @@ -1,123 +0,0 @@ > > -/** @file > > - IPMI Command - NetFnTransport. > > - > > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> > - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > reserved.
> > - > > - SPDX-License-Identifier: BSD-2-Clause-Patent > > -**/ > > - > > -#include > > -#include > > -#include > > -#include > > - > > -#include > > - > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSolActivating ( > > - IN IPMI_SOL_ACTIVATING_REQUEST *SolActivatingRequest, > > - OUT UINT8 *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_TRANSPORT, > > - IPMI_TRANSPORT_SOL_ACTIVATING, > > - (VOID *)SolActivatingRequest, > > - sizeof(*SolActivatingRequest), > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSolConfigurationParameters ( > > - IN IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST > > *SetConfigurationParametersRequest, > > - IN UINT32 > SetConfigurationParametersRequestSize, > > - OUT UINT8 > *CompletionCode > > - ) > > -{ > > - EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof(*CompletionCode); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_TRANSPORT, > > - IPMI_TRANSPORT_SET_SOL_CONFIG_PARAM, > > - (VOID *)SetConfigurationParametersRequest, > > - SetConfigurationParametersRequestSize, > > - (VOID *)CompletionCode, > > - &DataSize > > - ); > > - return Status; > > -} > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSolConfigurationParameters ( > > - IN IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST > > *GetConfigurationParametersRequest, > > - OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE > > *GetConfigurationParametersResponse, > > - IN OUT UINT32 > > *GetConfigurationParametersResponseSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_TRANSPORT, > > - IPMI_TRANSPORT_GET_SOL_CONFIG_PARAM, > > - (VOID *)GetConfigurationParametersRequest, > > - sizeof(*GetConfigurationParametersRequest), > > - (VOID *)GetConfigurationParametersResponse, > > - GetConfigurationParametersResponseSize > > - ); > > - return Status; > > -} > > - > > -/** > > - This function gets the LAN configuration parameter. > > - > > - @param[in] GetLanConfigurationParametersRequest Request > data > > - @param[out] GetLanConfigurationParametersResponse Response > data > > - @param[in,out] GetLanConfigurationParametersSize When input, > the > > expected size of response data. > > - > When out, the exact size of response data. > > - > > - @retval EFI_SUCCESS Lan configuration parameter is > returned in the > > response. > > - @retval EFI_INVALID_PARAMETER One of the given input parameters > is > > invalid. > > - @retval Others Other errors. > > - > > -**/ > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetLanConfigurationParameters ( > > - IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST > > *GetLanConfigurationParametersRequest, > > - OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE > > *GetLanConfigurationParametersResponse, > > - IN OUT UINT32 > *GetLanConfigurationParametersSize > > - ) > > -{ > > - EFI_STATUS Status; > > - > > - if (GetLanConfigurationParametersRequest =3D=3D NULL || > > - GetLanConfigurationParametersResponse =3D=3D NULL || > > - GetLanConfigurationParametersSize =3D=3D NULL) { > > - return EFI_INVALID_PARAMETER; > > - } > > - > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_TRANSPORT, > > - IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS, > > - (UINT8 *)GetLanConfigurationParametersRequest, > > - sizeof(*GetLanConfigurationParametersRequest), > > - (UINT8 *)GetLanConfigurationParametersResponse, > > - GetLanConfigurationParametersSize > > - ); > > - return Status; > > -} > > -- > > 2.37.1.windows.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110986): https://edk2.groups.io/g/devel/message/110986 Mute This Topic: https://groups.io/mt/102486123/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-