From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web12.10301.1607441944853954498
 for <devel@edk2.groups.io>;
 Tue, 08 Dec 2020 07:39:06 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([114.87.24.58])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <afish@apple.com>; Tue, 08 Dec 2020 23:38:50 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<lersek@redhat.com>,
	"'Michael Kinney'" <michael.d.kinney@intel.com>,
	"'Sean Brogan'" <sean.brogan@microsoft.com>,
	"'Ard Biesheuvel \(ARM address\)'" <ard.biesheuvel@arm.com>,
	"'Leif Lindholm \(Nuvia address\)'" <leif@nuviainc.com>,
	"'Andrew Fish'" <afish@apple.com>
References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com>
In-Reply-To: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gcGxlYXNlIGxldCdzIGRpc2FibGUgdGhlIEVDQyBwbHVnaW4gaW4gQ0ksIGluIGl0cyBjdXJyZW50IGZvcm0=?=
Date: Tue, 8 Dec 2020 23:38:40 +0800
Message-ID: <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQMY4cZRsRTlP1zl8zhKzIXR47cOo6dpJYQA
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Laszlo:
  ECC tool is not perfect. It is still helpful. I am OK to disable ECC plu=
gin in CI. But, I request to expose the option to enable it per package. If=
 the package maintainer thinks ECC is valuable, he can enable ECC plugin in=
 one package. As MdePkg maintainer, I can help to resolve ECC issue in MdeP=
kg patch. So, I would keep ECC plugin in MdePkg.

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68414+4905953+8761045@groups.i=
o
> <bounce+27952+68414+4905953+8761045@groups.io> =E4=BB=A3=E8=A1=A8 Laszlo=
 Ersek
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=888=E6=97=A5=
 10:05
> =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kinney <michael.d.kinney@intel.com>=
; Sean Brogan
> <sean.brogan@microsoft.com>; Ard Biesheuvel (ARM address)
> <ard.biesheuvel@arm.com>; Leif Lindholm (Nuvia address)
> <leif@nuviainc.com>; Andrew Fish <afish@apple.com>
> =E6=8A=84=E9=80=81: edk2-devel-groups-io <devel@edk2.groups.io>
> =E4=B8=BB=E9=A2=98: [edk2-devel] please let's disable the ECC plugin in =
CI, in its current form
>=20
> Hi All,
>=20
> in my opinion, the ECC plugin in CI has not been productive or helpful.
> The errors it reports are not convincing, and exceptions are difficult
> to add, or even express. I request that we disable ECC globally for
> edk2, or at least make it controllable through a github PR flag (not
> through CI metafile changes in edk2).
>=20
> (Metafile changes could be an acceptable way of controlling ECC if (a)
> they didn't have to go through review, (b) if technically such changes
> would take effect in CI even if they were included in the patch series
> subject to the CI run. Then a maintainer could evaluate and
> *immediately* suppress such ECC issues by adding the exceptions as a
> prepended patch, and force-pushing the updated branch to the same open
> PR. But this would remain much inferior to simply disabling ECC, or
> controlling it through a PR label.)
>=20
> Thanks
> Laszlo
>=20
>=20
>=20
>=20
>=20