From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.46834.1612233826302754030 for ; Mon, 01 Feb 2021 18:43:47 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 02 Feb 2021 10:43:35 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kinney, Michael D'" , "'Sheng, W'" , Cc: "'Liu, Zhiguang'" , "'Yao, Jiewen'" , "'Andrew Fish'" , "'Laszlo Ersek'" References: <20210129023448.30348-1-w.sheng@intel.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0hdIE1kZVBrZy9JbmNsdWRlOiBBZGQgQ0VUIGluc3RydWN0aW9ucyB0byBOYXNtLmluYw==?= Date: Tue, 2 Feb 2021 10:43:40 +0800 Message-ID: <000a01d6f90d$3718edc0$a54ac940$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQN3wkfJ+S6PaEcX1atqqqHz4MZGtQHw/3iJpvFzaGA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike and Sheng: Linux or Mac OS includes the pre-built nasm. Their nasm version may be = old. Can you evaluate the impact to update nasm version? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D = > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B41=E6=9C=8830=E6=97=A5 1:23 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Sheng, W ; = devel@edk2.groups.io; Kinney, > Michael D > =E6=8A=84=E9=80=81: Liming Gao ; Liu, = Zhiguang > ; Yao, Jiewen > =E4=B8=BB=E9=A2=98: RE: [PATCH] MdePkg/Include: Add CET instructions = to Nasm.inc >=20 > Sheng, >=20 > The following version of the NASM documentation shows support for = these > instructions. >=20 > https://nasm.us/doc/nasmdocb.html >=20 > Do we need to increase the min NASM version requirements for EDK II to > avoid adding macros with DB? >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: Sheng, W > > Sent: Thursday, January 28, 2021 6:35 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang > > ; Yao, Jiewen > > Subject: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc > > > > This is to add instruction SAVEPREVSSP, CLRSSBSY and RSTORSSP_RAX in > Nasm, > > because these instructions are not supported yet. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3192 > > > > Signed-off-by: Sheng Wei > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Jiewen Yao > > --- > > MdePkg/Include/Ia32/Nasm.inc | 14 +++++++++++++- > > MdePkg/Include/X64/Nasm.inc | 14 +++++++++++++- > > 2 files changed, 26 insertions(+), 2 deletions(-) > > > > diff --git a/MdePkg/Include/Ia32/Nasm.inc > b/MdePkg/Include/Ia32/Nasm.inc > > index 31ce861f1e..9c1b7796ea 100644 > > --- a/MdePkg/Include/Ia32/Nasm.inc > > +++ b/MdePkg/Include/Ia32/Nasm.inc > > @@ -1,6 +1,6 @@ > > = ;------------------------------------------------------------------------= ------ > > ; > > -; Copyright (c) 2019, Intel Corporation. All rights reserved.
> > +; Copyright (c) 2019 - 2021, Intel Corporation. All rights = reserved.
> > ; SPDX-License-Identifier: BSD-2-Clause-Patent > > ; > > ; Abstract: > > @@ -20,3 +20,15 @@ > > %macro INCSSP_EAX 0 > > DB 0xF3, 0x0F, 0xAE, 0xE8 > > %endmacro > > + > > +%macro SAVEPREVSSP 0 > > + DB 0xF3, 0x0F, 0x01, 0xEA > > +%endmacro > > + > > +%macro CLRSSBSY_EAX 0 > > + DB 0x67, 0xF3, 0x0F, 0xAE, 0x30 > > +%endmacro > > + > > +%macro RSTORSSP_EAX 0 > > + DB 0x67, 0xF3, 0x0F, 0x01, 0x28 > > +%endmacro > > diff --git a/MdePkg/Include/X64/Nasm.inc > b/MdePkg/Include/X64/Nasm.inc > > index 42412735ea..c5189982bb 100644 > > --- a/MdePkg/Include/X64/Nasm.inc > > +++ b/MdePkg/Include/X64/Nasm.inc > > @@ -1,6 +1,6 @@ > > = ;------------------------------------------------------------------------= ------ > > ; > > -; Copyright (c) 2019, Intel Corporation. All rights reserved.
> > +; Copyright (c) 2019 - 2021, Intel Corporation. All rights = reserved.
> > ; SPDX-License-Identifier: BSD-2-Clause-Patent > > ; > > ; Abstract: > > @@ -20,3 +20,15 @@ > > %macro INCSSP_RAX 0 > > DB 0xF3, 0x48, 0x0F, 0xAE, 0xE8 > > %endmacro > > + > > +%macro SAVEPREVSSP 0 > > + DB 0xF3, 0x0F, 0x01, 0xEA > > +%endmacro > > + > > +%macro CLRSSBSY_RAX 0 > > + DB 0xF3, 0x0F, 0xAE, 0x30 > > +%endmacro > > + > > +%macro RSTORSSP_RAX 0 > > + DB 0xF3, 0x0F, 0x01, 0x28 > > +%endmacro > > -- > > 2.16.2.windows.1