From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.5114.1603070894059931893 for ; Sun, 18 Oct 2020 18:28:15 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 19 Oct 2020 09:28:11 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Feng, Bob C'" , , , , Cc: "'Bret Barkelew'" , "'Sean Brogan'" References: <000601d6a5b3$59da0e00$0d8e2a00$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gQ0kgdGVzdCBvbiBjb3B5cmlnaHQ=?= Date: Mon, 19 Oct 2020 09:28:11 +0800 Message-ID: <000b01d6a5b7$1bc40e00$534c2a00$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHck2pVl3rctIGXdqdCnng2yG34lwF1Sy3jApttGCYBhtV4JqllipOg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Bob: Now, the problem is the inconsistent behavior. The same copyright style = ((C) Copyright 2020 Hewlett Packard Enterprise Development LP ) in .c can p= ass ECC, but in .inf file can't pass ECC. I want to know the reason.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Feng, Bob C > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8819=E6=97= =A5 9:25 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com= .cn; > spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com > =E6=8A=84=E9=80=81: 'Bret Barkelew' ; 'Sean= Brogan' > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] CI test on copyright >=20 > In the ECC, the rule to check Copyright is to see if the Copyright is th= e first > word of a line, and the Copyright should be followed by a ( >=20 > Liming, for your reference, the code in ECC >=20 > ## _IsCopyrightLine > # check whether current line is copyright line, the criteria is whether = there is > case insensitive keyword "Copyright" > # followed by zero or more white space characters followed by a "(" char= acter > # > # @param LineContent: the line need to be checked > # @return: True if current line is copyright line, False else > # >=20 > -Bob >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Monday, October 19, 2020 9:01 AM > To: devel@edk2.groups.io; spbrogan@outlook.com; > shenglei.zhang@intel.com; abner.chang@hpe.com > Cc: 'Bret Barkelew' ; 'Sean Brogan' > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] CI test on copyright >=20 > I will check this issue first. >=20 > Thanks > Liming >=20 > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66349+4905953+8761045@groups= .io > > =E4=BB=A3=E8=A1=A8 Sean > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8817=E6=97= = =A5 12:46 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; shenglei.zhang@inte= l.com; > > abner.chang@hpe.com > > =E6=8A=84=E9=80=81: Bret Barkelew ; Sean = Brogan > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] CI test on copyright > > > > ECC stuff was done by Intel. I would defer to them. > > > > Adding shenglei.zhang@intel.com > > > > On 10/15/2020 9:21 AM, Abner Chang wrote: > > > Hi Sean and Bret, > > > I got the CI test error which says the first line in file header > > > section > must > > have the copyright information, however the copyright is there and > > looks > to > > me fine as below, > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > > > > > [cid:image001.png@01D6A351.31688460] > > > > > > > > > The interesting part is CI seems happy with below format of > > > copyright, > and > > this issue only happens on INF file but not on the *.c and *.h. > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP
> > > > > > Any idea on this? > > > Abner > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20