CI test on copyright

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* CI test on copyright
@ 2020-10-15 16:21 Abner Chang
  2020-10-15 16:24 ` Bret Barkelew
  2020-10-17  4:45 ` Sean
  0 siblings, 2 replies; 18+ messages in thread
From: Abner Chang @ 2020-10-15 16:21 UTC (permalink / raw)
  To: devel@edk2.groups.io; +Cc: Bret Barkelew, Sean Brogan


[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A351.31688460]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner

[-- Attachment #1.2: Type: text/html, Size: 4914 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: CI test on copyright
  2020-10-15 16:21 CI test on copyright Abner Chang
@ 2020-10-15 16:24 ` Bret Barkelew
  2020-10-15 16:32   ` Abner Chang
  2020-10-17  4:45 ` Sean
  1 sibling, 1 reply; 18+ messages in thread
From: Bret Barkelew @ 2020-10-15 16:24 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io; +Cc: Sean Brogan


[-- Attachment #1.1: Type: text/plain, Size: 989 bytes --]

Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A351.31688460]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner


[-- Attachment #1.2: Type: text/html, Size: 5159 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: CI test on copyright
  2020-10-15 16:24 ` Bret Barkelew
@ 2020-10-15 16:32   ` Abner Chang
  2020-10-15 16:34     ` Bret Barkelew
  0 siblings, 1 reply; 18+ messages in thread
From: Abner Chang @ 2020-10-15 16:32 UTC (permalink / raw)
  To: Bret Barkelew, devel@edk2.groups.io; +Cc: Sean Brogan


[-- Attachment #1.1: Type: text/plain, Size: 1536 bytes --]


## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##

Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019

Abner

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: RE: CI test on copyright

Can you share the entire copyright header? In my experience, It's actually complaining about one of the '#' or '/*' tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A353.D58FEA40]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner


[-- Attachment #1.2: Type: text/html, Size: 7444 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: CI test on copyright
  2020-10-15 16:32   ` Abner Chang
@ 2020-10-15 16:34     ` Bret Barkelew
  2020-10-16  1:07       ` [edk2-devel] " Abner Chang
  0 siblings, 1 reply; 18+ messages in thread
From: Bret Barkelew @ 2020-10-15 16:34 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io; +Cc: Sean Brogan


[-- Attachment #1.1: Type: text/plain, Size: 2345 bytes --]

Try removing the extra line between “SPDX” and “##”.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] RE: CI test on copyright


## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##

Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0>

Abner

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: RE: CI test on copyright

Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A353.D58FEA40]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner



[-- Attachment #1.2: Type: text/html, Size: 8387 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-15 16:34     ` Bret Barkelew
@ 2020-10-16  1:07       ` Abner Chang
  2020-10-16  1:15         ` 回复: " gaoliming
  0 siblings, 1 reply; 18+ messages in thread
From: Abner Chang @ 2020-10-16  1:07 UTC (permalink / raw)
  To: devel@edk2.groups.io, bret.barkelew@microsoft.com; +Cc: Sean Brogan


[-- Attachment #1.1: Type: text/plain, Size: 3289 bytes --]

Hmm, it doesn't work with below header. Still fail.

## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
##

I had confirmed it again, CI test passed with below one, move "(C)" to behind Copyright.
## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
##

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] CI test on copyright

Try removing the extra line between "SPDX" and "##".

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] RE: CI test on copyright


## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##

Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0>

Abner

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: RE: CI test on copyright

Can you share the entire copyright header? In my experience, It's actually complaining about one of the '#' or '/*' tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A39B.CE9B2220]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner




[-- Attachment #1.2: Type: text/html, Size: 11503 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* 回复: [edk2-devel] CI test on copyright
  2020-10-16  1:07       ` [edk2-devel] " Abner Chang
@ 2020-10-16  1:15         ` gaoliming
  2020-10-16  1:19           ` Abner Chang
       [not found]           ` <163E54449E0DFAB5.31077@groups.io>
  0 siblings, 2 replies; 18+ messages in thread
From: gaoliming @ 2020-10-16  1:15 UTC (permalink / raw)
  To: devel, abner.chang, bret.barkelew; +Cc: 'Sean Brogan'


[-- Attachment #1.1: Type: text/plain, Size: 4225 bytes --]

Abner:

 Do you mean the same Copyright in .c doesn’t trig the error message? But,
this Copyright in .inf file will trig the error. If yes, this should be an
issue in ECC checker. Can you submit one BZ? I will check it. 

 

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

 

Thanks

Liming

发件人: bounce+27952+66300+4905953+8761045@groups.io
<bounce+27952+66300+4905953+8761045@groups.io> 代表 Abner Chang
发送时间: 2020年10月16日 9:08
收件人: devel@edk2.groups.io; bret.barkelew@microsoft.com
抄送: Sean Brogan <sean.brogan@microsoft.com>
主题: Re: [edk2-devel] CI test on copyright

 

Hmm, it doesn’t work with below header. Still fail.

 

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

##

 

I had confirmed it again, CI test passed with below one, move “(C)” to
behind Copyright.

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

##

 

From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
[mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Sean Brogan <sean.brogan@microsoft.com
<mailto:sean.brogan@microsoft.com> >
Subject: Re: [edk2-devel] CI test on copyright

 

Try removing the extra line between “SPDX” and “##”.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist) <mailto:abner.chang@hpe.com> 
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com> ;
devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
Cc: Sean Brogan <mailto:sean.brogan@microsoft.com> 
Subject: [EXTERNAL] RE: CI test on copyright

 

 

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

#

##

 

Or you can check the PR,

https://github.com/tianocore/edk2/pull/1019
<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
m%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.
com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C
1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%
2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0> 

 

Abner

 

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] 
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Sean Brogan <sean.brogan@microsoft.com
<mailto:sean.brogan@microsoft.com> >
Subject: RE: CI test on copyright

 

Can you share the entire copyright header? In my experience, It’s actually
complaining about one of the ‘#’ or ‘/*’ tags.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist) <mailto:abner.chang@hpe.com> 
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
Cc: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com> ; Sean Brogan
<mailto:sean.brogan@microsoft.com> 
Subject: [EXTERNAL] CI test on copyright

 

Hi Sean and Bret,

I got the CI test error which says the first line in file header section
must have the copyright information, however the copyright is there and
looks to me fine as below,

(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

 



 

 

The interesting part is CI seems happy with below format of copyright, and
this issue only happens on INF file but not on the *.c and *.h.

Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

 

Any idea on this?

Abner

 

 




[-- Attachment #1.2: Type: text/html, Size: 14363 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-16  1:15         ` 回复: " gaoliming
@ 2020-10-16  1:19           ` Abner Chang
       [not found]           ` <163E54449E0DFAB5.31077@groups.io>
  1 sibling, 0 replies; 18+ messages in thread
From: Abner Chang @ 2020-10-16  1:19 UTC (permalink / raw)
  To: gaoliming, devel@edk2.groups.io, bret.barkelew@microsoft.com
  Cc: 'Sean Brogan'


[-- Attachment #1.1: Type: text/plain, Size: 4649 bytes --]

Yes. It doesn’t happen on .c file, only on INF file.
Ok. I will submit this issue on BZ.

Thanks

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Friday, October 16, 2020 9:16 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; bret.barkelew@microsoft.com
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: 回复: [edk2-devel] CI test on copyright

Abner:
 Do you mean the same Copyright in .c doesn’t trig the error message? But, this Copyright in .inf file will trig the error. If yes, this should be an issue in ECC checker. Can you submit one BZ? I will check it.

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

Thanks
Liming
发件人: bounce+27952+66300+4905953+8761045@groups.io<mailto:bounce+27952+66300+4905953+8761045@groups.io> <bounce+27952+66300+4905953+8761045@groups.io<mailto:bounce+27952+66300+4905953+8761045@groups.io>> 代表 Abner Chang
发送时间: 2020年10月16日 9:08
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>
抄送: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
主题: Re: [edk2-devel] CI test on copyright

Hmm, it doesn’t work with below header. Still fail.

## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
##

I had confirmed it again, CI test passed with below one, move “(C)” to behind Copyright.
## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
##

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: Re: [edk2-devel] CI test on copyright

Try removing the extra line between “SPDX” and “##”.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] RE: CI test on copyright


## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##

Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0>

Abner

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: RE: CI test on copyright

Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A39D.6BAB26E0]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner




[-- Attachment #1.2: Type: text/html, Size: 16253 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

[parent not found: <163E54449E0DFAB5.31077@groups.io>]

* Re: [edk2-devel] CI test on copyright
       [not found]           ` <163E54449E0DFAB5.31077@groups.io>
@ 2020-10-16  1:25             ` Abner Chang
  0 siblings, 0 replies; 18+ messages in thread
From: Abner Chang @ 2020-10-16  1:25 UTC (permalink / raw)
  To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist),
	gaoliming, bret.barkelew@microsoft.com
  Cc: 'Sean Brogan'


[-- Attachment #1.1: Type: text/plain, Size: 5283 bytes --]

Done Liming.
https://bugzilla.tianocore.org/show_bug.cgi?id=3011

But I am not sure if the Component and Product I selected in BZ are correct or not.

Thanks for checking this.
Abner


From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Friday, October 16, 2020 9:19 AM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; bret.barkelew@microsoft.com
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] CI test on copyright

Yes. It doesn’t happen on .c file, only on INF file.
Ok. I will submit this issue on BZ.

Thanks

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Friday, October 16, 2020 9:16 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>
Cc: 'Sean Brogan' <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: 回复: [edk2-devel] CI test on copyright

Abner:
 Do you mean the same Copyright in .c doesn’t trig the error message? But, this Copyright in .inf file will trig the error. If yes, this should be an issue in ECC checker. Can you submit one BZ? I will check it.

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

Thanks
Liming
发件人: bounce+27952+66300+4905953+8761045@groups.io<mailto:bounce+27952+66300+4905953+8761045@groups.io> <bounce+27952+66300+4905953+8761045@groups.io<mailto:bounce+27952+66300+4905953+8761045@groups.io>> 代表 Abner Chang
发送时间: 2020年10月16日 9:08
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>
抄送: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
主题: Re: [edk2-devel] CI test on copyright

Hmm, it doesn’t work with below header. Still fail.

## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
##

I had confirmed it again, CI test passed with below one, move “(C)” to behind Copyright.
## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
##

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: Re: [edk2-devel] CI test on copyright

Try removing the extra line between “SPDX” and “##”.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] RE: CI test on copyright


## @file
# Implementation of EFI REST JSON Structure Protocol.
#
#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
#  SPDX-License-Identifier: BSD-2-Clause-Patent
#
##

Or you can check the PR,
https://github.com/tianocore/edk2/pull/1019<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0>

Abner

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Subject: RE: CI test on copyright

Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags.

- Bret

From: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: [EXTERNAL] CI test on copyright

Hi Sean and Bret,
I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

[cid:image001.png@01D6A39E.3E4221D0]


The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

Any idea on this?
Abner




[-- Attachment #1.2: Type: text/html, Size: 18316 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-15 16:21 CI test on copyright Abner Chang
  2020-10-15 16:24 ` Bret Barkelew
@ 2020-10-17  4:45 ` Sean
  2020-10-19  1:01   ` 回复: " gaoliming
  1 sibling, 1 reply; 18+ messages in thread
From: Sean @ 2020-10-17  4:45 UTC (permalink / raw)
  To: devel, shenglei.zhang, abner.chang; +Cc: Bret Barkelew, Sean Brogan

ECC stuff was done by Intel. I would defer to them.

Adding shenglei.zhang@intel.com

On 10/15/2020 9:21 AM, Abner Chang wrote:
> Hi Sean and Bret,
> I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> 
> [cid:image001.png@01D6A351.31688460]
> 
> 
> The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.
> Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> 
> Any idea on this?
> Abner
> 
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* 回复: [edk2-devel] CI test on copyright
  2020-10-17  4:45 ` Sean
@ 2020-10-19  1:01   ` gaoliming
  2020-10-19  1:24     ` Bob Feng
  0 siblings, 1 reply; 18+ messages in thread
From: gaoliming @ 2020-10-19  1:01 UTC (permalink / raw)
  To: devel, spbrogan, shenglei.zhang, abner.chang
  Cc: 'Bret Barkelew', 'Sean Brogan'

I will check this issue first. 

Thanks
Liming

> -----邮件原件-----
> 发件人: bounce+27952+66349+4905953+8761045@groups.io
> <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> 发送时间: 2020年10月17日 12:46
> 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> abner.chang@hpe.com
> 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> 主题: Re: [edk2-devel] CI test on copyright
> 
> ECC stuff was done by Intel. I would defer to them.
> 
> Adding shenglei.zhang@intel.com
> 
> On 10/15/2020 9:21 AM, Abner Chang wrote:
> > Hi Sean and Bret,
> > I got the CI test error which says the first line in file header section
must
> have the copyright information, however the copyright is there and looks
to
> me fine as below,
> > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > [cid:image001.png@01D6A351.31688460]
> >
> >
> > The interesting part is CI seems happy with below format of copyright,
and
> this issue only happens on INF file but not on the *.c and *.h.
> > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > Any idea on this?
> > Abner
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-19  1:01   ` 回复: " gaoliming
@ 2020-10-19  1:24     ` Bob Feng
  2020-10-19  1:28       ` 回复: " gaoliming
  0 siblings, 1 reply; 18+ messages in thread
From: Bob Feng @ 2020-10-19  1:24 UTC (permalink / raw)
  To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
	spbrogan@outlook.com, shenglei.zhang@intel.com,
	abner.chang@hpe.com
  Cc: 'Bret Barkelew', 'Sean Brogan'

In the ECC, the rule to check Copyright is to see if the Copyright is the first word of a line, and the Copyright should be followed by a (

Liming, for your reference, the code in ECC

## _IsCopyrightLine
# check whether current line is copyright line, the criteria is whether there is case insensitive keyword "Copyright"
# followed by zero or more white space characters followed by a "(" character
#
# @param LineContent:  the line need to be checked
# @return: True if current line is copyright line, False else
#

-Bob

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
Sent: Monday, October 19, 2020 9:01 AM
To: devel@edk2.groups.io; spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: 回复: [edk2-devel] CI test on copyright

I will check this issue first. 

Thanks
Liming

> -----邮件原件-----
> 发件人: bounce+27952+66349+4905953+8761045@groups.io
> <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> 发送时间: 2020年10月17日 12:46
> 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com; 
> abner.chang@hpe.com
> 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan 
> <sean.brogan@microsoft.com>
> 主题: Re: [edk2-devel] CI test on copyright
> 
> ECC stuff was done by Intel. I would defer to them.
> 
> Adding shenglei.zhang@intel.com
> 
> On 10/15/2020 9:21 AM, Abner Chang wrote:
> > Hi Sean and Bret,
> > I got the CI test error which says the first line in file header 
> > section
must
> have the copyright information, however the copyright is there and 
> looks
to
> me fine as below,
> > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > [cid:image001.png@01D6A351.31688460]
> >
> >
> > The interesting part is CI seems happy with below format of 
> > copyright,
and
> this issue only happens on INF file but not on the *.c and *.h.
> > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > Any idea on this?
> > Abner
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 









^ permalink raw reply	[flat|nested] 18+ messages in thread

* 回复: [edk2-devel] CI test on copyright
  2020-10-19  1:24     ` Bob Feng
@ 2020-10-19  1:28       ` gaoliming
  2020-10-19  2:24         ` Bob Feng
  0 siblings, 1 reply; 18+ messages in thread
From: gaoliming @ 2020-10-19  1:28 UTC (permalink / raw)
  To: 'Feng, Bob C', devel, spbrogan, shenglei.zhang,
	abner.chang
  Cc: 'Bret Barkelew', 'Sean Brogan'

Bob:
  Now, the problem is the inconsistent behavior. The same copyright style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP ) in .c can pass ECC, but in .inf file can't pass ECC. I want to know the reason. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Feng, Bob C <bob.c.feng@intel.com>
> 发送时间: 2020年10月19日 9:25
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn;
> spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
> 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> 主题: RE: [edk2-devel] CI test on copyright
> 
> In the ECC, the rule to check Copyright is to see if the Copyright is the first
> word of a line, and the Copyright should be followed by a (
> 
> Liming, for your reference, the code in ECC
> 
> ## _IsCopyrightLine
> # check whether current line is copyright line, the criteria is whether there is
> case insensitive keyword "Copyright"
> # followed by zero or more white space characters followed by a "(" character
> #
> # @param LineContent:  the line need to be checked
> # @return: True if current line is copyright line, False else
> #
> 
> -Bob
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Monday, October 19, 2020 9:01 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com;
> shenglei.zhang@intel.com; abner.chang@hpe.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: 回复: [edk2-devel] CI test on copyright
> 
> I will check this issue first.
> 
> Thanks
> Liming
> 
> > -----邮件原件-----
> > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > 发送时间: 2020年10月17日 12:46
> > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> > abner.chang@hpe.com
> > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> > <sean.brogan@microsoft.com>
> > 主题: Re: [edk2-devel] CI test on copyright
> >
> > ECC stuff was done by Intel. I would defer to them.
> >
> > Adding shenglei.zhang@intel.com
> >
> > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > Hi Sean and Bret,
> > > I got the CI test error which says the first line in file header
> > > section
> must
> > have the copyright information, however the copyright is there and
> > looks
> to
> > me fine as below,
> > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > >
> > > [cid:image001.png@01D6A351.31688460]
> > >
> > >
> > > The interesting part is CI seems happy with below format of
> > > copyright,
> and
> > this issue only happens on INF file but not on the *.c and *.h.
> > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > >
> > > Any idea on this?
> > > Abner
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-19  1:28       ` 回复: " gaoliming
@ 2020-10-19  2:24         ` Bob Feng
  2020-10-19  2:48           ` Abner Chang
  0 siblings, 1 reply; 18+ messages in thread
From: Bob Feng @ 2020-10-19  2:24 UTC (permalink / raw)
  To: gaoliming, devel@edk2.groups.io, spbrogan@outlook.com,
	shenglei.zhang@intel.com, abner.chang@hpe.com
  Cc: 'Bret Barkelew', 'Sean Brogan'

For the .c and .h, ECC add the rule to allow (C) Copyright format. 
Looks this bug was not fixed completely. https://bugzilla.tianocore.org/show_bug.cgi?id=2057 

Need file a new Bugzilla and fix this issue.

Thanks,
Bob
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Monday, October 19, 2020 9:28 AM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io; spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: 回复: [edk2-devel] CI test on copyright

Bob:
  Now, the problem is the inconsistent behavior. The same copyright style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP ) in .c can pass ECC, but in .inf file can't pass ECC. I want to know the reason. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Feng, Bob C <bob.c.feng@intel.com>
> 发送时间: 2020年10月19日 9:25
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 
> spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
> 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> 主题: RE: [edk2-devel] CI test on copyright
> 
> In the ECC, the rule to check Copyright is to see if the Copyright is 
> the first word of a line, and the Copyright should be followed by a (
> 
> Liming, for your reference, the code in ECC
> 
> ## _IsCopyrightLine
> # check whether current line is copyright line, the criteria is 
> whether there is case insensitive keyword "Copyright"
> # followed by zero or more white space characters followed by a "(" 
> character # # @param LineContent:  the line need to be checked # 
> @return: True if current line is copyright line, False else #
> 
> -Bob
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> gaoliming
> Sent: Monday, October 19, 2020 9:01 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com; 
> shenglei.zhang@intel.com; abner.chang@hpe.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: 回复: [edk2-devel] CI test on copyright
> 
> I will check this issue first.
> 
> Thanks
> Liming
> 
> > -----邮件原件-----
> > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > 发送时间: 2020年10月17日 12:46
> > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com; 
> > abner.chang@hpe.com
> > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan 
> > <sean.brogan@microsoft.com>
> > 主题: Re: [edk2-devel] CI test on copyright
> >
> > ECC stuff was done by Intel. I would defer to them.
> >
> > Adding shenglei.zhang@intel.com
> >
> > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > Hi Sean and Bret,
> > > I got the CI test error which says the first line in file header 
> > > section
> must
> > have the copyright information, however the copyright is there and 
> > looks
> to
> > me fine as below,
> > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > >
> > > [cid:image001.png@01D6A351.31688460]
> > >
> > >
> > > The interesting part is CI seems happy with below format of 
> > > copyright,
> and
> > this issue only happens on INF file but not on the *.c and *.h.
> > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > >
> > > Any idea on this?
> > > Abner
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-19  2:24         ` Bob Feng
@ 2020-10-19  2:48           ` Abner Chang
  2020-10-19  3:01             ` Bob Feng
  0 siblings, 1 reply; 18+ messages in thread
From: Abner Chang @ 2020-10-19  2:48 UTC (permalink / raw)
  To: devel@edk2.groups.io, bob.c.feng@intel.com, gaoliming,
	spbrogan@outlook.com, shenglei.zhang@intel.com
  Cc: 'Bret Barkelew', 'Sean Brogan'

Hi Bob, 
So the fix was only applied on c and h file as your mentioned? If so then we need a BZ to add the same rule on the files other then c and h.

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Bob Feng
> Sent: Monday, October 19, 2020 10:25 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS
> SW/FW Technologist) <abner.chang@hpe.com>
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] CI test on copyright
> 
> For the .c and .h, ECC add the rule to allow (C) Copyright format.
> Looks this bug was not fixed completely.
> INVALID URI REMOVED
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D2057&d=DwIGaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> skz6qU3NYRO03nHp9P7Z5q59A3E&m=oWYb80tvgLGP9RZPAmJdv9pqtmSQb
> DbP1z9tdxINhI0&s=KduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4-
> mbW5cF4&e=
> 
> Need file a new Bugzilla and fix this issue.
> 
> Thanks,
> Bob
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, October 19, 2020 9:28 AM
> To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io;
> spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: 回复: [edk2-devel] CI test on copyright
> 
> Bob:
>   Now, the problem is the inconsistent behavior. The same copyright style ((C)
> Copyright 2020 Hewlett Packard Enterprise Development LP ) in .c can pass
> ECC, but in .inf file can't pass ECC. I want to know the reason.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Feng, Bob C <bob.c.feng@intel.com>
> > 发送时间: 2020年10月19日 9:25
> > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn;
> > spbrogan@outlook.com; shenglei.zhang@intel.com;
> abner.chang@hpe.com
> > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > 主题: RE: [edk2-devel] CI test on copyright
> >
> > In the ECC, the rule to check Copyright is to see if the Copyright is
> > the first word of a line, and the Copyright should be followed by a (
> >
> > Liming, for your reference, the code in ECC
> >
> > ## _IsCopyrightLine
> > # check whether current line is copyright line, the criteria is
> > whether there is case insensitive keyword "Copyright"
> > # followed by zero or more white space characters followed by a "("
> > character # # @param LineContent:  the line need to be checked #
> > @return: True if current line is copyright line, False else #
> >
> > -Bob
> >
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > gaoliming
> > Sent: Monday, October 19, 2020 9:01 AM
> > To: devel@edk2.groups.io; spbrogan@outlook.com;
> > shenglei.zhang@intel.com; abner.chang@hpe.com
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: 回复: [edk2-devel] CI test on copyright
> >
> > I will check this issue first.
> >
> > Thanks
> > Liming
> >
> > > -----邮件原件-----
> > > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > > 发送时间: 2020年10月17日 12:46
> > > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> > > abner.chang@hpe.com
> > > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> > > <sean.brogan@microsoft.com>
> > > 主题: Re: [edk2-devel] CI test on copyright
> > >
> > > ECC stuff was done by Intel. I would defer to them.
> > >
> > > Adding shenglei.zhang@intel.com
> > >
> > > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > > Hi Sean and Bret,
> > > > I got the CI test error which says the first line in file header
> > > > section
> > must
> > > have the copyright information, however the copyright is there and
> > > looks
> > to
> > > me fine as below,
> > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > >
> > > > [cid:image001.png@01D6A351.31688460]
> > > >
> > > >
> > > > The interesting part is CI seems happy with below format of
> > > > copyright,
> > and
> > > this issue only happens on INF file but not on the *.c and *.h.
> > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > > >
> > > > Any idea on this?
> > > > Abner
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-19  2:48           ` Abner Chang
@ 2020-10-19  3:01             ` Bob Feng
  2020-10-19  3:25               ` Abner Chang
  0 siblings, 1 reply; 18+ messages in thread
From: Bob Feng @ 2020-10-19  3:01 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io,
	gaoliming, spbrogan@outlook.com, shenglei.zhang@intel.com
  Cc: 'Bret Barkelew', 'Sean Brogan'

Yes.

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com> 
Sent: Monday, October 19, 2020 10:48 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; spbrogan@outlook.com; shenglei.zhang@intel.com
Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: RE: [edk2-devel] CI test on copyright

Hi Bob,
So the fix was only applied on c and h file as your mentioned? If so then we need a BZ to add the same rule on the files other then c and h.

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
> Bob Feng
> Sent: Monday, October 19, 2020 10:25 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 
> spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS 
> SW/FW Technologist) <abner.chang@hpe.com>
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] CI test on copyright
> 
> For the .c and .h, ECC add the rule to allow (C) Copyright format.
> Looks this bug was not fixed completely.
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D2057&d=DwIGaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> skz6qU3NYRO03nHp9P7Z5q59A3E&m=oWYb80tvgLGP9RZPAmJdv9pqtmSQb
> DbP1z9tdxINhI0&s=KduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4-
> mbW5cF4&e=
> 
> Need file a new Bugzilla and fix this issue.
> 
> Thanks,
> Bob
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, October 19, 2020 9:28 AM
> To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io; 
> spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: 回复: [edk2-devel] CI test on copyright
> 
> Bob:
>   Now, the problem is the inconsistent behavior. The same copyright 
> style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP ) 
> in .c can pass ECC, but in .inf file can't pass ECC. I want to know the reason.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Feng, Bob C <bob.c.feng@intel.com>
> > 发送时间: 2020年10月19日 9:25
> > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 
> > spbrogan@outlook.com; shenglei.zhang@intel.com;
> abner.chang@hpe.com
> > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > 主题: RE: [edk2-devel] CI test on copyright
> >
> > In the ECC, the rule to check Copyright is to see if the Copyright 
> > is the first word of a line, and the Copyright should be followed by 
> > a (
> >
> > Liming, for your reference, the code in ECC
> >
> > ## _IsCopyrightLine
> > # check whether current line is copyright line, the criteria is 
> > whether there is case insensitive keyword "Copyright"
> > # followed by zero or more white space characters followed by a "("
> > character # # @param LineContent:  the line need to be checked #
> > @return: True if current line is copyright line, False else #
> >
> > -Bob
> >
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> > gaoliming
> > Sent: Monday, October 19, 2020 9:01 AM
> > To: devel@edk2.groups.io; spbrogan@outlook.com; 
> > shenglei.zhang@intel.com; abner.chang@hpe.com
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: 回复: [edk2-devel] CI test on copyright
> >
> > I will check this issue first.
> >
> > Thanks
> > Liming
> >
> > > -----邮件原件-----
> > > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > > 发送时间: 2020年10月17日 12:46
> > > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com; 
> > > abner.chang@hpe.com
> > > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan 
> > > <sean.brogan@microsoft.com>
> > > 主题: Re: [edk2-devel] CI test on copyright
> > >
> > > ECC stuff was done by Intel. I would defer to them.
> > >
> > > Adding shenglei.zhang@intel.com
> > >
> > > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > > Hi Sean and Bret,
> > > > I got the CI test error which says the first line in file header 
> > > > section
> > must
> > > have the copyright information, however the copyright is there and 
> > > looks
> > to
> > > me fine as below,
> > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > >
> > > > [cid:image001.png@01D6A351.31688460]
> > > >
> > > >
> > > > The interesting part is CI seems happy with below format of 
> > > > copyright,
> > and
> > > this issue only happens on INF file but not on the *.c and *.h.
> > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > > >
> > > > Any idea on this?
> > > > Abner
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-19  3:01             ` Bob Feng
@ 2020-10-19  3:25               ` Abner Chang
  2020-10-19  4:56                 ` 回复: " gaoliming
  0 siblings, 1 reply; 18+ messages in thread
From: Abner Chang @ 2020-10-19  3:25 UTC (permalink / raw)
  To: Feng, Bob C, devel@edk2.groups.io, gaoliming,
	spbrogan@outlook.com, shenglei.zhang@intel.com
  Cc: 'Bret Barkelew', 'Sean Brogan'

Ok. I will submit an one.

Thanks Bob and Liming.

> -----Original Message-----
> From: Feng, Bob C [mailto:bob.c.feng@intel.com]
> Sent: Monday, October 19, 2020 11:01 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>;
> spbrogan@outlook.com; shenglei.zhang@intel.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel] CI test on copyright
> 
> Yes.
> 
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Monday, October 19, 2020 10:48 AM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming
> <gaoliming@byosoft.com.cn>; spbrogan@outlook.com;
> shenglei.zhang@intel.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel] CI test on copyright
> 
> Hi Bob,
> So the fix was only applied on c and h file as your mentioned? If so then we
> need a BZ to add the same rule on the files other then c and h.
> 
> Thanks
> Abner
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Bob Feng
> > Sent: Monday, October 19, 2020 10:25 AM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> > spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS
> > SW/FW Technologist) <abner.chang@hpe.com>
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: Re: [edk2-devel] CI test on copyright
> >
> > For the .c and .h, ECC add the rule to allow (C) Copyright format.
> > Looks this bug was not fixed completely.
> > INVALID URI REMOVED
> > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> >
> 3D2057&d=DwIGaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> >
> skz6qU3NYRO03nHp9P7Z5q59A3E&m=oWYb80tvgLGP9RZPAmJdv9pqtmSQb
> > DbP1z9tdxINhI0&s=KduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4-
> > mbW5cF4&e=
> >
> > Need file a new Bugzilla and fix this issue.
> >
> > Thanks,
> > Bob
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, October 19, 2020 9:28 AM
> > To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io;
> > spbrogan@outlook.com; shenglei.zhang@intel.com;
> abner.chang@hpe.com
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: 回复: [edk2-devel] CI test on copyright
> >
> > Bob:
> >   Now, the problem is the inconsistent behavior. The same copyright
> > style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP )
> > in .c can pass ECC, but in .inf file can't pass ECC. I want to know the reason.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Feng, Bob C <bob.c.feng@intel.com>
> > > 发送时间: 2020年10月19日 9:25
> > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn;
> > > spbrogan@outlook.com; shenglei.zhang@intel.com;
> > abner.chang@hpe.com
> > > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > <sean.brogan@microsoft.com>
> > > 主题: RE: [edk2-devel] CI test on copyright
> > >
> > > In the ECC, the rule to check Copyright is to see if the Copyright
> > > is the first word of a line, and the Copyright should be followed by
> > > a (
> > >
> > > Liming, for your reference, the code in ECC
> > >
> > > ## _IsCopyrightLine
> > > # check whether current line is copyright line, the criteria is
> > > whether there is case insensitive keyword "Copyright"
> > > # followed by zero or more white space characters followed by a "("
> > > character # # @param LineContent:  the line need to be checked #
> > > @return: True if current line is copyright line, False else #
> > >
> > > -Bob
> > >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > gaoliming
> > > Sent: Monday, October 19, 2020 9:01 AM
> > > To: devel@edk2.groups.io; spbrogan@outlook.com;
> > > shenglei.zhang@intel.com; abner.chang@hpe.com
> > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > <sean.brogan@microsoft.com>
> > > Subject: 回复: [edk2-devel] CI test on copyright
> > >
> > > I will check this issue first.
> > >
> > > Thanks
> > > Liming
> > >
> > > > -----邮件原件-----
> > > > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > > > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > > > 发送时间: 2020年10月17日 12:46
> > > > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> > > > abner.chang@hpe.com
> > > > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> > > > <sean.brogan@microsoft.com>
> > > > 主题: Re: [edk2-devel] CI test on copyright
> > > >
> > > > ECC stuff was done by Intel. I would defer to them.
> > > >
> > > > Adding shenglei.zhang@intel.com
> > > >
> > > > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > > > Hi Sean and Bret,
> > > > > I got the CI test error which says the first line in file header
> > > > > section
> > > must
> > > > have the copyright information, however the copyright is there and
> > > > looks
> > > to
> > > > me fine as below,
> > > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > > >
> > > > > [cid:image001.png@01D6A351.31688460]
> > > > >
> > > > >
> > > > > The interesting part is CI seems happy with below format of
> > > > > copyright,
> > > and
> > > > this issue only happens on INF file but not on the *.c and *.h.
> > > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > > > >
> > > > > Any idea on this?
> > > > > Abner
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> > 
> >
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* 回复: [edk2-devel] CI test on copyright
  2020-10-19  3:25               ` Abner Chang
@ 2020-10-19  4:56                 ` gaoliming
  2020-10-19  5:08                   ` Abner Chang
  0 siblings, 1 reply; 18+ messages in thread
From: gaoliming @ 2020-10-19  4:56 UTC (permalink / raw)
  To: devel, abner.chang, 'Feng, Bob C', spbrogan,
	shenglei.zhang
  Cc: 'Bret Barkelew', 'Sean Brogan'

Abner:
  You have submitted https://bugzilla.tianocore.org/show_bug.cgi?id=3011 for this issue. We can use it to track the fix. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66373+4905953+8761045@groups.io
> <bounce+27952+66373+4905953+8761045@groups.io> 代表 Abner Chang
> 发送时间: 2020年10月19日 11:26
> 收件人: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io;
> gaoliming <gaoliming@byosoft.com.cn>; spbrogan@outlook.com;
> shenglei.zhang@intel.com
> 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> 主题: Re: [edk2-devel] CI test on copyright
> 
> Ok. I will submit an one.
> 
> Thanks Bob and Liming.
> 
> > -----Original Message-----
> > From: Feng, Bob C [mailto:bob.c.feng@intel.com]
> > Sent: Monday, October 19, 2020 11:01 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>;
> > spbrogan@outlook.com; shenglei.zhang@intel.com
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: RE: [edk2-devel] CI test on copyright
> >
> > Yes.
> >
> > -----Original Message-----
> > From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> > Sent: Monday, October 19, 2020 10:48 AM
> > To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming
> > <gaoliming@byosoft.com.cn>; spbrogan@outlook.com;
> > shenglei.zhang@intel.com
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: RE: [edk2-devel] CI test on copyright
> >
> > Hi Bob,
> > So the fix was only applied on c and h file as your mentioned? If so then we
> > need a BZ to add the same rule on the files other then c and h.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > > Bob Feng
> > > Sent: Monday, October 19, 2020 10:25 AM
> > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> > > spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS
> > > SW/FW Technologist) <abner.chang@hpe.com>
> > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > <sean.brogan@microsoft.com>
> > > Subject: Re: [edk2-devel] CI test on copyright
> > >
> > > For the .c and .h, ECC add the rule to allow (C) Copyright format.
> > > Looks this bug was not fixed completely.
> > > INVALID URI REMOVED
> > > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> > >
> >
> 3D2057&d=DwIGaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> > >
> >
> skz6qU3NYRO03nHp9P7Z5q59A3E&m=oWYb80tvgLGP9RZPAmJdv9pqtmSQb
> > > DbP1z9tdxINhI0&s=KduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4-
> > > mbW5cF4&e=
> > >
> > > Need file a new Bugzilla and fix this issue.
> > >
> > > Thanks,
> > > Bob
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Monday, October 19, 2020 9:28 AM
> > > To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io;
> > > spbrogan@outlook.com; shenglei.zhang@intel.com;
> > abner.chang@hpe.com
> > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > <sean.brogan@microsoft.com>
> > > Subject: 回复: [edk2-devel] CI test on copyright
> > >
> > > Bob:
> > >   Now, the problem is the inconsistent behavior. The same copyright
> > > style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP )
> > > in .c can pass ECC, but in .inf file can't pass ECC. I want to know the
> reason.
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: Feng, Bob C <bob.c.feng@intel.com>
> > > > 发送时间: 2020年10月19日 9:25
> > > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn;
> > > > spbrogan@outlook.com; shenglei.zhang@intel.com;
> > > abner.chang@hpe.com
> > > > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > > <sean.brogan@microsoft.com>
> > > > 主题: RE: [edk2-devel] CI test on copyright
> > > >
> > > > In the ECC, the rule to check Copyright is to see if the Copyright
> > > > is the first word of a line, and the Copyright should be followed by
> > > > a (
> > > >
> > > > Liming, for your reference, the code in ECC
> > > >
> > > > ## _IsCopyrightLine
> > > > # check whether current line is copyright line, the criteria is
> > > > whether there is case insensitive keyword "Copyright"
> > > > # followed by zero or more white space characters followed by a "("
> > > > character # # @param LineContent:  the line need to be checked #
> > > > @return: True if current line is copyright line, False else #
> > > >
> > > > -Bob
> > > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > gaoliming
> > > > Sent: Monday, October 19, 2020 9:01 AM
> > > > To: devel@edk2.groups.io; spbrogan@outlook.com;
> > > > shenglei.zhang@intel.com; abner.chang@hpe.com
> > > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > > <sean.brogan@microsoft.com>
> > > > Subject: 回复: [edk2-devel] CI test on copyright
> > > >
> > > > I will check this issue first.
> > > >
> > > > Thanks
> > > > Liming
> > > >
> > > > > -----邮件原件-----
> > > > > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > > > > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > > > > 发送时间: 2020年10月17日 12:46
> > > > > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> > > > > abner.chang@hpe.com
> > > > > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> > > > > <sean.brogan@microsoft.com>
> > > > > 主题: Re: [edk2-devel] CI test on copyright
> > > > >
> > > > > ECC stuff was done by Intel. I would defer to them.
> > > > >
> > > > > Adding shenglei.zhang@intel.com
> > > > >
> > > > > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > > > > Hi Sean and Bret,
> > > > > > I got the CI test error which says the first line in file header
> > > > > > section
> > > > must
> > > > > have the copyright information, however the copyright is there and
> > > > > looks
> > > > to
> > > > > me fine as below,
> > > > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > > > >
> > > > > > [cid:image001.png@01D6A351.31688460]
> > > > > >
> > > > > >
> > > > > > The interesting part is CI seems happy with below format of
> > > > > > copyright,
> > > > and
> > > > > this issue only happens on INF file but not on the *.c and *.h.
> > > > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > > > > >
> > > > > > Any idea on this?
> > > > > > Abner
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [edk2-devel] CI test on copyright
  2020-10-19  4:56                 ` 回复: " gaoliming
@ 2020-10-19  5:08                   ` Abner Chang
  0 siblings, 0 replies; 18+ messages in thread
From: Abner Chang @ 2020-10-19  5:08 UTC (permalink / raw)
  To: gaoliming, devel@edk2.groups.io, 'Feng, Bob C',
	spbrogan@outlook.com, shenglei.zhang@intel.com
  Cc: 'Bret Barkelew', 'Sean Brogan'

Ah yes. I totally forget this. Thanks for the reminder.

> -----Original Message-----
> From: gaoliming [mailto:gaoliming@byosoft.com.cn]
> Sent: Monday, October 19, 2020 12:57 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; 'Feng, Bob C' <bob.c.feng@intel.com>;
> spbrogan@outlook.com; shenglei.zhang@intel.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: 回复: [edk2-devel] CI test on copyright
> 
> Abner:
>   You have submitted INVALID URI REMOVED
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D3011&d=DwIFaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulks
> kz6qU3NYRO03nHp9P7Z5q59A3E&m=vaB6hNbJbPOmQ8yaMFNWsRlvo07_u
> UgGuoezMKsV_Ho&s=Lq7nvu3edPECva-
> LC8iZY1I2_UjzvJh2zF1onHnzXw4&e=  for this issue. We can use it to track the
> fix.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+66373+4905953+8761045@groups.io
> > <bounce+27952+66373+4905953+8761045@groups.io> 代表 Abner Chang
> > 发送时间: 2020年10月19日 11:26
> > 收件人: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io;
> > gaoliming <gaoliming@byosoft.com.cn>; spbrogan@outlook.com;
> > shenglei.zhang@intel.com
> > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > 主题: Re: [edk2-devel] CI test on copyright
> >
> > Ok. I will submit an one.
> >
> > Thanks Bob and Liming.
> >
> > > -----Original Message-----
> > > From: Feng, Bob C [mailto:bob.c.feng@intel.com]
> > > Sent: Monday, October 19, 2020 11:01 AM
> > > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > > devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>;
> > > spbrogan@outlook.com; shenglei.zhang@intel.com
> > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > <sean.brogan@microsoft.com>
> > > Subject: RE: [edk2-devel] CI test on copyright
> > >
> > > Yes.
> > >
> > > -----Original Message-----
> > > From: Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> > > Sent: Monday, October 19, 2020 10:48 AM
> > > To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>;
> > > gaoliming <gaoliming@byosoft.com.cn>; spbrogan@outlook.com;
> > > shenglei.zhang@intel.com
> > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > <sean.brogan@microsoft.com>
> > > Subject: RE: [edk2-devel] CI test on copyright
> > >
> > > Hi Bob,
> > > So the fix was only applied on c and h file as your mentioned? If so
> > > then we need a BZ to add the same rule on the files other then c and h.
> > >
> > > Thanks
> > > Abner
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Bob Feng
> > > > Sent: Monday, October 19, 2020 10:25 AM
> > > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> > > > spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS
> > > > SW/FW Technologist) <abner.chang@hpe.com>
> > > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > > <sean.brogan@microsoft.com>
> > > > Subject: Re: [edk2-devel] CI test on copyright
> > > >
> > > > For the .c and .h, ECC add the rule to allow (C) Copyright format.
> > > > Looks this bug was not fixed completely.
> > > > INVALID URI REMOVED
> > > > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> > > >
> > >
> >
> 3D2057&d=DwIGaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> > > >
> > >
> >
> skz6qU3NYRO03nHp9P7Z5q59A3E&m=oWYb80tvgLGP9RZPAmJdv9pqtmSQb
> > > > DbP1z9tdxINhI0&s=KduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4-
> > > > mbW5cF4&e=
> > > >
> > > > Need file a new Bugzilla and fix this issue.
> > > >
> > > > Thanks,
> > > > Bob
> > > > -----Original Message-----
> > > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > > Sent: Monday, October 19, 2020 9:28 AM
> > > > To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io;
> > > > spbrogan@outlook.com; shenglei.zhang@intel.com;
> > > abner.chang@hpe.com
> > > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > > <sean.brogan@microsoft.com>
> > > > Subject: 回复: [edk2-devel] CI test on copyright
> > > >
> > > > Bob:
> > > >   Now, the problem is the inconsistent behavior. The same
> > > > copyright style ((C) Copyright 2020 Hewlett Packard Enterprise
> > > > Development LP ) in .c can pass ECC, but in .inf file can't pass
> > > > ECC. I want to know the
> > reason.
> > > >
> > > > Thanks
> > > > Liming
> > > > > -----邮件原件-----
> > > > > 发件人: Feng, Bob C <bob.c.feng@intel.com>
> > > > > 发送时间: 2020年10月19日 9:25
> > > > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn;
> > > > > spbrogan@outlook.com; shenglei.zhang@intel.com;
> > > > abner.chang@hpe.com
> > > > > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > > > <sean.brogan@microsoft.com>
> > > > > 主题: RE: [edk2-devel] CI test on copyright
> > > > >
> > > > > In the ECC, the rule to check Copyright is to see if the
> > > > > Copyright is the first word of a line, and the Copyright should
> > > > > be followed by a (
> > > > >
> > > > > Liming, for your reference, the code in ECC
> > > > >
> > > > > ## _IsCopyrightLine
> > > > > # check whether current line is copyright line, the criteria is
> > > > > whether there is case insensitive keyword "Copyright"
> > > > > # followed by zero or more white space characters followed by a "("
> > > > > character # # @param LineContent:  the line need to be checked #
> > > > > @return: True if current line is copyright line, False else #
> > > > >
> > > > > -Bob
> > > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > gaoliming
> > > > > Sent: Monday, October 19, 2020 9:01 AM
> > > > > To: devel@edk2.groups.io; spbrogan@outlook.com;
> > > > > shenglei.zhang@intel.com; abner.chang@hpe.com
> > > > > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > > > > <sean.brogan@microsoft.com>
> > > > > Subject: 回复: [edk2-devel] CI test on copyright
> > > > >
> > > > > I will check this issue first.
> > > > >
> > > > > Thanks
> > > > > Liming
> > > > >
> > > > > > -----邮件原件-----
> > > > > > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > > > > > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > > > > > 发送时间: 2020年10月17日 12:46
> > > > > > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> > > > > > abner.chang@hpe.com
> > > > > > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> > > > > > <sean.brogan@microsoft.com>
> > > > > > 主题: Re: [edk2-devel] CI test on copyright
> > > > > >
> > > > > > ECC stuff was done by Intel. I would defer to them.
> > > > > >
> > > > > > Adding shenglei.zhang@intel.com
> > > > > >
> > > > > > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > > > > > Hi Sean and Bret,
> > > > > > > I got the CI test error which says the first line in file
> > > > > > > header section
> > > > > must
> > > > > > have the copyright information, however the copyright is there
> > > > > > and looks
> > > > > to
> > > > > > me fine as below,
> > > > > > > (C) Copyright 2020 Hewlett Packard Enterprise Development
> > > > > > > LP<BR>
> > > > > > >
> > > > > > > [cid:image001.png@01D6A351.31688460]
> > > > > > >
> > > > > > >
> > > > > > > The interesting part is CI seems happy with below format of
> > > > > > > copyright,
> > > > > and
> > > > > > this issue only happens on INF file but not on the *.c and *.h.
> > > > > > > Copyright (C) 2020 Hewlett Packard Enterprise Development
> > > > > > > LP<BR>
> > > > > > >
> > > > > > > Any idea on this?
> > > > > > > Abner
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> > 
> >
> 
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2020-10-19  5:08 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-15 16:21 CI test on copyright Abner Chang
2020-10-15 16:24 ` Bret Barkelew
2020-10-15 16:32   ` Abner Chang
2020-10-15 16:34     ` Bret Barkelew
2020-10-16  1:07       ` [edk2-devel] " Abner Chang
2020-10-16  1:15         ` 回复: " gaoliming
2020-10-16  1:19           ` Abner Chang
     [not found]           ` <163E54449E0DFAB5.31077@groups.io>
2020-10-16  1:25             ` Abner Chang
2020-10-17  4:45 ` Sean
2020-10-19  1:01   ` 回复: " gaoliming
2020-10-19  1:24     ` Bob Feng
2020-10-19  1:28       ` 回复: " gaoliming
2020-10-19  2:24         ` Bob Feng
2020-10-19  2:48           ` Abner Chang
2020-10-19  3:01             ` Bob Feng
2020-10-19  3:25               ` Abner Chang
2020-10-19  4:56                 ` 回复: " gaoliming
2020-10-19  5:08                   ` Abner Chang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox