From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <michael.kubacki@outlook.com>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Zhiguang Liu'" <zhiguang.liu@intel.com>
Subject: 回复: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value
Date: Fri, 18 Sep 2020 09:08:15 +0800 [thread overview]
Message-ID: <000c01d68d58$303bc430$90b34c90$@byosoft.com.cn> (raw)
In-Reply-To: <MWHPR07MB3440C4B0B54402B0889A415AE93E0@MWHPR07MB3440.namprd07.prod.outlook.com>
Michael:
Here is pull request https://github.com/tianocore/edk2/pull/936
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+65387+4905953+8761045@groups.io
> <bounce+27952+65387+4905953+8761045@groups.io> 代表 Michael
> Kubacki
> 发送时间: 2020年9月18日 0:49
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu'
> <zhiguang.liu@intel.com>
> 主题: Re: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct
> EFI_BLOCK_IO_PROTOCOL_REVISION3 value
>
> Hi Liming,
>
> I have rebased this commit and added all Reviewed-bys on:
> https://github.com/makubacki/edk2/commits/fix_block_io_protocol_rev3_va
> lue
>
> Please PR it when you are ready.
>
> Thanks,
> Michael
>
> On 9/14/2020 5:54 PM, gaoliming wrote:
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> >> -----邮件原件-----
> >> 发件人: bounce+27952+65228+4905953+8761045@groups.io
> >> <bounce+27952+65228+4905953+8761045@groups.io> 代表 Michael
> >> Kubacki
> >> 发送时间: 2020年9月15日 2:11
> >> 收件人: devel@edk2.groups.io
> >> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> >> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> >> 主题: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct
> >> EFI_BLOCK_IO_PROTOCOL_REVISION3 value
> >>
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2961
> >>
> >> The value of EFI_BLOCK_IO_PROTOCOL_REVISION3 is currently
> >> 0x00020031. However, the value assigned in the UEFI Specification
> >> 2.8B is ((2<<16) | (31)) which is 0x0002001F.
> >>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >> ---
> >> MdePkg/Include/Protocol/BlockIo.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/MdePkg/Include/Protocol/BlockIo.h
> >> b/MdePkg/Include/Protocol/BlockIo.h
> >> index 7b332691ede3..3bd76885e11c 100644
> >> --- a/MdePkg/Include/Protocol/BlockIo.h
> >> +++ b/MdePkg/Include/Protocol/BlockIo.h
> >> @@ -201,7 +201,7 @@ typedef struct {
> >>
> >> #define EFI_BLOCK_IO_PROTOCOL_REVISION 0x00010000
> >> #define EFI_BLOCK_IO_PROTOCOL_REVISION2 0x00020001
> >> -#define EFI_BLOCK_IO_PROTOCOL_REVISION3 0x00020031
> >> +#define EFI_BLOCK_IO_PROTOCOL_REVISION3 0x0002001F
> >>
> >> ///
> >> /// Revision defined in EFI1.1.
> >> --
> >> 2.28.0.windows.1
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
>
>
>
>
next prev parent reply other threads:[~2020-09-18 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 18:11 [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value Michael Kubacki
2020-09-15 0:54 ` 回复: [edk2-devel] " gaoliming
2020-09-17 16:49 ` Michael Kubacki
2020-09-18 1:08 ` gaoliming [this message]
2020-09-15 3:27 ` Zhiguang Liu
2020-09-18 1:25 ` [edk2-devel] " Ni, Ray
2020-09-18 18:54 ` Michael Kubacki
2020-09-18 23:53 ` Ni, Ray
2020-09-19 0:26 ` Michael Kubacki
2020-09-21 2:28 ` Ni, Ray
2020-09-21 20:00 ` Michael Kubacki
2020-09-22 1:22 ` 回复: " gaoliming
2020-09-22 21:34 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01d68d58$303bc430$90b34c90$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox