From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.2141.1613619152632019564 for ; Wed, 17 Feb 2021 19:32:33 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 18 Feb 2021 11:32:01 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: , , , , References: <20210217101032.2822164-1-patrick.rudolph@9elements.com> In-Reply-To: <20210217101032.2822164-1-patrick.rudolph@9elements.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIC0gcmVzZW5kXSBNZGVNb2R1bGVQa2cvQm9vdExvZ29MaWI6IENlbnRlciBsb2dvIDM4LjIlIGZyb20gdG9wIG9mIHNjcmVlbg==?= Date: Thu, 18 Feb 2021 11:32:03 +0800 Message-ID: <000c01d705a6$a0366b70$e0a34250$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKAmTihq3XbJ3Bn4026LsAzWb4VvqkKGhxA Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Patrick: I am OK for this extension to meet with Microsoft recommendation. This change is a new feature. Can you submit one BZ (https://bugzilla.tianocore.org/) for it? =20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+71716+4905953+8761045@groups.io > =B4=FA=B1=ED Patrick > Rudolph > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA2=D4=C217=C8=D5 18:11 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: tcrawford@system76.com; jian.j.wang@intel.com; > hao.a.wu@intel.com; zhichao.gao@intel.com; ray.ni@intel.com > =D6=F7=CC=E2: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: = Center > logo 38.2% from top of screen >=20 > From: Tim Crawford >=20 > Use Microsoft's recommended positioning [1] for the boot logo. >=20 > > We recommend that the logo is placed with its center at 38.2% from = the > > screen's top edge. This positioning is based on the golden ratio's > > visual aesthetics and matches the Windows 10 design proportions. >=20 > [1]: > = https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-s > creen-components#position-the-logo-during-post >=20 > Based on Tim Crawford initial commit. >=20 > Signed-off-by: Patrick Rudolph > --- > MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ++++ > MdeModulePkg/Logo/Logo.c | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h > b/MdeModulePkg/Include/Protocol/PlatformLogo.h > index 55c9e08696..21a4c79e1d 100644 > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h > @@ -29,7 +29,8 @@ typedef enum { > EdkiiPlatformLogoDisplayAttributeCenterBottom, >=20 > EdkiiPlatformLogoDisplayAttributeLeftBottom, >=20 > EdkiiPlatformLogoDisplayAttributeCenterLeft, >=20 > - EdkiiPlatformLogoDisplayAttributeCenter >=20 > + EdkiiPlatformLogoDisplayAttributeCenter, >=20 > + EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended >=20 > } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE; >=20 >=20 >=20 > /** >=20 > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > index 134660f28d..d40c65b59f 100644 > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > @@ -173,6 +173,10 @@ BootLogoEnableLogo ( > DestX =3D 0; >=20 > DestY =3D (SizeOfY - Image.Height) / 2; >=20 > break; >=20 > + case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended: >=20 > + DestX =3D (SizeOfX - Image.Width) / 2; >=20 > + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2; >=20 > + break; >=20 > case EdkiiPlatformLogoDisplayAttributeCenter: >=20 > DestX =3D (SizeOfX - Image.Width) / 2; >=20 > DestY =3D (SizeOfY - Image.Height) / 2; >=20 > diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > index c647253ecd..131a1b456a 100644 > --- a/MdeModulePkg/Logo/Logo.c > +++ b/MdeModulePkg/Logo/Logo.c > @@ -26,7 +26,7 @@ EFI_HII_HANDLE mHiiHandle; > LOGO_ENTRY mLogos[] =3D { >=20 > { >=20 > IMAGE_TOKEN (IMG_LOGO), >=20 > - EdkiiPlatformLogoDisplayAttributeCenter, >=20 > + EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended, >=20 > 0, >=20 > 0 >=20 > } >=20 > -- > 2.26.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#71716): = https://edk2.groups.io/g/devel/message/71716 > Mute This Topic: https://groups.io/mt/80700289/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20