From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.1646.1648687877621198161 for ; Wed, 30 Mar 2022 17:51:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([101.224.116.119]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 31 Mar 2022 08:51:11 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.224.116.119 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , References: <20220329063703.549-1-yu.pu@intel.com> In-Reply-To: <20220329063703.549-1-yu.pu@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDAwLzE1XSBNZXJnZSBVZWZpQ3B1TGliIHRvIENwdUxpYg==?= Date: Thu, 31 Mar 2022 08:51:04 +0800 Message-ID: <000c01d84499$6c9c5760$45d50620$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGnUZpdJ9C2U5HTouj+d3zCOdobGq06j2pw Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn The change in MdePkg is good to me. Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io = =B4=FA=B1=ED Yu Pu > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA3=D4=C229=C8=D5 14:37 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Yu Pu > =D6=F7=CC=E2: [edk2-devel] [PATCH v1 00/15] Merge UefiCpuLib to CpuLib >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3394 >=20 >=20 >=20 > Today lots of duplicated code call CPUID and calculates the address >=20 > mask. Adding an API named GetPhysicalAddressBits in UefiCpuLib can >=20 > solve this problem, but at the same time cause MdeModulePkg depend >=20 > on UefiCpuPkg which does not meet the design spec. So merge UefiCpuLib >=20 > to CpuLib is a good way to sovle these problems. To minimize the = impact, >=20 > this operation is divided into four steps. >=20 > Yu Pu (15): > IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib > IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on > UefiCpuLib. > MdePkg: Add CpuLib to module INFs that depend on UefiCpuLib. > OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib. > UefiCpuPkg: Add CpuLib to module INFs that depend on UefiCpuLib. > UefiPayloadPkg: Add CpuLib to module INFs that depend on = UefiCpuLib. > MdePkg: Move API and implementation from UefiCpuLib to CpuLib > UefiCpuPkg: Move API and implementation from UefiCpuLib to CpuLib > IntelFsp2Pkg: Remove UefiCpuLib from module INFs. > OvmfPkg: Remove UefiCpuLib from module INFs. > PcAtChipsetPkg: Remove UefiCpuLib from module INFs. > SourceLevelDebugPkg: Remove UefiCpuLib from module INFs. > UefiCpuPkg: Remove UefiCpuLib from module INFs. > UefiPayloadPkg: Remove UefiCpuLib from module INFs. > UefiCpuLib: Remove UefiCpuLib. >=20 > MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c > | 122 ++++++++++++++++++++ > OvmfPkg/Sec/SecMain.c > | 2 +- > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c > | 81 ------------- > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c > | 2 +- > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c > | 2 +- > IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf > | 2 +- > IntelFsp2Pkg/FspSecCore/SecMain.h > | 2 +- > IntelFsp2Pkg/IntelFsp2Pkg.dsc > | 1 - > IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc > | 1 - > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > | 2 +- > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf > | 2 +- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > | 1 - > MdePkg/Include/Library/CpuLib.h > | 65 +++++++++++ > MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > | 6 + > {UefiCpuPkg/Library/BaseUefiCpuLib =3D> > MdePkg/Library/BaseCpuLib}/Ia32/InitializeFpu.nasm | 0 > {UefiCpuPkg/Library/BaseUefiCpuLib =3D> > MdePkg/Library/BaseCpuLib}/X64/InitializeFpu.nasm | 0 > MdePkg/MdeLibs.dsc.inc > | 1 + > OvmfPkg/AmdSev/AmdSevX64.dsc > | 1 - > OvmfPkg/Bhyve/BhyveX64.dsc > | 1 - > OvmfPkg/CloudHv/CloudHvX64.dsc > | 1 - > OvmfPkg/Microvm/MicrovmX64.dsc > | 1 - > OvmfPkg/OvmfPkgIa32.dsc > | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc > | 1 - > OvmfPkg/OvmfPkgX64.dsc > | 1 - > OvmfPkg/OvmfXen.dsc > | 1 - > OvmfPkg/Sec/SecMain.inf > | 2 +- > PcAtChipsetPkg/PcAtChipsetPkg.dsc > | 1 - > SourceLevelDebugPkg/SourceLevelDebugPkg.dsc > | 1 - > UefiCpuPkg/CpuDxe/CpuDxe.h > | 1 - > UefiCpuPkg/CpuDxe/CpuDxe.inf > | 1 - > UefiCpuPkg/Include/Library/UefiCpuLib.h > | 65 ----------- > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > | 41 ------- > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.uni > | 16 --- > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > | 2 +- > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > | 2 +- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > | 1 - > UefiCpuPkg/Library/MpInitLib/MpLib.h > | 1 - > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > | 1 - > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > | 1 - > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h > | 1 - > UefiCpuPkg/SecCore/SecCore.inf > | 2 +- > UefiCpuPkg/SecCore/SecCoreNative.inf > | 2 +- > UefiCpuPkg/SecCore/SecMain.h > | 2 +- > UefiCpuPkg/UefiCpuPkg.dec > | 5 - > UefiCpuPkg/UefiCpuPkg.dsc > | 2 - > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h > | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > | 2 +- > UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf > | 2 +- > UefiPayloadPkg/UefiPayloadPkg.dsc > | 1 - > 50 files changed, 211 insertions(+), 248 deletions(-) > create mode 100644 MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c > delete mode 100644 UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c > rename {UefiCpuPkg/Library/BaseUefiCpuLib =3D> > MdePkg/Library/BaseCpuLib}/Ia32/InitializeFpu.nasm (100%) > rename {UefiCpuPkg/Library/BaseUefiCpuLib =3D> > MdePkg/Library/BaseCpuLib}/X64/InitializeFpu.nasm (100%) > delete mode 100644 UefiCpuPkg/Include/Library/UefiCpuLib.h > delete mode 100644 > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > delete mode 100644 > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.uni >=20 > -- > 2.30.0.windows.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#88187): = https://edk2.groups.io/g/devel/message/88187 > Mute This Topic: https://groups.io/mt/90116960/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20