From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cloud-regular.263xmail.com (cloud-regular.263xmail.com [211.157.131.133]) by mx.groups.io with SMTP id smtpd.web12.883.1655169129425486713 for ; Mon, 13 Jun 2022 18:12:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: byosoft.com.cn, ip: 211.157.131.133, mailfrom: gaoliming@byosoft.com.cn) Received: from gaoliming?byosoft.com.cn (unknown [192.168.165.166]) by cloud-regular.263xmail.com (Postfix) with ESMTP id 08B1E1FF00A for ; Tue, 14 Jun 2022 09:11:59 +0800 (CST) X-263anti-spam: KSV:0;bpcheck:1; X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from mail.byosoft.com.cn (localhost [127.0.0.1]) by proxysmtp.263.net (Postfix) with SMTP id 9BABA1C326 for ; Tue, 14 Jun 2022 09:11:59 +0800 (CST) X-RL-SENDER: gaoliming@byosoft.com.cn X-FST-TO: devel@edk2.groups.io X-SENDER-IP: 58.240.74.242 X-LOGIN-NAME: X-UNIQUE-TAG: <44cbaf8de8f787746ecad37871c2bf0d> X-SENDER: gaoliming@byosoft.com.cn X-DNS-TYPE: 0 Received: from mail.byosoft.com.cn (unknown [58.240.74.242]) by proxysmtp.263.net (Postfix) whith SMTP id 4592ISC3D8; Tue, 14 Jun 2022 09:11:59 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 14 Jun 2022 09:11:51 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Pedro Falcato'" Cc: "'edk2-devel-groups-io'" , "'Leif Lindholm'" , "'Michael D Kinney'" , "'Zhiguang Liu'" References: <20220407220146.149580-1-pedro.falcato@gmail.com> <16E9330A7A87074F.18109@groups.io> <16EE1DD8FA9A45F3.9448@groups.io> <00f801d8762d$7a24fd40$6e6ef7c0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIGVkazItcGxhdGZvcm1zIDAvM10gRXh0NFBrZzogQWRkIGV4dDIvMyBzdXBwb3J0IGFuZCBtb3ZlIGNyYzE2LzMyYyB0byBCYXNlTGli?= Date: Tue, 14 Jun 2022 09:11:59 +0800 Message-ID: <000c01d87f8b$bf94c790$3ebe56b0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI13qJ0wLmD4RK0XAEXqcCpyGJjbwNOhEO8AmyQ5wwBv2n19gIlBWksAS9/l36sPOHIYA== Sender: "gaoliming" Content-Type: multipart/alternative; boundary="----=_NextPart_000_000D_01D87FCE.CDBF3380" Content-Language: zh-cn ------=_NextPart_000_000D_01D87FCE.CDBF3380 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pedro: Yes. You can merge this patch with my ACK. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Pedro Falcato =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=8813=E6=97=A5 22= :45 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming =E6=8A=84=E9=80=81: edk2-devel-groups-io ; Leif Lindh= olm ; Michael D Kinney ; Zhi= guang Liu =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Ad= d ext2/3 support and move crc16/32c to BaseLib =20 Liming, =20 Sorry for the question, but can I merge this with your Ack and my RB or do = I have to wait for another RB? I want to solve this as soon as possible since right now Ext4Pkg won't buil= d with upstream edk2. =20 Thanks, Pedro =20 On Thu, Jun 2, 2022 at 4:05 AM gaoliming > wrote: Pedro=EF=BC=9A Thanks for your enhancement to support ext2/3 file system. Acked-by: Limin= g Gao > for thi= s patch set.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Pedro Falcato >=20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=881=E6=97=A5 5:3= 3 =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io >; Pedro Falcato > =E6=8A=84=E9=80=81: Leif Lindholm >; Michael D Kinney >; Liming Gao >; Zhiguang Liu > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Ad= d ext2/3 support and move crc16/32c to BaseLib =20 Ping. Please review now that the stable freeze is over. =20 On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io > wr= ote: Ping. Could someone review these patches? =20 On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io > wr= ote: Ping. If someone could take a look, it would be much appreciated. =20 On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato > wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 Hi all, This patch-set attempts to address two open feature requests for Ext4Pkg by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib = (id 3871). The previous patch-set regarding 3871 attempted to merge the different crc1= 6 implementations but failed because, contrary to what I thought, there are many, many differ= ent CRC16s which are all slightly different. This one (plus the separate edk2 patch) attempt= s to just merge CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. Since this patch set grew to be considerably different from the original, I= didn't mark it as v2 but rather a separate, new patch-set. CC'ing the edk2-platforms stewards (as I cannot review my own code) and the= CC's of the MdePkg patch. Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao = > Cc: Zhiguang Liu > Pedro Falcato (3): Ext4Pkg: Replace the CRC implementations with BaseLib Ext4Pkg: Format using uncrustify Ext4Pkg: Add ext2/3 support Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- 16 files changed, 640 insertions(+), 487 deletions(-) create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c --=20 2.35.1 --=20 Pedro Falcato --=20 Pedro Falcato --=20 Pedro Falcato --=20 Pedro Falcato ------=_NextPart_000_000D_01D87FCE.CDBF3380 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Pedro:

=C2=A0Yes. You can merge this patch with my ACK= .

 <= /o:p>

Thanks

Liming=

=E5=8F=91=E4=BB=B6=E4=BA=BA: Pedro Falcato <pedro.falcato@gmail= .com>
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=8813=E6=97=A5 22:45
=E6=94=B6= =E4=BB=B6=E4=BA=BA: gaolim= ing <gaoliming@byosoft.com.cn>
=E6=8A=84=E9=80=81: edk2-devel-groups-io <devel@= edk2.groups.io>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinn= ey <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.= com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext= 2/3 support and move crc16/32c to BaseLib

 

=

Liming,=

 

Sorry for the qu= estion, but can I merge this with your Ack and my RB or do I have to wait f= or another RB?

I want to solve this as soon as possible since right now Ext4Pk= g won't build with upstream edk2.

 

Thanks,

Pedro

<= /div>

 

On Thu, Jun 2, 2022 at 4:05= AM gaoliming <gaoliming@byo= soft.com.cn> wrote:

Pedro=EF=BC=9A

 Thanks for your enhanceme= nt to support ext2/3 file system. Acked-by: Liming Gao <gaoliming@byosoft.com.cn&= gt; for this patch set.

 

Than= ks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA:= Pedro Falcato <pedro.falcato@gmail.com>
=E5=8F=91=E9=80=81=E6=97=B6= =E9=97=B4: 2022=E5=B9=B46=E6=9C=881=E6=97=A5= 5:33
=E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.groups.io>; Pedro Falcato &= lt;pedro.falca= to@gmail.com>
=E6=8A=84=E9=80=81: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney <<= a href=3D"mailto:michael.d.kinney@intel.com" target=3D"_blank">michael.d.ki= nney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu &l= t;zhiguang.liu@= intel.com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pk= g: Add ext2/3 support and move crc16/32c to BaseLib

 =

Ping. Please review no= w that the stable freeze is over.

 

On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> wrote:

Ping. C= ould someone review these patches?

 

On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> wrote:<= o:p>

Ping. = If someone could take a look, it would be much appreciated.

 

On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato &l= t;pedro.falcat= o@gmail.com> wrote:

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id= =3D3745
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id= =3D3871

Hi all,

This patch-set attempts to address two op= en feature requests for Ext4Pkg
by adding ext2/3 support (id 3745) and m= oving crc16-ansi/crc32c to BaseLib (id 3871).

The previous patch-set= regarding 3871 attempted to merge the different crc16 implementations
b= ut failed because, contrary to what I thought, there are many, many differe= nt CRC16s which
are all slightly different. This one (plus the separate = edk2 patch) attempts to just merge
CRC16-ANSI (confusingly, also known a= s CRC16) into BaseLib.

Since this patch set grew to be considerably = different from the original, I didn't mark it
as v2 but rather a separat= e, new patch-set.

CC'ing the edk2-platforms stewards (as I cannot re= view my own code) and the CC's of the MdePkg
patch.

Cc: Leif Lind= holm <leif@nuviai= nc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: L= iming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Pedro Falcato (3):
  Ext4Pkg: Replace the CRC implementations= with BaseLib
  Ext4Pkg: Format using uncrustify
  Ext4Pkg:= Add ext2/3 support

 Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |&nb= sp; 10 +-
 Features/Ext4Pkg/Ext4Dxe/BlockMap.c   | 279 ++= +++++++++++++++
 Features/Ext4Pkg/Ext4Dxe/Collation.c  | =  4 +-
 Features/Ext4Pkg/Ext4Dxe/Crc16.c      |=   75 -----
 Features/Ext4Pkg/Ext4Dxe/Crc32c.c    &nb= sp;|  84 ------
 Features/Ext4Pkg/Ext4Dxe/Directory.c  |&= nbsp; 13 +-
 Features/Ext4Pkg/Ext4Dxe/DiskUtil.c   | = ;  6 +-
 Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h   |&nbs= p; 30 +-
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    |  9= 5 +++---
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 417 +++= +++++++++++------------
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf = |   3 +-
 Features/Ext4Pkg/Ext4Dxe/Extents.c   = ; |  27 +-
 Features/Ext4Pkg/Ext4Dxe/File.c     = ;  |  19 +-
 Features/Ext4Pkg/Ext4Dxe/Inode.c   = ;   |  33 +-
 Features/Ext4Pkg/Ext4Dxe/Partition.c  = |  12 +-
 Features/Ext4Pkg/Ext4Dxe/Superblock.c |  20 +-<= br> 16 files changed, 640 insertions(+), 487 deletions(-)
 cre= ate mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
 delete mode 10= 0644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
 delete mode 100644 Features/= Ext4Pkg/Ext4Dxe/Crc32c.c

--
2.35.1



--

Pedro Falcato<= /p>



--

Pedro Fal= cato

<= /o:p>



--

= Pedro Falcato



--

Pedro = Falcato

------=_NextPart_000_000D_01D87FCE.CDBF3380--