回复: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

["gaoliming" <gaoliming@byosoft.com.cn>]

Rebecca:
  Is this issue detected in open CI environment? 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+71573+4905953+8761045@groups.io
> <bounce+27952+71573+4905953+8761045@groups.io> 代表 Rebecca Cran
> 发送时间: 2021年2月10日 23:05
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Leif Lindholm
> <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>
> 主题: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build
> 
> The ARM ProcessorSubClassDxe build was broken due to changes in the
> SmbiosProcessor API and an unused variable.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 6
> ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git
> a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> index 0be4403c765f..c78bd41a7e06 100644
> ---
> a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> +++
> b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> @@ -22,7 +22,7 @@
>      @return The cache size.
>  **/
>  UINT64
> -ArmGetCacheSize (
> +SmbiosProcessorGetCacheSize (
>    IN UINT8   CacheLevel,
>    IN BOOLEAN DataCache,
>    IN BOOLEAN UnifiedCache
> @@ -66,14 +66,13 @@ ArmGetCacheSize (
>      @return The cache associativity.
>  **/
>  UINT32
> -ArmGetCacheAssociativity (
> +SmbiosProcessorGetCacheAssociativity (
>    IN UINT8   CacheLevel,
>    IN BOOLEAN DataCache,
>    IN BOOLEAN UnifiedCache
>    )
>  {
>    CCSIDR_DATA  Ccsidr;
> -  CCSIDR2_DATA Ccsidr2;
>    CSSELR_DATA  Csselr;
>    BOOLEAN      CcidxSupported;
>    UINT32       Associativity;
> @@ -88,7 +87,6 @@ ArmGetCacheAssociativity (
>    CcidxSupported = ArmHasCcidx ();
> 
>    if (CcidxSupported) {
> -    Ccsidr2.Data = ReadCCSIDR2 (Csselr.Data);
>      Associativity = Ccsidr.BitsCcidxAA32.Associativity + 1;
>    } else {
>      Associativity = Ccsidr.BitsNonCcidx.Associativity + 1;
> --
> 2.26.2
> 
> 
> 
> 
>