From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.26537.1661219813536227055 for ; Mon, 22 Aug 2022 18:56:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=myA+TKdc; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 50713CD1F72A for ; Tue, 23 Aug 2022 09:56:51 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1661219811; bh=QDTcBYW1CRsNUqV4doa2tWz42gwkxbqC2WNdgMh8YEU=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=myA+TKdcJzzj87ImCquTtyqjOe97sxz3BJbo4abRWJYcyIYAP64wRrGZujHXVFuA0 v3vu6aUOj6iQPj41viUty8ClRSRIgzvs5P6LA/DrsvultkjZkYR7gnp5JJkq/m2mB9 uc/cfpWcJx0+An41DNstQU+EJn0YbejBxuPu4JKk= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 4C2ECCD1F740 for ; Tue, 23 Aug 2022 09:56:51 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 1045BCD1F73C for ; Tue, 23 Aug 2022 09:56:51 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 98302CD1F763 for ; Tue, 23 Aug 2022 09:56:48 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 23 Aug 2022 09:56:47 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Wang, Nickle \(Server BIOS\)'" References: <20220624060747.1800-1-walon.li@hpe.com> <000d01d89b0f$b6127fb0$22377f10$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVNb2R1bGVQa2cvU2V0dXBCcm93c2VyRHhlOkZvbGxvdyBzcGVjJ2Qgd2F5IHRvIHJlY29ubmVjdCBkcml2ZXI=?= Date: Tue, 23 Aug 2022 09:56:47 +0800 Message-ID: <000d01d8b693$9ad15f10$d0741d30$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFb+dmZfWLTvMtOJv4GYaWLidnyKwJfGsYiArWm2OYCDlvRHq58GjsQ Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Walon: Sorry, I miss the patch. Now, we are in the hard feature freeze phase for= stable tag 202208. I will merge it after the stable tag is created on this= Friday. Is it OK? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Li, Walon > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B48=E6=9C=8822=E6=97=A5 = 14:22 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@= edk2.groups.io > =E6=8A=84=E9=80=81: Wang, Nickle (Server BIOS) > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe= :Follow > spec'd way to reconnect driver >=20 > Liming, >=20 > This change is pending for a long time. If anything I can speed this up, = please > let me know. >=20 > Thanks, > Walon >=20 > -----Original Message----- > From: gaoliming > Sent: Tuesday, July 19, 2022 9:35 AM > To: Li, Walon ; devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) > Subject: =E5=9B=9E=E5=A4=8D: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow = spec'd way > to reconnect driver >=20 > Walon: > This change looks good. Reviewed-by: Liming Gao > >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Li, Walon > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8818=E6=97= =A5 9:15 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.co= m.cn > > =E6=8A=84=E9=80=81: Wang, Nickle (Server BIOS) ; L= i, Walon > > > > =E4=B8=BB=E9=A2=98: RE: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spe= c'd way to > > reconnect driver > > > > Hi edk2 and Liming, > > > > Who can help to review this change? Thanks. > > > > -----Original Message----- > > From: Li, Walon > > Sent: Friday, June 24, 2022 2:08 PM > > To: devel@edk2.groups.io > > Cc: Li, Walon ; Wang, Nickle (Server BIOS) > > ; gaoliming@byosoft.com.cn > > Subject: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way to > > reconnect driver > > > > REF:INVALID URI REMOVED > > > g.cgi?id=3D3952__;!!NpxR!hRnrt79sJyc1xTc1OcqqPsjAumIQpguEjpIWG32Jnucw > Rj- > > 4yW6hNAzbkMzBeJw77oFwrnjNZZaZCaX7wBY$ > > > > In UEFI spec, it defines reconnect timing that will be activated upon > exiting of > > the formset or the browser. However, we did't use this kind of way to > check > > reconnect conditioncode. Code only blocks reconnect if page is updated > > dynamically. That's not matched spec'd way. We should check current > formset > > whether is exiting, then reconnect driver. > > > > Signed-off-by: Walon Li > > --- > > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 +--- > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 > +++------ > > 2 files changed, 4 insertions(+), 9 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > index 9587b08d6d..babef21497 100644 > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > @@ -2,7 +2,7 @@ > > Utility functions for UI presentation. Copyright (c) 2004 - 2018, > > Intel Corporation. All rights reserved.
-(C) Copyright 2015 Hewlett > > Packard Enterprise Development LP
+(C) Copyright 2015 - 2022 > > Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: > > BSD-2-Clause-Patent **/@@ -21,7 +21,6 @@ LIST_ENTRY > mRefreshEventList > > =3D INITIALIZE_LIST_HEAD_VARIABLE (mR > > UINT16 mCurFakeQestId; > > FORM_DISPLAY_ENGINE_FORM gDisplayFormData; BOOLEAN > > mFinishRetrieveCall =3D FALSE;-BOOLEAN > > mDynamicFormUpdated =3D FALSE; /** Check whether the ConfigAccess > > protocol is available.@@ -1791,7 +1790,6 @@ FormUpdateNotify ( > > ) { mHiiPackageListUpdated =3D TRUE;- mDynamicFormUpdated > =3D > > TRUE; return EFI_SUCCESS; }diff --git > > a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > index fe0d46d93f..5158baf5bd 100644 > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > @@ -2,7 +2,7 @@ > > Entry and initialization module for the browser. Copyright (c) 2007 > > - > 2018, > > Intel Corporation. All rights reserved.
-(C) Copyright 2020 Hewlett > > Packard Enterprise Development LP
+(C) Copyright 2020 - 2022 > > Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: > > BSD-2-Clause-Patent **/@@ -68,7 +68,6 @@ extern EFI_GUID > > mCurrentFormSetGuid; > > extern EFI_HII_HANDLE mCurrentHiiHandle; extern > UINT16 > > mCurrentFormId; extern FORM_DISPLAY_ENGINE_FORM > > gDisplayFormData;-extern BOOLEAN > > mDynamicFormUpdated; /** Create a menu with specified formset > > GUID and form ID, and add it as a child@@ -539,7 +538,6 @@ SendForm ( > > Selection->FormSet =3D FormSet; mSystemLevelFormSet > =3D > > FormSet;- mDynamicFormUpdated =3D FALSE; // // > > Display this formset@@ -552,10 +550,9 @@ SendForm ( > > mSystemLevelFormSet =3D NULL; //- // If callback > > update form dynamically, it's not exiting of the formset for user so > system do > > not reconnect driver hanlde- // this time.+ // Check incoming > > formset whether is same with previous. If yes, that means action is > > not > exiting > > of formset so do not reconnect controller. //- if > > (!mDynamicFormUpdated && (gFlagReconnect || gCallbackReconnect)) {+ if > > ((gFlagReconnect || gCallbackReconnect) && !CompareGuid > > (&FormSet->Guid, &Selection->FormSetGuid)) { RetVal =3D > > ReconnectController (FormSet->DriverHandle); if (!RetVal) > > { PopupErrorMessage (BROWSER_RECONNECT_FAIL, NULL, > > NULL, NULL);-- > > 2.23.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 >=20