回复: [edk2-devel] CI test on copyright

["gaoliming" <gaoliming@byosoft.com.cn>]

[-- Attachment #1.1: Type: text/plain, Size: 4225 bytes --]

Abner:

 Do you mean the same Copyright in .c doesn’t trig the error message? But,
this Copyright in .inf file will trig the error. If yes, this should be an
issue in ECC checker. Can you submit one BZ? I will check it. 

 

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

 

Thanks

Liming

发件人: bounce+27952+66300+4905953+8761045@groups.io
<bounce+27952+66300+4905953+8761045@groups.io> 代表 Abner Chang
发送时间: 2020年10月16日 9:08
收件人: devel@edk2.groups.io; bret.barkelew@microsoft.com
抄送: Sean Brogan <sean.brogan@microsoft.com>
主题: Re: [edk2-devel] CI test on copyright

 

Hmm, it doesn’t work with below header. Still fail.

 

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

##

 

I had confirmed it again, CI test passed with below one, move “(C)” to
behind Copyright.

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

##

 

From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
[mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Sean Brogan <sean.brogan@microsoft.com
<mailto:sean.brogan@microsoft.com> >
Subject: Re: [edk2-devel] CI test on copyright

 

Try removing the extra line between “SPDX” and “##”.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist) <mailto:abner.chang@hpe.com> 
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com> ;
devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
Cc: Sean Brogan <mailto:sean.brogan@microsoft.com> 
Subject: [EXTERNAL] RE: CI test on copyright

 

 

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

#

##

 

Or you can check the PR,

https://github.com/tianocore/edk2/pull/1019
<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
m%2Ftianocore%2Fedk2%2Fpull%2F1019&data=04%7C01%7CBret.Barkelew%40microsoft.
com%7C76b2a39f7041477ec48508d87127ed6e%7C72f988bf86f141af91ab2d7cd011db47%7C
1%7C0%7C637383763585626301%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8pY6rGL6Z65oTSCyUGOA%
2BsjmQSiwbbQiVJ%2B9LJhGAAM%3D&reserved=0> 

 

Abner

 

From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] 
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Sean Brogan <sean.brogan@microsoft.com
<mailto:sean.brogan@microsoft.com> >
Subject: RE: CI test on copyright

 

Can you share the entire copyright header? In my experience, It’s actually
complaining about one of the ‘#’ or ‘/*’ tags.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist) <mailto:abner.chang@hpe.com> 
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
Cc: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com> ; Sean Brogan
<mailto:sean.brogan@microsoft.com> 
Subject: [EXTERNAL] CI test on copyright

 

Hi Sean and Bret,

I got the CI test error which says the first line in file header section
must have the copyright information, however the copyright is there and
looks to me fine as below,

(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

 



 

 

The interesting part is CI seems happy with below format of copyright, and
this issue only happens on INF file but not on the *.c and *.h.

Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

 

Any idea on this?

Abner

 

 




[-- Attachment #1.2: Type: text/html, Size: 14363 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18194 bytes --]