回复: [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC

["gaoliming" <gaoliming@byosoft.com.cn>]

Pull request for this patch https://github.com/tianocore/edk2/pull/1028

Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2020年10月16日 23:12
> 收件人: michael.kubacki@outlook.com; devel@edk2.groups.io; Kinney,
> Michael D <michael.d.kinney@intel.com>
> 抄送: Jiang, Guomin <guomin.jiang@intel.com>; Xu, Wei6
> <wei6.xu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Matthew
> Carlson <matthewfcarlson@gmail.com>
> 主题: RE: [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> > -----Original Message-----
> > From: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> > Sent: Thursday, October 15, 2020 1:43 PM
> > To: devel@edk2.groups.io
> > Cc: Jiang, Guomin <guomin.jiang@intel.com>; Xu, Wei6
> <wei6.xu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Kinney,
> Michael D
> > <michael.d.kinney@intel.com>; Matthew Carlson
> <matthewfcarlson@gmail.com>
> > Subject: [PATCH v1 1/1] FmpDevicePkg: Add RngLib instance to DSC
> >
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3010
> >
> > Commit b5701a4 in CryptoPkg introduced a dependency on RngLib.
> >
> > The FmpDevicePkg build currently fails since it does not specify
> > a RngLib instance and OpensslLib links against RngLib.
> >
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Wei6 Xu <wei6.xu@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Matthew Carlson <matthewfcarlson@gmail.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >  FmpDevicePkg/FmpDevicePkg.dsc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/FmpDevicePkg/FmpDevicePkg.dsc
> b/FmpDevicePkg/FmpDevicePkg.dsc
> > index bdb73f28288f..cfeadd833038 100644
> > --- a/FmpDevicePkg/FmpDevicePkg.dsc
> > +++ b/FmpDevicePkg/FmpDevicePkg.dsc
> > @@ -6,7 +6,7 @@
> >  # Capsules.  The behavior of the Firmware Management Protocol
> instance is
> >  # customized using libraries and PCDs.
> >  #
> > -# Copyright (c) 2016, Microsoft Corporation. All rights reserved.<BR>
> > +# Copyright (c) Microsoft Corporation.<BR>
> >  # Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.<BR>
> >  # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All
> rights reserved.<BR>
> >  #
> > @@ -57,6 +57,7 @@ [LibraryClasses]
> >    IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> >    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> >    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> > +  RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf
> >  !endif
> >
> FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpA
> uthenticationLibPkcs7.inf
> >
> CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/
> CapsuleUpdatePolicyLibNull.inf
> > --
> > 2.28.0.windows.1