public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <jake@nvidia.com>, <jbrasen@nvidia.com>,
	<ashishsingha@nvidia.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py
Date: Thu, 27 Jan 2022 09:18:00 +0800	[thread overview]
Message-ID: <000e01d8131b$b97d9710$2c78c530$@byosoft.com.cn> (raw)
In-Reply-To: <dada2e39f23f9b5292a7eb371544c9e83c46f0e7.1642722604.git.jake@nvidia.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jake Garver
> via groups.io
> 发送时间: 2022年1月21日 7:58
> 收件人: devel@edk2.groups.io; jbrasen@nvidia.com;
> ashishsingha@nvidia.com
> 抄送: Jake Garver <jake@nvidia.com>
> 主题: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py
> 
> Fix a Edk2Logger.warn() message format to match the arguments.
> 
> We ran into this after a failure in PcdValueInit.  The failure was
> masked by a new exception, "TypeError: not all arguments converted
> during string formatting".
> 
> Signed-off-by: Jake Garver <jake@nvidia.com>
> ---
>  BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
> b/BaseTools/Source/Python/Workspace/DscBuildData.py
> index 35ec5b37ff..d29b9bf13d 100644
> --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> @@ -3033,7 +3033,7 @@ class DscBuildData(PlatformBuildClassObject):
>              returncode, StdOut, StdErr = DscBuildData.ExecuteCommand
> (Command)
>              EdkLogger.verbose ('%s\n%s\n%s' % (Command, StdOut,
> StdErr))
>              if returncode != 0:
> -                EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not
> collect output from command: %s\n%s\n' % (Command, StdOut, StdErr))
> +                EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not
> collect output from command: %s\n%s\n%s\n' % (Command, StdOut, StdErr))
> 
>          #start update structure pcd final value
>          File = open (OutputValueFile, 'r')
> --
> 2.17.1
> 
> 
> 
> 
> 






  reply	other threads:[~2022-01-27  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 23:58 [PATCH] BaseTools: Fix error leg in DscBuildData.py jake
2022-01-27  1:18 ` gaoliming [this message]
2022-02-14 13:10 ` [edk2-devel] " Jake Garver
2022-02-15  5:32   ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000e01d8131b$b97d9710$2c78c530$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox